Create گلابزاده خالد عزیز - #12
Closed
gulabzadehkhaledaziz-rgb wants to merge 1 commit into
Closed
Conversation
Author
|
سلام |
Kendrick-Song
added a commit
that referenced
this pull request
Jul 28, 2026
Round-3 Minor findings final wrap: - #12: task-number leaks (Task 14 / 22 / 25) in released source docstrings replaced with descriptions of the current invariant. extract_user_profile.py:11-13,103-107 rewritten: the Task-14 registration gate it referenced was removed by ae5543d (Group I replaced it with per-strategy body-guards); the docstring's mutual-exclusion argument now correctly states the applies_to + body-guard mechanism. - #13a: test_backfill_batch_concurrency wall-clock assertion (span < total * 0.8) replaced with overlap assertion (p_start < s_end AND s_start < p_end). Tests concurrent execution semantic without CI-runner-latency assumption. - #13b: test_backfill_flags.py SIGINT-to-getpid test marked slow to protect against CI race where 0.3s timer fires before asyncio.Runner installs its handler. Subprocess variant deliberately not shipped (both variants would be slow-gated anyway; the added maintenance surface would not pay for itself). Docstring documents the exclusion rationale. - #5/#6/#8/#11-second: design-note docstrings at the relevant sites so future readers know these are accepted choices, not oversights. #8's rationale lives once in trigger_profile_clustering with pointers from the three sibling body-guards to avoid a four-copy paste-flood. Fixes PR #361 review Minor findings #5, #6, #8, #11 (abort semantic), #12, #13a, #13b. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
عکس برات فرستادم به آزادی تهران درست کن با موهای بلد داشته باشم و همچنین لباس بلوچی سفید برم کن