docs(lancedb): mark the husk sweep removable once lance#8322 ships - #399
Merged
Conversation
Upstream merged the fix on 2026-08-06: cleanup now removes the directories it empties, under the same 7-day / delete_unverified policy this sweep reimplements. It is not in any release yet (lancedb 0.34.0 embeds lance 8.0.0; the merge sits ahead of v11.0.0-beta.2), so the sweep stays -- but the next pin carrying it should delete this rather than keep a second copy of upstream's rule. That upgrade also collapses the documented horizon from ~14 days to ~7: lance drops the directory in the same pass that empties it, so our age gate stops stacking on top of theirs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Kendrick-Song
approved these changes
Aug 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #392. Upstream acted on one of the two issues that PR's investigation produced.
lance-format/lance#8320 —
cleanup_old_versionsunlinks a superseded index's files but never removes the directory — was fixed by lance#8322, merged 2026-08-06. It removes the emptied directories under the same 7-day /delete_unverifiedpolicy that_remove_empty_index_dirsreimplements on our side.The fix is not in any release yet: lancedb 0.34.0 embeds lance 8.0.0, and the merge commit sits ahead of v11.0.0-beta.2. So the sweep stays for now. This records why it should not stay forever, next to the code rather than in a chat log.
Two consequences worth having written down at the point of use:
_remove_empty_index_dirsand its call site should go — a second implementation of upstream's own rule is the kind of thing that survives for years because nobody remembers it was a workaround.Docs only — no behaviour change.
ruffclean, 1938 unit tests passing.🤖 Generated with Claude Code