docs: point commit-scope at README and finish public-phase cleanup#1
Merged
Merged
Conversation
Replace the hardcoded, stale commit-scope list in CLAUDE.md section 3.3 with a pointer to the README Repo layout section, and finish the public-phase wording: drop the internal-AI-stats framing and the GitLab-era JIRA / merge-request residue from the trailer rules, the PR-open flow, and the PR template. Co-authored-by: Claude (claude-opus-4-8) <noreply@anthropic.com>
JasonJarvan
pushed a commit
that referenced
this pull request
Jul 1, 2026
…t the tui fix #1 (stripping stdlib logging handlers) was a no-op because everos embedded structlog uses PrintLogger which calls print(message, file=None) writing directly to the live fd 1, bypassing the stdlib logging module entirely. the correct fix is an fd-level redirect: save fd1/fd2 with os.dup, open the tui log file (append, coexists with loguru's rotating sink on the same tui.log), os.dup2 into fd1/fd2, then restore in a finally block. this catches all terminal-write paths: structlog PrintLogger print calls, any bare print, and raw C-level fd writes. the redirect is activated in _run_rpc_server_until_done before backend.start() (where everos may emit lazy configure warnings on first recall()) and held through the inner try/finally that includes backend.stop(). the Node child inherited the real terminal fds at Popen time, before this function runs, so the parent-side dup2 does not affect the child's terminal. fix #1's _strip_tty_stream_handlers() is kept as defense-in-depth. three tests added to test_cli_log_file.py prove the helper captures both os.write(1,...) and print() payloads under capfd.disabled(), and that fd1 is restored after normal exit and on exception. one test added to test_cli_tui_commands.py spies on redirect_terminal_fds_to_file and asserts it is entered before backend.start() and exited after backend.stop(). Co-authored-by: Claude (claude-sonnet-4-6) <noreply@anthropic.com>
JasonJarvan
pushed a commit
that referenced
this pull request
Jul 1, 2026
The previous test issued two os.write(1, ...) calls and never called Python's print(). structlog's PrintLogger uses print(message, file=None) through sys.stdout (a TextIOWrapper), not raw os.write - so the old test could pass even if the TextIOWrapper path was broken (as happened in the Fix #1 regression). Replace the mislabeled os.write with a real print("print-leak-line", flush=True) so the assertion exercises the actual PrintLogger code path. The raw os.write("raw-fd-write") is kept to cover fd-level writes separately. Both must land in the redirect file. Co-authored-by: Claude (claude-sonnet-4-6) <noreply@anthropic.com>
Kendrick-Song
added a commit
that referenced
this pull request
Jul 22, 2026
- Move _everos_server.py from raven/cli/ to raven/plugin/memory/everos/ _server.py to fix plugin->cli layering violation (CR #1) - Split HTTP timeout: client default 60s (recall/health), memorize add/flush per-request 360s (CR #2) - Defer backend.start() to post-handshake background task in TUI so first render is not blocked by server startup (CR #3) - Remove unused app_id/project_id from ImportSession and scanner (CR #4) - Add note on per-source-unit checkpoint granularity (CR #5) - Add fcntl file lock to prevent concurrent server spawn race (CR #6) - Fix loguru %s format to {} in state.py (CR #7) - Fix docstring step numbering (CR #8) - Remove redundant Table import in status_cmd (CR #9) Co-authored-by: Claude (claude-opus-4-6) <noreply@anthropic.com>
Kendrick-Song
added a commit
that referenced
this pull request
Jul 22, 2026
- Move _everos_server.py from raven/cli/ to raven/plugin/memory/everos/ _server.py to fix plugin->cli layering violation (CR #1) - Split HTTP timeout: client default 60s (recall/health), memorize add/flush per-request 360s (CR #2) - Defer backend.start() to post-handshake background task in TUI so first render is not blocked by server startup (CR #3) - Remove unused app_id/project_id from ImportSession and scanner (CR #4) - Add note on per-source-unit checkpoint granularity (CR #5) - Add fcntl file lock to prevent concurrent server spawn race (CR #6) - Fix loguru %s format to {} in state.py (CR #7) - Fix docstring step numbering (CR #8) - Remove redundant Table import in status_cmd (CR #9) Co-authored-by: Claude (claude-opus-4-6) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Repo layoutsection, so there is a single source of truth that cannot drift..github/pull_request_template.md.Co-authored-byrequirement and the marketing-banner ban; added that GitHub renders the trailer as a co-author).Docs-only: no code, tests, or dependencies touched.
Type of change
Related issues (if there is)
Checklists
Development
Security
Code review