You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 1, 2025. It is now read-only.
do we maybe need to set a default value for the fetchOptions parameter so you don't have to pass null explicitly? or.. like does javascript do that automatically. i'm thinking like install(fetchOptions = null) maybe? i think it might just be undefined though if you don't pass it. just want to make sure it's backwards compatible
do we maybe need to set a default value for the fetchOptions parameter so you don't have to pass null explicitly? or.. like does javascript do that automatically. i'm thinking like install(fetchOptions = null) maybe? i think it might just be undefined though if you don't pass it. just want to make sure it's backwards compatible
JS automatically assigns undefined for parameters that are not passed and the spread operator (...) will return nothing when it tries to spread undefined or null. So calling install() is the same as calling install(undefined). If we want to have a safe default we could default to an empty object like install(fetchOptions = {})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9