Skip to content

refactor(ci): move the speed test into a separate script#795

Merged
joanise merged 1 commit intomainfrom
dev.ej/factor-out-profile-help
May 5, 2026
Merged

refactor(ci): move the speed test into a separate script#795
joanise merged 1 commit intomainfrom
dev.ej/factor-out-profile-help

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented May 5, 2026

PR Goal?

Factor out the code to check the time it takes to run everyvoice -h to make sure it stays fast

Fixes?

legibility, plus the .sh script is lintable

Priority?

normal

Tests added?

no

How to test?

Mostly look at the output of the "Make sure the CLI stays fast" step in CI, and the PR comment. They should stay as before.

You can also run ./profile-help-ci.sh but better pipe the output into less, it's optimized for CI logs, not interactive use. This will leave around two text files, importtime.txt and import-message.txt. That's on purpose, and they're now .gitignore'd. You can use them for analysis of what's wrong in your PR, too, if your PR is slowing things down.

Confidence?

pretty good

Version change?

nope

Related PRs?

nope

@joanise joanise requested a review from roedoejet May 5, 2026 19:13
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented May 5, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/test.yml  0% smaller
  .gitignore Unsupported file format
  profile-help-ci.sh Unsupported file format

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (8625bdc) to head (b2e3d27).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          47       47           
  Lines        4203     4203           
  Branches      615      615           
=======================================
  Hits         3506     3506           
  Misses        567      567           
  Partials      130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joanise

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

CLI load time: 0:00.33
Pull Request HEAD: b2e3d2745969eff72cd4f46d14698c0ce23bfaf5

Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1895 |     197504 | everyvoice.cli

@joanise joanise mentioned this pull request May 5, 2026
@joanise joanise merged commit 1706d00 into main May 5, 2026
13 checks passed
@joanise joanise deleted the dev.ej/factor-out-profile-help branch May 5, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants