Improve project build signing and publish timing#517
Conversation
22aeb63 to
3407c4c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22aeb639df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3407c4c to
ee0de5f
Compare
ee0de5f to
c9f4f56
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9f4f56f78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f0d2d20d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e89eb4a83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
SignDependencyAssembliesopt-in for copied dependency assembliesInternalsdirectory, instead of skipping by path nameAssemblyNamemetadataPublishFailFastfor reused NuGet/GitHub publishesTargetDirfor target frameworks that do not have conventional output folders, so custom output paths are still included in assembly signingAssemblyNamewhen signing first-party assemblies, so conditional/imported project metadata signs the produced assembly instead of a raw XML fallbackdotnet nuget signinvocationPackStrategy=MSBuildas the build-once path: batch build selected projects, sign outputs, then pack withNoBuild=trueValidation
dotnet test .\PowerForge.Tests\PowerForge.Tests.csproj -c Release --no-restore --filter "DotNetRepositoryReleaseServiceTests|DotNetNuGetClientTests|ProjectBuildPreparationServiceTests|NuGetPackagePublishServiceTests|ModulePipelinePackageBuildTests|ProjectBuildWorkflowServiceTests|ProjectBuildGitHubPreflightTests|PowerForgeProjectCmdletTests|ProjectBuildPublishHostServiceTests"(110 passed)dotnet build .\PowerForge.PowerShell\PowerForge.PowerShell.csproj -c Release -f net472 --no-restore --nologogit diff --checkOfficeIMO timing evidence
dotnet packtime 44.0s, release zip 27.0s, NuGet package signing 132.0sNotes