Keep generated ALC helpers private#518
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FunctionsToExportWhy
PSWriteOffice's packaged ALC conflict lane was failing after the OfficeIMO release because the generated
Import-<ModuleName>DevelopmentBinaryModulehelper was being detected as a public function export. Documentation parity then required command docs for that internal helper. Binary conflict scanning itself remains advisory-only: the Desktop advisory is shown, but the build continues.Validation
dotnet build .\PSPublishModule.sln --nologodotnet test .\PowerForge.Tests\PowerForge.Tests.csproj --filter "FullyQualifiedName~ModuleBuilderManifestMutatorTests|FullyQualifiedName~ModulePipelineExportAssemblyInferenceTests" --no-build --nologo --verbosity normal