Skip to content

Respect image formatter settings#104

Merged
Gabriel-Darbord merged 1 commit into
mainfrom
respect-image-formatter-settings
Jul 16, 2026
Merged

Respect image formatter settings#104
Gabriel-Darbord merged 1 commit into
mainfrom
respect-image-formatter-settings

Conversation

@Gabriel-Darbord

Copy link
Copy Markdown
Member

Summary

  • use a fresh image-configured formatter for each MCP method formatting pass
  • stop overriding the formatter maximum line length
  • remove the scoped-line-length test while retaining the method reformatting behavior test

Diagnosis

On Pharo 12 and 13, formatter instances share the default formatter context. Setting an instance maximum line length therefore changed the image-wide setting and made the test order-dependent.

Verification

  • Pharo 12 focused reformatting test passes with the image maximum line length set to 70
  • Pharo 12 full MCP-Tests and MCP-UI-Tests suite: 717 passed
  • the image formatter maximum remains 70 after the full suite
  • git diff --check passes

@Gabriel-Darbord
Gabriel-Darbord force-pushed the respect-image-formatter-settings branch from 0e24cb6 to 34faca5 Compare July 16, 2026 07:27
@Gabriel-Darbord
Gabriel-Darbord merged commit 7cbea30 into main Jul 16, 2026
3 checks passed
@Gabriel-Darbord
Gabriel-Darbord deleted the respect-image-formatter-settings branch July 16, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant