Skip to content

Allow explicit self return in no-op methods#105

Merged
Gabriel-Darbord merged 1 commit into
mainfrom
allow-noop-explicit-self-return
Jul 16, 2026
Merged

Allow explicit self return in no-op methods#105
Gabriel-Darbord merged 1 commit into
mainfrom
allow-noop-explicit-self-return

Conversation

@Gabriel-Darbord

Copy link
Copy Markdown
Member

Summary

  • only report MCPRedundantExplicitSelfReturnRule when a final ^ self follows another top-level statement
  • accept a method whose complete body is ^ self as an intentional no-op
  • update the rule rationale and focused method-compile coverage

Verification

  • focused explicit-self-return tests: 2 passed
  • Pharo 13 MCP-Tests and MCP-UI-Tests: 718 passed
  • git diff --check passes

@Gabriel-Darbord
Gabriel-Darbord merged commit b8b22b8 into main Jul 16, 2026
3 checks passed
@Gabriel-Darbord
Gabriel-Darbord deleted the allow-noop-explicit-self-return branch July 16, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant