docs: scope each package README's release badge to its own tag - #33
Merged
Conversation
The workspace README's package table and layout tree still only named trilean and trilean-sql, from before trilean-regex existed, and its own badge row carried package-specific npm/release badges for a single package even though the workspace now holds three independently versioned ones. Every package's Release badge pointed at the repo's overall latest release rather than its own tag, so trilean's own README was showing trilean-sql's version the moment trilean-sql released after it -- fixed by filtering each badge to that package's own name@* tag pattern. trilean-sql and trilean-regex had no badge row at all; both now carry the same GitHub/npm/Release/CI row trilean already had, scoped to their own package.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace README's package table and layout tree only named
trilean/trilean-sql, predatingtrilean-regex. Every package's own Release badge pointed at the repo's overall latest release rather than its own tag —trilean's README was showingtrilean-sql's version the momenttrilean-sqlreleased after it, sinceimg.shields.io/github/v/releasewith no filter just shows whatever release is newest across the whole repo. Fixed by filtering each package's badge to its ownname@*tag pattern (shields.io supports afilterquery param for this, verified against the live badges before committing).trilean-sqlandtrilean-regexhad no badge row at all; both now carry the same GitHub/npm/Release/CI rowtrileanalready had, scoped to their own package. Workspace README's package table now lists all three packages (including their GitHub Packages mirrors, confirmed all three actually publish there) and the layout tree includestrilean-regex/.