feat(core): add bytesFromHex, the arbitrary-length reverse of bytesToHex - #90
Merged
Conversation
A domain needing to decode a message-id, token-id, or other arbitrary-length bstr back from its hex text form (e.g. constructing a message-ref for a reply) had no generic reverse of bytesToHex to reach for -- only deviceIdFromHex, fixed to the 32-byte device-id case. deviceIdFromHex now delegates its own byte decoding to this function rather than duplicating the same loop.
Mearman
marked this pull request as ready for review
September 12, 2026 09:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mearman
added a commit
to ExaDev/agent-comms
that referenced
this pull request
Sep 12, 2026
mesh-store.ts's own room.send fan-out needs bytesFromHex (added upstream in ExaDev/wire-mesh#90) to encode a reply's referenced message-id back into the wire's message-ref bytes; 1.0.3 predates that export.
Mearman
added a commit
to ExaDev/agent-comms
that referenced
this pull request
Sep 12, 2026
mesh-store.ts's own room.send fan-out needs bytesFromHex (added upstream in ExaDev/wire-mesh#90) to encode a reply's referenced message-id back into the wire's message-ref bytes; 1.0.3 predates that export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed while building agent-comms' own room.send message-ref support (a reply needs to encode the referenced message's own hex id back into the message-ref's raw bytes) -- bytesToHex has no generic reverse, only deviceIdFromHex, which is fixed to the 32-byte device-id case.
deviceIdFromHex now delegates its own decoding to bytesFromHex rather than duplicating the same hex-pair loop.