Port parquet codec to v0.54.0-exaforce#36
Merged
sundaresanr merged 1 commit intov0.54.0-exaforcefrom Apr 21, 2026
Merged
Conversation
sundaresanr
force-pushed
the
v0.54.0-exaforce-parquet
branch
3 times, most recently
from
b1f167c to
b972a5c
Compare
Brings the parquet codec from v0.51-exaforce-parquet (PR #35) onto upstream v0.54.0. Enables the aws_s3 sink to emit parquet files via `encoding.codec: parquet`, preserving the existing user-facing config that production vector configs already use. Design differences vs PR #35, to fit v0.54's already-reshaped batched encoding infrastructure: - Upstream v0.54 gained a `BatchSerializer` enum (in lib/codecs/src/encoding/encoder.rs) with an `Arrow` variant behind the `arrow` feature, plus `BatchEncoder` and `EncoderKind::Batch`. We add `BatchSerializer::Parquet(ParquetSerializer)` alongside the `Arrow` variant rather than defining a new `BatchSerializer` enum in serializer.rs. `EncoderKind::Batch` is now ungated. - aws_s3 sink's `S3RequestOptions::encoder` switches from `(Transformer, Encoder<Framer>)` to `(Transformer, EncoderKind)`. The existing `Encoder<Vec<Event>> for (Transformer, EncoderKind)` impl in src/sinks/util/encoding.rs dispatches between framed and batched paths, so there is no need for the `Arc<dyn Encoder>` polymorphism PR #35 used on v0.51. - `(Transformer, BatchEncoder)` impl is no longer gated behind `codecs-arrow`, since parquet is now always-on. Parquet support itself is unchanged: `lib/codecs/src/encoding/format/parquet.rs` is copied verbatim from PR #35 (parquet 39.0.0, 1317 lines), and `SerializerConfig::Parquet { parquet: ParquetSerializerOptions }` plus `SerializerConfig::build_batched()` and `EncodingConfigWithFraming::build_batched()` are preserved. Verified with `cargo check -p vector` (default features).
sundaresanr
force-pushed
the
v0.54.0-exaforce-parquet
branch
from
b972a5c to
655c841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design differences vs PR #35
Upstream v0.54 independently added a batched encoding scaffold (`BatchSerializer`, `BatchEncoder`, `EncoderKind::Batch`) in `lib/codecs/src/encoding/encoder.rs` with an `Arrow` variant behind the `arrow` feature. Rather than ship PR #35's duplicate `BatchSerializer` enum in `serializer.rs`, this PR:
`lib/codecs/src/encoding/format/parquet.rs` itself is copied verbatim (parquet 39.0.0, 1317 lines). `SerializerConfig::Parquet { parquet: ParquetSerializerOptions }`, `SerializerConfig::build_batched()`, and `EncodingConfigWithFraming::build_batched()` all preserved.