You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?
In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?
I don't know if release is required. Would data need to be released every time we load new data into memory?
We should support entities_to_keep and entities_to_delete. Let's add a ticket to the backlog for that.
In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?
I don't know if release is required. Would data need to be released every time we load new data into memory?
I know that we need to release the data to make any structural changes (schema or indexes). For adding new data we should keep it loaded.
In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?
I don't know if release is required. Would data need to be released every time we load new data into memory?
I know that we need to release the data to make any structural changes (schema or indexes). For adding new data we should keep it loaded.
ok, these changes are not supported yet (if ever) so I think we can keep it as is for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
read / write / update - fixes various issues found while integration testing