Skip to content

Feature/integration test improvements#23

Merged
michaelbackes merged 3 commits into
masterfrom
feature/integration_test_improvements
Aug 25, 2023
Merged

Feature/integration test improvements#23
michaelbackes merged 3 commits into
masterfrom
feature/integration_test_improvements

Conversation

@michaelbackes

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
read / write / update - fixes various issues found while integration testing

@piket

piket commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?

@michaelbackes

Copy link
Copy Markdown
Collaborator Author

In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?

I don't know if release is required. Would data need to be released every time we load new data into memory?

We should support entities_to_keep and entities_to_delete. Let's add a ticket to the backlog for that.

@piket

piket commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?

I don't know if release is required. Would data need to be released every time we load new data into memory?

I know that we need to release the data to make any structural changes (schema or indexes). For adding new data we should keep it loaded.

@michaelbackes

Copy link
Copy Markdown
Collaborator Author

In the update method, do we need to add a collection.release() before any operations? Also, it looks like we don't do anything with the entities_to_keep and entities_to_delete parameters. Do we have a plan to add in that support?

I don't know if release is required. Would data need to be released every time we load new data into memory?

I know that we need to release the data to make any structural changes (schema or indexes). For adding new data we should keep it loaded.

ok, these changes are not supported yet (if ever) so I think we can keep it as is for now

@michaelbackes
michaelbackes merged commit 01867f4 into master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants