[HOLD for payment 2023-02-18] [$4000] mWeb/Chrome - Payment - The keyboard overlaps the "Make default payment method" button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Preconditional: account should have 2 or more payment method

1. Go to URL https://staging.new.expensify.com/
2. Log in any account
3. Go to Settings -> Payment
4. Tap on the bank account that doesn't have the "default" label
5. Tap on "Make default payment method" button

Expected Result:

The keyboard NOT overlaps the "Make default payment method" button

Actual Result:

The keyboard overlaps the "Make default payment method" button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / Chrome

Version Number: 1.2.48.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d2060c28a0b19842
• Upwork Job ID: 1613576223743619072
• Last Price Increase: 2023-01-26

[kevinksullivan]

The screenshot isn't showing my keyboard, but this flow doesn't seem broken to me when I test it out. @kbecciv do you have a screenshot or video that shows this is reproducible?

[kbecciv]

Checking with team, get back to you shortly

[jasperhuangg]

@kevinksullivan @kbecciv

It looks like we didn't anticipate how tall the software keyboard would be, something unique about the Android Chrome keyboard is that it includes the numbers + recommended autofill text above it which adds a LOT of height. This doesn't really appear on other platforms.

You can see it pretty clearly above, underneath the autofill recommendations (pictured on the left) is the rest of the "Make default payment method" button and the margins below it.

I think all that needs to happen here is we add some extra padding with the keyboardVerticalOffset prop on the KeyboardAvoidingView wrapping this on Android Chrome to account for the height of the autofill recommendations row.

However, to do this, we need a way to detect if we're currently on Android Chrome, which I don't think currently exists. Do we know if this problem crops up in other views on Android Chrome?

cc @tgolen

[kbecciv]

@jasperhuangg Please, attached the video.

Record_2023-01-06-09-36-51.mp4

[tgolen]

we need a way to detect if we're currently on Android Chrome

We don't have this, no. I'd prefer if we could find a solution that works on all mobileWeb. I think that it would probably be fine to add some more padding regardless of the platform. I think it could also fix this issue for example: #13633

[jasperhuangg]

@tgolen thanks for the clarification here

I'd prefer if we could find a solution that works on all mobileWeb.

yeah that makes sense, I'll quickly spin up a PR adding some padding and we can see how it looks on all platforms, then we can see how Design (Shawn 😅 ) feels about it?

My only concern is that the extra padding might look jank on iOS, but we'll see in the PR