Android - Security - 2FA page is broken for specific phone modal

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #18576

Action Performed:

1. Launch the app
2. Log in with any account
3. Go to Settings - Security - Two-factor authentication

Expected Result:

2FA page is not broken for specific phone modal

Actual Result:

2FA page is broken for specific phone modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16.3

Reproducible in staging?: Yes

Reproducible in production?: new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/73042af8b0441b2cd7e7e69ea36f109d12f5f4ca1e8bd2cb74b91c6059b707c0

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Security - 2FA page is broken for specific phone modal

What is the root cause of that problem?

This issue actually happens on small width screen size, since we are using twoFactorAuthCode styles for the text in here:

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Lines 83 to 93 in 7378626

	<View style={styles.twoFactorAuthCodesContainer}>
	{Boolean(props.account.recoveryCodes) &&
	_.map(props.account.recoveryCodes.split(', '), (code) => (
	<Text
	style={styles.twoFactorAuthCode}
	key={code}
	>
	{code}
	</Text>
	))}
	</View>

App/src/styles/styles.js

Lines 2160 to 2165 in 7378626

	twoFactorAuthCode: {
	fontFamily: fontFamily.MONOSPACE,
	width: 100,
	height: 18,
	textAlign: 'center',
	},

The problem came from width: 100 of the text, width small screen size, it won't have enough space for 2 text in one row which cause this issue.

What changes do you think we should make in order to solve the problem?

We shouldn't use the width here, instead we should remove the width and update the justify-content of the text parent view to space-around. (We can also use space-evenly).

    twoFactorAuthCodesContainer: {
        alignItems: 'center',
        justifyContent: 'space-around',
        flexDirection: 'row',
        flexWrap: 'wrap',
        gap: 12,
        height: 148,
    },

    twoFactorAuthCode: {
        fontFamily: fontFamily.MONOSPACE,
        // width: 100,
        height: 18,
        textAlign: 'center',
    },

What alternative solutions did you explore? (Optional)

N/A

[kbecciv]

Affected devices: Samsung Galaxy S21 and Samsung S20 FE

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Security - 2FA page is broken for specific phone modal

What is the root cause of that problem?

We're setting a fixed height for the wrapper element of codes

App/src/styles/styles.js

Line 2157 in 7378626

height: 148,

It makes children components overflow in small screen devices

What changes do you think we should make in order to solve the problem?

We can remove fixed height above so it let wrapper element shrink/grow depend on children components

Results

[dhairyasenjaliya]

Dupe it will resolve here #19187

[puneetlath]

Thanks @dhairyasenjaliya. Closing as dupe.