[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] LHN - IOU report page of amount changed is shown options to pin in LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money
4. Enter an amount
5. Tap next
6. Select any user
7. Tap request amount
8. Tap on IOU
9. Tap on IOU in report page
10. Tap on amount and change the IOU request amount
11. Go to LHN
12. Open the new IOU report for changed request amount displayed
13. Navigate to LHN and long press the new IOU report for changed request amount displayed

Expected Result:

The IOU report page of request amount changed has no pinned options and in LHN also when long pressing it, pinned option must not be shown

Actual Result:

The IOU report page of request amount changed has no pinned options. But in LHN, when long pressing IOU report of changed request amount, pinned option is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6200606_pin_iou.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0112a786dd027cefd2
• Upwork Job ID: 1704236046264397824
• Last Price Increase: 2023-10-03
• Automatic offers:
• DylanDylann | Contributor | 27099388

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pin option is shown for IOU transaction thread in LHN

What is the root cause of that problem?

We show pin option in cases below statement returns true

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 338 in 62b8e71

type === CONTEXT_MENU_TYPES.REPORT && !isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID),

As you can see, we don't show Pin option for money request report(IOU report or Expense report). We don't limit the Pin option for IOU/Expense transaction thread.

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to limit the Pin option for IOU/Expense transaction thread. Add the !ReportUtils.isMoneyRequest(reportID) condition like below

        type === CONTEXT_MENU_TYPES.REPORT && !isPinnedChat && !ReportUtils.isMoneyRequestReport(reportID) && !ReportUtils.isMoneyRequest(reportID),

This works fine

Result

27458.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0112a786dd027cefd2

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[johncschuster]

Sorry I missed this one! Triaged!