[$500] Edit message, save/cancel and visiting different report removes focus from composer

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.86-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697650111645879

Action Performed:

1. Open the app
2. Open any report
3. Send any message
4. Edit the message
5. Save or cancel the edit message
6. Visit another report and observe that app does not focus on composer

Expected Result:

App should focus on composer whenever we visit any report

Actual Result:

App does not focus on composer when we edit any message, save/cancel the mesage and visit any other report

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android.chrome.no.focus.on.composer.mp4

Android: mWeb Chrome

Android.app.no.focus.composer.mp4

iOS: Native

ios.native.no.focus.on.composer.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

mac.chrome.no.focus.on.composer.mov

Recording.124.mp4

MacOS: Desktop

mac.desktop.no.focus.on.composer.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2dccea0afb54c13
• Upwork Job ID: 1714761073301872640
• Last Price Increase: 2023-11-08

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2dccea0afb54c13

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer is not focused when user has edited a chat from different report

What is the root cause of that problem?

Within deleteDraft which is called in the triggerSaveOrCancel method, composer focused is set to false thus loses its focus state:

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 275 to 276 in 1ed55e0

	const deleteDraft = useCallback(() => {
	InputFocus.callback(() => setIsFocused(false));

isFocused triggers composerFocusKeepFocusOn on an effect that then read from the state value to remove the focus ref.

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 136 to 138 in 1ed55e0

	useEffect(() => {
	InputFocus.composerFocusKeepFocusOn(textInputRef.current, isFocused, modal, onyxFocused);
	}, [isFocused, modal, onyxFocused]);

What changes do you think we should make in order to solve the problem?

Remove the offending line that triggers the focus state change:

const deleteDraft = useCallback(() => {
        // InputFocus.callback(() => setIsFocused(false)); << remove this line
        InputFocus.inputFocusChange(false);

What alternative solutions did you explore? (Optional)

N/A

[abzokhattab]

is it a regression from #29073 ?

[ayazalavi]

@narefyev91 please take a look

[hoangzinh]

@ayazalavi can you confirm that it's a regression from your PR #29073?