[Due for payment 2025-12-30] Reports - "Maximum tax amount is 0.00" when editing amount after enabling Tax

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77836
Email or phone of affected tester (no customers): sdjoinsjoisjoisdnjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Go to Reports > Expenses.
5. Click Columns.
6. Select Tax.
7. Click Save.
8. Click on the expense.
9. Click Amount.
10. Edit the amount and save it.

Expected Result:

Amount can be edited.

Actual Result:

Amount cannot be edited. "Maximum tax amount is MYR 0.00" error shows up.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When editing an expense amount after enabling the Tax column, users see the error "Maximum tax amount is MYR 0.00" and cannot save the edited amount.

What is the root cause of that problem?

In MoneyRequestAmountForm.tsx, the code checks if the current page is a tax amount form using Navigation.getActiveRoute().includes('taxAmount'). This method returns the full route including query parameters. When editing a regular amount (not tax), the route contains ?taxAmount=0 as a query parameter, which causes the check to incorrectly identify the page as a tax amount form. The tax validation then triggers with taxAmount=0, causing any amount greater than 0 to fail validation.

App/src/pages/iou/MoneyRequestAmountForm.tsx

Line 142 in 14818a7

const isTaxAmountForm = Navigation.getActiveRoute().includes('taxAmount');

What changes do you think we should make in order to solve the problem?

Use Navigation.getActiveRouteWithoutParams() instead of Navigation.getActiveRoute() to check the route path without query parameters. This ensures the check only matches when the actual route path contains /taxAmount, not when it appears in query parameters.

We should change isTaxAmountForm to:

const isTaxAmountForm = Navigation.getActiveRouteWithoutParams().includes('taxAmount');

here

App/src/pages/iou/MoneyRequestAmountForm.tsx

Line 142 in 14818a7

const isTaxAmountForm = Navigation.getActiveRoute().includes('taxAmount');

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[luacmartins]

@samranahm which PR caused the regression?