[CP Staging] Fix Custom Columns deploy blockers #78056
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
melvin-bot
bot
requested review from
DylanDylann and
JmillsExpensify
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
luacmartins
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix Custom Columns deploy blockers (cherry picked from commit 2f2f8f0) (cherry-picked to staging by luacmartins) (cherry-picked to staging by luacmartins)
…375169439-1 🍒 Cherry pick PR #78056 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.84-2 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.85-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀
|
| <View style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.TITLE)]}> | ||
| <TextCell | ||
| text={transactionItem.report?.reportName ?? ''} | ||
| text={computeReportName(transactionItem.report) ?? transactionItem.report?.reportName ?? ''} |
There was a problem hiding this comment.
@luacmartins I believe you should fetch report name from report attributes key. Can you please raise a fix to fix this?
There was a problem hiding this comment.
Is this causing an issue? AFAIK we use computeReportName to compute the report name since report.reportName doesn't have the correct name for IOUs for example
There was a problem hiding this comment.
@luacmartins computeReportName is a very expensive function for generating report names. We do the report name generation in the derived value system. Using derived values, we can get rid of redundant operations.
There was a problem hiding this comment.
I see. I think we should update this comment then to suggest using the derived value
Explanation of Change
Fixes several blockers related to custom columns
Fixed Issues
$ #78021
$ #78026
$ #78031
$ #78038
$ #78049
$ #78072
$ #78042
Tests
Same as fixed issues
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
#78021
Screen.Recording.2025-12-18.at.2.32.26.PM.mov
#78026
Screen.Recording.2025-12-18.at.3.19.36.PM.mov
#78031
Screen.Recording.2025-12-18.at.3.35.01.PM.mov
#78072
Screen.Recording.2025-12-18.at.6.20.05.PM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari