Changelog messages about Rules are not translated to Italian, Polski, Portuguese, etc

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77639 steps 12, 24, 36 etc
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: MacBook Air 15.7.3
App Component: Other

Action Performed:

1. Sign in to ND
2. Create a control workspace, enable Rules
3. Set the Receipt required amount to $100
4. Navigate to the #admins room, open system messages thread
5. Verify that a changelog entry appears "set receipt required amount to "$100.00"
6. Change the app language to any other language below French in Preferences
7. Observe the changelog message

Expected Result:

The changelog message is translated correctly

Actual Result:

The changelog messages about changes in Receipt required amount, Max expense amount, Max expense age are not translated to Italian, Polski, Portuguese, etc

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7050417_1768504190906.Not_translated.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rayane-d

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #77639

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #77639 - "Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age" by @rayane-d (High confidence)
Related Issues: None

Recommendation: ROLL FORWARD

This PR added new translation keys for Rules changelog messages (receipt required amount, max expense amount, max expense age) but forgot to provide proper translations for several languages. The English fallback text is being displayed for Italian, Polish, Portuguese, Dutch, Japanese, and Chinese (partially).

A roll forward fix is recommended because:

1. The core functionality works correctly - changelog messages are displayed
2. Only translation strings are missing (cosmetic issue for non-English users)
3. The fix is simple: add the missing translations to the affected language files
4. The feature was properly tested in English and several other languages (German, Spanish, French)

Labels: No label changes needed. This is a Frontend bug and should keep DeployBlockerCash since it requires an App PR to fix the translations.

📋 Detailed Analysis

Evidence

PR #77639 was identified by melvin-bot as the causing PR and testing steps 12, 24, 36 explicitly verify that "the changelog message is translated as expected" - which is precisely what is failing.

The bug is reproducible only on staging (version 9.3.3-0), not in production, which confirms it was introduced by a recent PR in the current deploy cycle. PR #77639 is listed in the current StagingDeployCash issue (#79701).

Verification

I examined the PR diff and confirmed that it modified all language files in src/languages/:

• Added 9 new translation keys: setReceiptRequiredAmount, changedReceiptRequiredAmount, removedReceiptRequiredAmount, setMaxExpenseAmount, changedMaxExpenseAmount, removedMaxExpenseAmount, setMaxExpenseAge, changedMaxExpenseAge, removedMaxExpenseAge
• These keys are used in src/libs/ReportActionsUtils.ts to generate changelog messages for Rules changes

Checking the current state of language files:

Correctly translated:

• English (en.ts) ✅
• German (de.ts) ✅
• Spanish (es.ts) ✅
• French (fr.ts) ✅

Missing translations (English text used):

• Italian (it.ts) ❌ - All 9 strings in English
• Polish (pl.ts) ❌ - All 9 strings in English
• Portuguese (pt-BR.ts) ❌ - All 9 strings in English
• Dutch (nl.ts) ❌ - All 9 strings in English
• Japanese (ja.ts) ❌ - All 9 strings in English
• Chinese (zh-hans.ts) ⚠️ - 3 strings in English (setReceiptRequiredAmount, changedReceiptRequiredAmount, removedReceiptRequiredAmount)

Root Cause

PR #77639 added new translation keys for Rules changelog messages. While the PR properly translated the strings for English, German, Spanish, and French, it left the English text as placeholders in Italian, Polish, Portuguese, Dutch, Japanese, and Chinese language files. When users change their app language to these languages, the changelog messages display in English instead of being translated.

Example from src/languages/it.ts line 6639-6647:

setReceiptRequiredAmount: ({newValue}: UpdatedPolicyFieldWithNewAndOldValueParams) => `set receipt required amount to "${newValue}"`,
changedReceiptRequiredAmount: ({oldValue, newValue}: UpdatedPolicyFieldWithNewAndOldValueParams) => `changed receipt required amount to "${newValue}" (previously "${oldValue}")`,
removedReceiptRequiredAmount: ({oldValue}: UpdatedPolicyFieldWithNewAndOldValueParams) => `removed receipt required amount (previously "${oldValue}")`,

These should be in Italian but are in English.