Skip to content

Conversation

@rayane-d
Copy link
Contributor

@rayane-d rayane-d commented Dec 14, 2025

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/576535
PROPOSAL:

Tests

Prerequisites

  • A control plan workspace
  • Admin access to the workspace
  • Rules feature enabled on the workspace
  • Go to workspace settings
  • Make any change that generates a changelog (e.g., rename the workspace) twice to ensure the system messages thread exists
  • Go to the workspace #admins room
  • Verify that a system messages thread is created

Test Steps 1

Steps:

  1. Navigate to Settings > Workspaces > [Your Workspace] > More features

  2. Enable Rules

  3. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  4. Click on the Receipt required amount field

  5. Add an amount (e.g. $100)

  6. Save it

  7. Navigate to the #admins room

  8. Open the system messages thread

  9. Verify that: A changelog entry appears in the system messages thread in the #admins room

  10. Verify that: Message format: set receipt required amount to "$100.00"
    13, Verify that: The LHN sidebar preview shows the correct changelog message text

  11. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  12. Verify that: Change app language, and verify that the changelog message is translated as expected

  13. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

  14. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  15. Click on the Receipt required amount field

  16. Edit the amount (e.g. change it from $100 to $200)

  17. Save it

  18. Navigate to the #admins room

  19. Open the system messages thread

  20. Verify that: A changelog entry appears in the system messages thread in the #admins room

  21. Verify that: Message format: changed receipt required amount to "$200.00" (previously "$100.00")

  22. Verify that: The LHN sidebar preview shows the correct changelog message text

  23. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  24. Verify that: Change app language, and verify that the changelog message is translated as expected

  25. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

  26. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  27. Click on the Receipt required amount field

  28. Remove the amount

  29. Save it

  30. Navigate to the #admins room

  31. Open the system messages thread

  32. Verify that: A changelog entry appears in the system messages thread in the #admins room

  33. Verify that: Message format: removed receipt required amount (previously "$200.00")

  34. Verify that: The LHN sidebar preview shows the correct changelog message text

  35. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  36. Verify that: Change app language, and verify that the changelog message is translated as expected

  37. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly


Test Steps 2

Steps:

  1. Navigate to Settings > Workspaces > [Your Workspace] > More features
  2. Enable Rules
  3. Navigate to Settings > Workspaces > [Your Workspace] > Rules
  4. Click on the Max expense amount field
  5. Add an amount (e.g. $100)
  6. Save it
  7. Navigate to the #admins room
  8. Open the system messages thread

Expected Results:

  • A changelog entry appears in the system messages thread in the #admins room
  • Message format: set max expense amount to "$100.00"
  • The LHN sidebar preview shows the correct changelog message text
  • Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
  • Change app language, and verify that the changelog message is translated as expected
  • Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
  1. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  2. Click on the Receipt required amount field

  3. Edit the amount (e.g. change it from $100 to $200)

  4. Save it

  5. Navigate to the #admins room

  6. Open the system messages thread

  7. Verify that: A changelog entry appears in the system messages thread in the #admins room

  8. Verify that: Message format: It should be changed max expense amount to "$200.00" (previously "$100.00")

  9. Verify that: The LHN sidebar preview shows the correct changelog message text

  10. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  11. Verify that: Change app language, and verify that the changelog message is translated as expected

  12. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

  13. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  14. Click on the Receipt required amount field

  15. Remove the amount

  16. Save it

  17. Navigate to the #admins room

  18. Open the system messages thread

  19. Verify that: A changelog entry appears in the system messages thread in the #admins room

  20. Verify that: Message format: removed max expense amount (previously "$200.00")

  21. Verify that: The LHN sidebar preview shows the correct changelog message text

  22. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  23. Verify that: Change app language, and verify that the changelog message is translated as expected

  24. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly


Test Steps 3

Steps:

  1. Navigate to Settings > Workspaces > [Your Workspace] > More features

  2. Enable Rules

  3. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  4. Click on the Max expense age field

  5. Add a value (e.g. 15 days)

  6. Save it

  7. Navigate to the #admins room

  8. Open the system messages thread

  9. Verify that: A changelog entry appears in the system messages thread in the #admins room

  10. Verify that: Message format: set max expense age to "15" days

  11. Verify that: The LHN sidebar preview shows the correct changelog message text

  12. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  13. Verify that: Change app language, and verify that the changelog message is translated as expected

  14. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

  15. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  16. Click on the Max expense age field

  17. Edit the amount (e.g. change it from 15 days to 30 days)

  18. Save it

  19. Navigate to the #admins room

  20. Open the system messages thread7. Verify that: A changelog entry appears in the system messages thread in the #admins room

  21. Verify that: Message format: changed max expense age to "30" days (previously "15")

  22. Verify that: The LHN sidebar preview shows the correct changelog message text

  23. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  24. Verify that: Change app language, and verify that the changelog message is translated as expected

  25. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

  26. Navigate to Settings > Workspaces > [Your Workspace] > Rules

  27. Click on the Max expense age field

  28. Remove the value

  29. Save it

  30. Navigate to the #admins room

  31. Open the system messages thread

  32. Verify that: A changelog entry appears in the system messages thread in the #admins room

  33. Verify that: Message format: removed max expense age (previously "30" days)

  34. Verify that: The LHN sidebar preview shows the correct changelog message text

  35. Verify that: Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly

  36. Verify that: Change app language, and verify that the changelog message is translated as expected

  37. Verify that: Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly

Image
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot
Copy link

melvin-bot bot commented Dec 14, 2025

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 83.76% <ø> (ø)
src/libs/SidebarUtils.ts 80.57% <50.00%> (-0.13%) ⬇️
src/pages/home/report/PureReportActionItem.tsx 52.66% <50.00%> (-0.01%) ⬇️
src/libs/OptionsListUtils/index.ts 73.20% <50.00%> (-0.08%) ⬇️
src/libs/ReportNameUtils.ts 83.05% <50.00%> (-0.45%) ⬇️
src/libs/ReportUtils.ts 71.37% <50.00%> (+<0.01%) ⬆️
...ges/home/report/ContextMenu/ContextMenuActions.tsx 0.76% <0.00%> (-0.01%) ⬇️
src/libs/ReportActionsUtils.ts 54.21% <65.21%> (+0.82%) ⬆️
... and 23 files with indirect coverage changes

@rayane-d rayane-d changed the title Policy changelog unexpected defaults [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age Dec 14, 2025
@rayane-d rayane-d changed the title [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age [Hold Auth#18751 Web-E#49825] [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age Dec 24, 2025
@rayane-d
Copy link
Contributor Author

Added automated tests

@rayane-d rayane-d requested a review from inimaga December 24, 2025 22:55
@rayane-d rayane-d marked this pull request as ready for review December 24, 2025 22:55
@rayane-d rayane-d requested review from a team as code owners December 24, 2025 22:55
@melvin-bot melvin-bot bot requested review from QichenZhu and removed request for a team December 24, 2025 22:56
@melvin-bot
Copy link

melvin-bot bot commented Dec 24, 2025

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rayane-d
Copy link
Contributor Author

rayane-d commented Jan 2, 2026

Updated based on this review comment: https://github.com/Expensify/Auth/pull/18751#pullrequestreview-3618118639

@rayane-d rayane-d marked this pull request as draft January 2, 2026 14:25
@rayane-d rayane-d marked this pull request as ready for review January 2, 2026 14:26
@rayane-d
Copy link
Contributor Author

rayane-d commented Jan 2, 2026

resolved the merge conflicts

@rayane-d rayane-d changed the title [Hold Auth#18751 Web-E#49825] [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age Jan 8, 2026
@rayane-d
Copy link
Contributor Author

rayane-d commented Jan 8, 2026

@madmax330 - Could you confirm whether this PR needs a C+ review?

@QichenZhu
Copy link
Contributor

Thanks! Happy to help if needed.

@inimaga
Copy link
Contributor

inimaga commented Jan 9, 2026

Could you confirm whether this PR needs a C+ review?

Yes it does. @QichenZhu Could you help with carrying out complete testing and review of this PR? Thanks!

@rayane-d rayane-d changed the title [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age [Hold Spanish translation confirmation] [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age Jan 9, 2026
@QichenZhu
Copy link
Contributor

QichenZhu commented Jan 12, 2026

Bug: the header doesn't show the same message 'set max expense amount to "$100"' after replying in thread in Android and iOS HybridApps.

77639-bug-1.webm

Also, the message is not translated.

Simulator Screenshot - iPhone 17 - 2026-01-12 at 22 21 59

@QichenZhu
Copy link
Contributor

QichenZhu commented Jan 12, 2026

@rayane-d, could you number each action (including verifications) so it's easier to refer to a specific one? Currently there are only 3 numbered steps but the test actually contains 105 actions.

@QichenZhu
Copy link
Contributor

QichenZhu commented Jan 12, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Test Steps 1

Test Steps 1.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set receipt required amount to "$100.00"
android-native-1
The LHN sidebar preview shows the correct changelog message text
android-native-2
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-3
Change app language, and verify that the changelog message is translated as expected
android-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-5
Test Steps 1.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed receipt required amount to "$200.00" (previously "$100.00")
android-native-6
The LHN sidebar preview shows the correct changelog message text
android-native-7
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-8
Change app language, and verify that the changelog message is translated as expected
android-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-10
Test Steps 1.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed receipt required amount (previously "$200.00")
android-native-11
The LHN sidebar preview shows the correct changelog message text
android-native-12
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-13
Change app language, and verify that the changelog message is translated as expected
android-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-15

Test Steps 2

Test Steps 2.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense amount to "$100.00"
android-native-16
The LHN sidebar preview shows the correct changelog message text
android-native-17
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-18
Change app language, and verify that the changelog message is translated as expected
android-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-20
Test Steps 2.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense amount to "$200.00" (previously "$100.00")
android-native-21
The LHN sidebar preview shows the correct changelog message text
android-native-22
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-23
Change app language, and verify that the changelog message is translated as expected
android-native-24
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-25
Test Steps 2.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense amount (previously "$200.00")
android-native-26
The LHN sidebar preview shows the correct changelog message text
android-native-27
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-28
Change app language, and verify that the changelog message is translated as expected
android-native-29
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-30

Test Steps 3

Test Steps 3.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense age to "15" days
android-native-31
The LHN sidebar preview shows the correct changelog message text
android-native-32
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-33
Change app language, and verify that the changelog message is translated as expected
android-native-34
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-35
Test Steps 3.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense age to "30" days (previously "15")
android-native-36
The LHN sidebar preview shows the correct changelog message text
android-native-37
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native-38
Change app language, and verify that the changelog message is translated as expected
android-native-39
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native-40
Test Steps 3.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense age (previously "30" days)
android-native41
The LHN sidebar preview shows the correct changelog message text
android-native42
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-native43
Change app language, and verify that the changelog message is translated as expected
android-native44
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-native45
Android: mWeb Chrome

Test Steps 1

Test Steps 1.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set receipt required amount to "$100.00"
android-web-1
The LHN sidebar preview shows the correct changelog message text
android-web-2
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-3
Change app language, and verify that the changelog message is translated as expected
android-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-5
Test Steps 1.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed receipt required amount to "$200.00" (previously "$100.00")
android-web-6
The LHN sidebar preview shows the correct changelog message text
android-web-7
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-8
Change app language, and verify that the changelog message is translated as expected
android-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-10
Test Steps 1.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed receipt required amount (previously "$200.00")
android-web-11
The LHN sidebar preview shows the correct changelog message text
android-web-12
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-13
Change app language, and verify that the changelog message is translated as expected
android-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-15

Test Steps 2

Test Steps 2.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense amount to "$100.00"
android-web-16
The LHN sidebar preview shows the correct changelog message text
android-web-17
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-18
Change app language, and verify that the changelog message is translated as expected
android-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-20
Test Steps 2.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense amount to "$200.00" (previously "$100.00")
android-web-21
The LHN sidebar preview shows the correct changelog message text
android-web-22
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-23
Change app language, and verify that the changelog message is translated as expected
android-web-24
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-25
Test Steps 2.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense amount (previously "$200.00")
android-web-26
The LHN sidebar preview shows the correct changelog message text
android-web-27
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-28
Change app language, and verify that the changelog message is translated as expected
android-web-29
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-30

Test Steps 3

Test Steps 3.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense age to "15" days
android-web-31
The LHN sidebar preview shows the correct changelog message text
android-web-32
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-33
Change app language, and verify that the changelog message is translated as expected
android-web-34
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-35
Test Steps 3.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense age to "30" days (previously "15")
android-web-36
The LHN sidebar preview shows the correct changelog message text
android-web-37
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-38
Change app language, and verify that the changelog message is translated as expected
android-web-39
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-40
Test Steps 3.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense age (previously "30" days)
android-web-41
The LHN sidebar preview shows the correct changelog message text
android-web-42
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
android-web-43
Change app language, and verify that the changelog message is translated as expected
android-web-44
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
android-web-45
iOS: HybridApp

Test Steps 1

Test Steps 1.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set receipt required amount to "$100.00"
ios-native-1
The LHN sidebar preview shows the correct changelog message text
ios-native-2
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-3
Change app language, and verify that the changelog message is translated as expected
ios-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-5
Test Steps 1.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed receipt required amount to "$200.00" (previously "$100.00")
ios-native-6
The LHN sidebar preview shows the correct changelog message text
ios-native-7
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-8
Change app language, and verify that the changelog message is translated as expected
ios-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-10
Test Steps 1.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed receipt required amount (previously "$200.00")
ios-native-11
The LHN sidebar preview shows the correct changelog message text
ios-native-12
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-13
Change app language, and verify that the changelog message is translated as expected
ios-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-15

Test Steps 2

Test Steps 2.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense amount to "$100.00"
ios-native-16
The LHN sidebar preview shows the correct changelog message text
ios-native-17
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-18
Change app language, and verify that the changelog message is translated as expected
ios-native-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-20
Test Steps 2.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense amount to "$200.00" (previously "$100.00")
ios-native-21
The LHN sidebar preview shows the correct changelog message text
ios-native-22
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-23
Change app language, and verify that the changelog message is translated as expected
ios-native-24
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-25
Test Steps 2.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense amount (previously "$200.00")
ios-native-26
The LHN sidebar preview shows the correct changelog message text
ios-native-27
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-28
Change app language, and verify that the changelog message is translated as expected
ios-native-29
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-30

Test Steps 3

Test Steps 3.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense age to "15" days
ios-native-31
The LHN sidebar preview shows the correct changelog message text
ios-native-32
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-33
Change app language, and verify that the changelog message is translated as expected
ios-native-34
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-35
Test Steps 3.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense age to "30" days (previously "15")
ios-native-36
The LHN sidebar preview shows the correct changelog message text
ios-native-37
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native-38
Change app language, and verify that the changelog message is translated as expected
ios-native-39
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native-40
Test Steps 3.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense age (previously "30" days)
ios-native41
The LHN sidebar preview shows the correct changelog message text
ios-native42
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-native43
Change app language, and verify that the changelog message is translated as expected
ios-native44
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-native45
iOS: mWeb Safari

Test Steps 1

Test Steps 1.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set receipt required amount to "$100.00"
ios-web-1
The LHN sidebar preview shows the correct changelog message text
ios-web-2
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-3
Change app language, and verify that the changelog message is translated as expected
ios-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-5
Test Steps 1.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed receipt required amount to "$200.00" (previously "$100.00")
ios-web-6
The LHN sidebar preview shows the correct changelog message text
ios-web-7
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-8
Change app language, and verify that the changelog message is translated as expected
ios-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-10
Test Steps 1.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed receipt required amount (previously "$200.00")
ios-web-11
The LHN sidebar preview shows the correct changelog message text
ios-web-12
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-13
Change app language, and verify that the changelog message is translated as expected
ios-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-15

Test Steps 2

Test Steps 2.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense amount to "$100.00"
ios-web-16
The LHN sidebar preview shows the correct changelog message text
ios-web-17
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-18
Change app language, and verify that the changelog message is translated as expected
ios-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-20
Test Steps 2.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense amount to "$200.00" (previously "$100.00")
ios-web-21
The LHN sidebar preview shows the correct changelog message text
ios-web-22
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-23
Change app language, and verify that the changelog message is translated as expected
ios-web-24
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-25
Test Steps 2.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense amount (previously "$200.00")
ios-web-26
The LHN sidebar preview shows the correct changelog message text
ios-web-27
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-28
Change app language, and verify that the changelog message is translated as expected
ios-web-29
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-30

Test Steps 3

Test Steps 3.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense age to "15" days
ios-web-31
The LHN sidebar preview shows the correct changelog message text
ios-web-32
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-33
Change app language, and verify that the changelog message is translated as expected
ios-web-34
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-35
Test Steps 3.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense age to "30" days (previously "15")
ios-web-36
The LHN sidebar preview shows the correct changelog message text
ios-web-37
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-38
Change app language, and verify that the changelog message is translated as expected
ios-web-39
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-40
Test Steps 3.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense age (previously "30" days)
ios-web-41
The LHN sidebar preview shows the correct changelog message text
ios-web-42
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
ios-web-43
Change app language, and verify that the changelog message is translated as expected
ios-web-44
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
ios-web-45
MacOS: Chrome / Safari

Test Steps 1

Test Steps 1.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set receipt required amount to "$100.00"
mac-web-1
The LHN sidebar preview shows the correct changelog message text
mac-web-2
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-3
Change app language, and verify that the changelog message is translated as expected
mac-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-5
Test Steps 1.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed receipt required amount to "$200.00" (previously "$100.00")
mac-web-6
The LHN sidebar preview shows the correct changelog message text
mac-web-7
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-8
Change app language, and verify that the changelog message is translated as expected
mac-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-10
Test Steps 1.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed receipt required amount (previously "$200.00")
mac-web-11
The LHN sidebar preview shows the correct changelog message text
mac-web-12
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-13
Change app language, and verify that the changelog message is translated as expected
mac-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-15

Test Steps 2

Test Steps 2.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense amount to "$100.00"
mac-web-16
The LHN sidebar preview shows the correct changelog message text
mac-web-17
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-18
Change app language, and verify that the changelog message is translated as expected
mac-web-4-9-14-19
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-20
Test Steps 2.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense amount to "$200.00" (previously "$100.00")
mac-web-21
The LHN sidebar preview shows the correct changelog message text
mac-web-22
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-23
Change app language, and verify that the changelog message is translated as expected
mac-web-24
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-25
Test Steps 2.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense amount (previously "$200.00")
mac-web-26
The LHN sidebar preview shows the correct changelog message text
mac-web-27
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-28
Change app language, and verify that the changelog message is translated as expected
mac-web-29
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-30

Test Steps 3

Test Steps 3.1
A changelog entry appears in the system messages thread in the #admins room
Message format: set max expense age to "15" days
mac-web-31
The LHN sidebar preview shows the correct changelog message text
mac-web-32
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-33
Change app language, and verify that the changelog message is translated as expected
mac-web-34
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-35
Test Steps 3.2
A changelog entry appears in the system messages thread in the #admins room
Message format: changed max expense age to "30" days (previously "15")
mac-web-36
The LHN sidebar preview shows the correct changelog message text
mac-web-37
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-38
Change app language, and verify that the changelog message is translated as expected
mac-web-39
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-40
Test Steps 3.3
A changelog entry appears in the system messages thread in the #admins room
Message format: removed max expense age (previously "30" days)
mac-web-41
The LHN sidebar preview shows the correct changelog message text
mac-web-42
Right-click on the changelog entry, copy the message, and verify that the copied text matches the displayed message exactly
mac-web-43
Change app language, and verify that the changelog message is translated as expected
mac-web-44
Create a thread under the changelog comment, and verify that the thread report title displays the changelog message correctly
mac-web-45

Comment on lines 6089 to 6099
setReceiptRequiredAmount: ({newValue}) => `estableció el monto requerido de recibo en "${newValue}"`,
changedReceiptRequiredAmount: ({oldValue, newValue}) => `cambió el monto requerido de recibo a "${newValue}" (anteriormente "${oldValue}")`,
removedReceiptRequiredAmount: ({oldValue}) => `eliminó el monto requerido de recibo (anteriormente "${oldValue}")`,

setMaxExpenseAmount: ({newValue}) => `estableció el monto máximo de gasto en "${newValue}"`,
changedMaxExpenseAmount: ({oldValue, newValue}) => `cambió el monto máximo de gasto a "${newValue}" (anteriormente "${oldValue}")`,
removedMaxExpenseAmount: ({oldValue}) => `eliminó el monto máximo de gasto (anteriormente "${oldValue}")`,

setMaxExpenseAge: ({newValue}) => `estableció la antigüedad máxima del gasto en "${newValue}" días`,
changedMaxExpenseAge: ({oldValue, newValue}) => `cambió la antigüedad máxima del gasto a "${newValue}" días (anteriormente "${oldValue}")`,
removedMaxExpenseAge: ({oldValue}) => `eliminó la antigüedad máxima del gasto (anteriormente "${oldValue}" días)`,
Copy link
Contributor Author

@rayane-d rayane-d Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayane-d
Copy link
Contributor Author

Bug: the header doesn't show the same message 'set max expense amount to "$100"' after replying in thread in Android and iOS HybridApps.

Also, the message is not translated.

I've fixed these issues: facd9cd

@rayane-d
Copy link
Contributor Author

@rayane-d, could you number each action (including verifications) so it's easier to refer to a specific one? Currently there are only 3 numbered steps but the test actually contains 105 actions.

Done

@rayane-d rayane-d changed the title [Hold Spanish translation confirmation] [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age [Policy Change Logs] Fix: Rules - Unexpected defaults for max expense amount, receipt required amount, and max expense age Jan 14, 2026
@melvin-bot
Copy link

melvin-bot bot commented Jan 15, 2026

🎯 @QichenZhu, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #79674.

@inimaga inimaga merged commit d396d08 into Expensify:main Jan 15, 2026
29 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@rayane-d rayane-d deleted the policy-changelog-unexpected-defaults branch January 15, 2026 15:53
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.3-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mitarachim
Copy link

@rayane-d This PR is failing because of a regression issue Changelog messages about Rules are not translated to Italian, Polski, Portuguese, etc

The issue is reproducible in: Web, Android, iOS

Bug7050417_1768504190906.Not_translated.mp4

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants