Expense - Pay button is still shown in dropdown menu after paying full amount

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.11-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78426
Email or phone of affected tester (no customers): applausetester+sdjois2jd33@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Approvals are disabled in Workflows settings.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two expenses.
4. Open the expense report.
5. Open any expense.
6. Click More > Hold.
7. Enter reason and save it.
8. Close the transaction thread.
9. Click Submit.
10. Select both expenses via checkbox.
11. Click dropdown button > Pay > Mark as paid.
12. Select the full amount.
13. Click dropdown button > Pay > Mark as paid.

Expected Result:

After paying the full amount, Pay button should be removed from the dropdown menu.

Actual Result:

After paying the full amount, Pay button still persists in the dropdown menu.
When paying for the second time, error shows up.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #78426

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #78426 - "Show Submit/Approve/Pay actions for selected transactions when all expenses are selected" by @cosmicvulpes (High confidence)
Related Issues: None identified

Recommendation: ROLL FORWARD

The root cause is a race condition where the Pay button visibility is determined before the report state updates after payment. A revert would remove the new bulk action feature entirely, which provides significant UX value. The fix is relatively straightforward - the action visibility check needs to properly account for the optimistic payment state.

Labels: Keeping DeployBlockerCash (frontend bug requiring App fix). No label changes needed.

📋 Detailed Analysis

Evidence

PR #78426 added the ability to show report-level actions (Submit/Approve/Pay) in the selected transactions dropdown when all expenses are selected. The bug was reported immediately after this feature was deployed to staging (version 9.3.11-1), and the issue explicitly states "N/A - new feature, doesn't exist in prod".

The PR modified:

• src/components/MoneyReportHeader.tsx - Added applicableTransactionActions logic
• src/components/MoneyReportHeaderKYCDropdown.tsx - Added support for selection mode
• Multiple payment-related components to handle the new flow

Verification

The affected component is MoneyReportHeader.tsx which computes applicableTransactionActions based on primaryAction and secondaryActions. PR #78426 directly modified this file, adding the logic at lines 1580-1596 that determines which report-level actions to show in the selection dropdown.

Root Cause

The applicableTransactionActions memo (lines 1580-1596 in MoneyReportHeader.tsx) determines whether to show the PAY action based on the current report state via isPrimaryPayAction(), which checks if reimbursableSpend !== 0.

The race condition occurs in this flow:

1. User selects all expenses and clicks Pay → Mark as paid
2. confirmPayment() is called with isSelectedTransactionAction: true
3. Payment is processed via payMoneyRequest() (asynchronous API call)
4. clearSelectedTransactions(true) is called immediately (line 575)
5. User re-selects the expenses
6. applicableTransactionActions is recalculated, but the report hasn't updated yet from the API
7. isPrimaryPayAction() still returns true because reimbursableSpend hasn't been updated to 0
8. PAY button incorrectly appears in the dropdown

The issue is that selections are cleared synchronously, but the report state update is asynchronous. When the user quickly re-selects transactions before the payment API completes, the dropdown is built with stale data.

The fix should either:

• Add optimistic report updates before clearing selections
• Disable the Pay action when a payment is pending
• Ensure report state updates before allowing re-selection