Show Submit/Approve/Pay actions for selected transactions when all expenses are selected #78426

cosmicvulpes · 2025-12-24T11:48:19Z

Explanation of Change

This PR adds support for displaying report-level actions (Submit, Approve, Pay) in the selected transactions dropdown when all expenses in a report are selected. This allows users to perform bulk report actions directly from the expense selection UI.

Key Changes

Report-level actions in selected transactions dropdown: When all expenses in a report are selected, the dropdown now shows report-level actions (Submit, Approve, Pay) alongside transaction-level actions (Hold, Move, Delete, etc.)
useSelectedTransactionsActions hook enhancement: Added reportLevelActions parameter to inject report-level actions into the dropdown options
MoneyReportHeader integration: Passes applicable report actions (from applicableTransactionActions) to the selected transactions dropdown via useSelectedTransactionsActions
Payment callback refactor: Refactored SettlementButton.onPress to use object params (PaymentActionParams) to support the skipAnimation parameter needed when triggering payments from the selected transactions dropdown

Fixed Issues

$ #72502
PROPOSAL: #72502 (comment)

Tests

Note: This change is not applicable to mobile views.

Create and open an expense report with multiple expenses
Select all expenses using the checkbox
Verify that Submit/Approve/Pay actions appear at the top of the selection dropdown (depending on report state)
Click the Submit action (if available) and verify the report is submitted and selections are cleared
Select all expenses again
Click the Approve action (if available) and verify the report is approved and selections are cleared
Select all expenses again
Click the Pay action and verify a submenu opens with payment options (Pay as business, Mark as paid, etc.)
Select a payment option and verify the payment is processed and selections are cleared
Verify nested payment options work correctly for invoice reports with bank account selection

Verify that no errors appear in the JS console

Offline tests

Go offline
Select all expenses on a report
Verify report-level actions (Submit/Approve/Pay) are shown in the dropdown
Click Submit/Approve and verify appropriate offline behavior
Click Pay and verify payment options are shown and verify appropriate offline behavior

QA Steps

Same as tests

Note: This change is not applicable to mobile views.

PR Author Checklist

Screenshots/Videos

Android: Native

(No changes)

untitled.mp4

Android: mWeb Chrome

(No changes)

untitled1.mp4

iOS: Native

(No changes)

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-12-31.at.16.42.36.mp4

iOS: mWeb Safari

(No changes)

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-12-31.at.16.58.23.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-17.at.10.22.03.PM.mp4

…ons to selected transactions

- Fix type import in useSelectedTransactionsActions.ts (use 'import type') - Remove unused KYCPaymentMethod import in PaymentUtils.ts - Add ValueOf import and type assertion in ActionCell.tsx for PaymentData compatibility - Update SettlementButton to use object params for all onPress calls

melvin-bot · 2025-12-24T11:48:27Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/MoneyReportHeader.tsx

codecov · 2025-12-24T11:56:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useSelectedTransactionsActions.ts	`85.55% <100.00%> (+0.49%)`	⬆️
src/libs/PaymentUtils.ts	`27.05% <0.00%> (ø)`
...ts/SelectionListWithSections/Search/ActionCell.tsx	`56.00% <33.33%> (+1.09%)`	⬆️
src/components/MoneyRequestConfirmationList.tsx	`57.48% <40.00%> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`60.72% <0.00%> (ø)`
src/hooks/usePaymentOptions.ts	`0.00% <0.00%> (ø)`
src/pages/iou/MoneyRequestAmountForm.tsx	`3.06% <0.00%> (ø)`
src/components/MoneyReportHeaderKYCDropdown.tsx	`0.00% <0.00%> (ø)`
src/components/SettlementButton/index.tsx	`0.00% <0.00%> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

situchan · 2025-12-30T15:15:35Z

Please fix conflict

…t-header

cosmicvulpes · 2025-12-31T11:07:21Z

@situchan Resolved the conflicts, please take a look. Thanks!

cosmicvulpes · 2025-12-31T12:27:18Z

@situchan This is the first PR that needs to be merged to enable the Submit / Approve / Pay buttons on the web and desktop apps.

In the second PR, we’ll merge the refactored code to enable the same functionality for mobile selection mode as well.

I’m done with my part for this first PR.

cosmicvulpes · 2026-01-05T08:41:22Z

Friendly bump @situchan. Please review the changes once. I'll resolve the conflicts once you are done as there are frequent changes in files changed.

situchan · 2026-01-05T12:32:42Z

Please fix conflict. Started reviewing

situchan · 2026-01-27T16:09:02Z

Lint still failing

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9458c868f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/MoneyReportHeader.tsx

…ect-actions-money-report-header

cosmicvulpes · 2026-01-28T05:42:01Z

@situchan I was some intermittent issues with CI. All good now.

…ect-actions-money-report-header

cosmicvulpes · 2026-01-28T15:03:20Z

gentle bump @situchan

src/components/MoneyReportHeaderKYCDropdown.tsx

src/components/MoneyReportHeader.tsx

chatgpt-codex-connector

💡 Codex Review

App/src/components/MoneyReportHeader.tsx

Lines 523 to 526 in f464316

    
           } else if (isAnyTransactionOnHold) { 
        
               if (getPlatform() === CONST.PLATFORM.IOS) { 
        
                   // eslint-disable-next-line @typescript-eslint/no-deprecated 
        
                   InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true));

Clear selections after hold-menu payments in selection mode

When all transactions are selected and the report has any held expenses, the payment flow goes through the hold menu path here. In that path you only open the hold menu, and the actual payment is executed later by ProcessMoneyReportHoldMenu, which does not clear selected transactions. As a result, bulk Pay from the selection dropdown leaves the selections active even after the user confirms the hold-menu action, unlike the non-hold branches where clearSelectedTransactions(true) runs. This is user-visible in reports with held expenses: the selection UI persists after paying/approving, and repeated actions can be triggered unintentionally.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-01-28T15:51:10Z

Please update Tests so that QA team knows this is web only. not mobile

cosmicvulpes · 2026-01-28T16:41:50Z

@puneetlath can we merge this?

github-actions · 2026-01-28T18:39:49Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

puneetlath · 2026-01-28T18:40:17Z

Let me give it a quick spin on ad-hoc and if all good I'll merge. Thanks!

github-actions · 2026-01-28T18:44:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #78426.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6a49844-55e8d0ca67d9778ee857549ccd609ba96d807449/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6a49844-bc2d65e67e311d963c66fff235bc5efcdd1d94bd/index.html

Web 🕸️
https://78426.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

puneetlath · 2026-01-28T18:49:33Z

Let's add the retract action in a follow-up PR. I noticed that we don't support that one when selecting all while testing. Otherwise, seems to work well!

situchan · 2026-01-28T18:58:05Z

Let's add the retract action in a follow-up PR. I noticed that we don't support that one when selecting all while testing. Otherwise, seems to work well!

yes, this PR is only supporting Submit/Approve/Pay.

Should we support unapprove/cancel payment as well?

puneetlath · 2026-01-28T19:01:06Z

Ah yes, I think we should. Basically all the report-level actions should work when selecting all. @cosmicvulpes you down to raise a follow-up PR for those?

OSBotify · 2026-01-28T23:20:52Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.11-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

cosmicvulpes added 2 commits December 24, 2025 16:27

refactor: use object params for payment callbacks and add report acti…

10c6598

…ons to selected transactions

cosmicvulpes requested review from a team as code owners December 24, 2025 11:48

melvin-bot bot assigned cosmicvulpes Dec 24, 2025

melvin-bot bot requested review from flaviadefaria, heyjennahay and situchan and removed request for a team December 24, 2025 11:48

melvin-bot bot requested review from JmillsExpensify, joekaufmanexpensify and trjExpensify and removed request for a team December 24, 2025 11:48

github-actions bot reviewed Dec 24, 2025

View reviewed changes

src/components/MoneyReportHeader.tsx Show resolved Hide resolved

github-actions bot reviewed Dec 24, 2025

View reviewed changes

src/components/MoneyReportHeader.tsx Show resolved Hide resolved

fix: resolve paymentType shadowing in MoneyRequestReportPreviewContent

86137ec

Merge branch 'main' into feat/all-expenses-select-actions-money-repor…

1bdaa72

…t-header

cosmicvulpes added 3 commits December 31, 2025 17:42

prettier and lint fixes

c9d1daf

More lint fixes

715fcd0

revert unwanted change

9fd20e4

trjExpensify removed request for JmillsExpensify, flaviadefaria and heyjennahay January 5, 2026 16:49

fix prettier diff

a9458c8

chatgpt-codex-connector bot reviewed Jan 27, 2026

View reviewed changes

src/components/MoneyReportHeader.tsx Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into feat/all-expenses-sel…

0538ed8

…ect-actions-money-report-header

Merge remote-tracking branch 'origin/main' into feat/all-expenses-sel…

f464316

…ect-actions-money-report-header

situchan reviewed Jan 28, 2026

View reviewed changes

src/components/MoneyReportHeaderKYCDropdown.tsx Outdated Show resolved Hide resolved

situchan reviewed Jan 28, 2026

View reviewed changes

src/components/MoneyReportHeaderKYCDropdown.tsx Show resolved Hide resolved

rename the new component prop to shouldShowSuccessStyle

96424f1

situchan reviewed Jan 28, 2026

View reviewed changes

src/components/MoneyReportHeader.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

situchan approved these changes Jan 28, 2026

View reviewed changes

puneetlath approved these changes Jan 28, 2026

View reviewed changes

puneetlath merged commit 1e55191 into Expensify:main Jan 28, 2026
32 checks passed

OSBotify mentioned this pull request Jan 28, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Open

This was referenced Jan 29, 2026

Expense - "Business bank account" is hidden in "Pay with personal account" #80840

Open

Expenses - Pay options are not disabled when foreign currency expenses are created offline #80842

Closed

This was referenced Jan 29, 2026

Expense - Pay button is still shown in dropdown menu after paying full amount #80859

Closed

Expense - "You're all set!" RHP opens when bulk paying expenses as business #80868

Closed

situchan mentioned this pull request Jan 29, 2026

Revert "Show Submit/Approve/Pay actions for selected transactions when all expenses are selected" #80871

Merged

	} else if (isAnyTransactionOnHold) {
	if (getPlatform() === CONST.PLATFORM.IOS) {
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true));

Show Submit/Approve/Pay actions for selected transactions when all expenses are selected #78426

Show Submit/Approve/Pay actions for selected transactions when all expenses are selected #78426

Conversation

cosmicvulpes commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Key Changes

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 24, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan commented Dec 30, 2025

Uh oh!

cosmicvulpes commented Dec 31, 2025

Uh oh!

cosmicvulpes commented Dec 31, 2025

Uh oh!

cosmicvulpes commented Jan 5, 2026

Uh oh!

situchan commented Jan 5, 2026

Uh oh!

situchan commented Jan 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cosmicvulpes commented Jan 28, 2026

Uh oh!

cosmicvulpes commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

situchan commented Jan 28, 2026

Uh oh!

cosmicvulpes commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

puneetlath commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

puneetlath commented Jan 28, 2026

Uh oh!

Uh oh!

situchan commented Jan 28, 2026

Uh oh!

puneetlath commented Jan 28, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cosmicvulpes commented Dec 24, 2025 •

edited

Loading

codecov bot commented Dec 24, 2025 •

edited by github-actions bot

Loading