Expense - "You're all set!" RHP opens when bulk paying expenses as business

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.11-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78426
Email or phone of affected tester (no customers): sidnjosdnjdosijsojns@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace is set up with bank account.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two expenses.
4. Open the expense report.
5. Click Submit and Approver.
6. Select both expenses via checkbox.
7. Click dropdown button > Pay > Pay as a business.

Expected Result:

The expenses will be paid as business without issue.

Actual Result:

"You're all set!" RHP opens. The expenses cannot be paid as business when bulk selected.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #78426

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #78426 - "Show Submit/Approve/Pay actions for selected transactions when all expenses are selected" by @cosmicvulpes (High confidence)
Related Issues: None

Recommendation: REVERT

PR #78426 introduces bulk payment functionality but has a bug where clicking "Pay as business" from the bulk selection dropdown opens the "You're all set!" RHP instead of actually processing the payment. This breaks a core payment flow and should be reverted.

Labels: Keeping DeployBlockerCash (App PR caused the issue)

Detailed Analysis

Evidence

• The issue explicitly states this is reproducible with the new bulk payment feature introduced in PR Show Submit/Approve/Pay actions for selected transactions when all expenses are selected #78426
• melvin-bot automatically assigned the PR author, confirming this PR is suspected
• The bug report states the feature "doesn't exist in prod" - this is a new feature from Show Submit/Approve/Pay actions for selected transactions when all expenses are selected #78426
• Regression testing link in the bug points directly to PR Show Submit/Approve/Pay actions for selected transactions when all expenses are selected #78426

Verification

PR #78426 modifies the following files related to bulk payment flow:

• src/components/MoneyReportHeader.tsx - Adds selectionModePaymentOptions and isSelectedTransactionAction flag
• src/hooks/usePaymentOptions.ts - Creates payment options with the new flag
• src/hooks/useSelectedTransactionsActions.ts - Integrates report-level actions into bulk selection dropdown
• src/components/SettlementButton/index.tsx - Refactored to accept PaymentActionParams object

Root Cause

The PR adds support for bulk report actions (Submit, Approve, Pay) when all expenses in a report are selected. The payment flow includes an isSelectedTransactionAction flag to differentiate bulk payments from regular payments.

The bug occurs when:

1. User selects all expenses via checkbox
2. Clicks dropdown > Pay > Pay as business
3. Instead of processing the payment, the "You're all set!" RHP opens (which is typically shown after bank account setup completion)
4. The payment is not actually processed

This suggests the payment flow is incorrectly routing to a bank account setup completion page rather than executing the payment action. The isSelectedTransactionAction flag and related payment flow logic in the PR contains a bug that breaks the payment processing for bulk-selected expenses.