Spend - Offline indicator is missing in Filters

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90029
Email or phone of affected tester (no customers): jodijojosjojso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.5
App Component: Search

Action Performed:

1. Launch Expensify app.
2. Go to Spend > Expenses.
3. Go offline.
4. Tap Filters.

Expected Result:

Offline indicator will be shown at the bottom.

Actual Result:

Offline indicator is not shown in Filters.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7163054_1779753303123.7.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7163054

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/efa50b9ec542022255b3311af045bd11e081eb7cbb0cbb384ff45c19c9cc33b7

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #90029

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

PR #90029 introduced AdvancedFiltersFullscreen for the filters view on narrow screens (iOS/Android). This component wraps its content in ScreenWrapperContainer instead of ScreenWrapper.

ScreenWrapperContainer is a lower-level layout component that handles safe area padding and keyboard avoidance, but does not render ScreenWrapperOfflineIndicators. The offline indicator is only rendered by the full ScreenWrapper component. By bypassing ScreenWrapper, the fullscreen filters never show the offline indicator.

What changes do you think we should make in order to solve the problem?

Replace ScreenWrapperContainer with ScreenWrapper in AdvancedFiltersFullscreen.tsx. This will restore the offline indicator while preserving the existing layout behavior, since ScreenWrapper wraps ScreenWrapperContainer internally.

If switching to ScreenWrapper causes issues in the modal context (e.g., duplicate navigation listeners), the alternative is to manually add an OfflineIndicator component at the bottom of AdvancedFiltersFullscreen's render tree.

What alternative solutions did you explore? (Optional)

Manually rendering OfflineIndicator inside AdvancedFiltersFullscreen — this would work but is less maintainable since it duplicates logic already handled by ScreenWrapper.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.