Update advanced filters button to open filters popover#90029
Conversation
melvin-bot
Bot
requested review from
aimane-chnaif and
joekaufmanexpensify
and removed request for
a team
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Since we use popover, for small screens, I use a full-screen modal, which means it won't have the same navigation behavior as navigation screens. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (!value?.length) { | ||
| return label; | ||
| } | ||
|
|
There was a problem hiding this comment.
❌ CONSISTENCY-5 (docs)
The eslint-disable-next-line react/jsx-props-no-spreading comment lacks a justification explaining why the rule is being disabled.
Add a comment explaining the reason, for example:
// We need to spread the remaining props (PopoverComponent, wrapperStyle, etc.) to FilterPopupButton
// eslint-disable-next-line react/jsx-props-no-spreading
{...props}Reviewed at: c9f0ff0 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| const {clientX, clientY} = event; | ||
| const speed = getCursorSpeed(clientX, clientY); | ||
|
|
||
| if (!submenuRef.current) { |
There was a problem hiding this comment.
❌ CONSISTENCY-2 (docs)
0.1 is a magic number representing a cursor speed threshold (in px/ms). Its meaning and rationale are not immediately clear.
Extract it to a named constant:
/** Cursor speed threshold (px/ms) below which the safe triangle apex is updated */
const SLOW_CURSOR_SPEED_THRESHOLD = 0.1;
// usage
if (speed === null || speed < SLOW_CURSOR_SPEED_THRESHOLD) {Reviewed at: c9f0ff0 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e871e30620
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Deploy Blocker #91665 was identified to be related to this PR. |
|
Deploy Blocker #91666 was identified to be related to this PR. |
|
Deploy Blocker #91668 was identified to be related to this PR. |
|
Deploy Blocker #91669 was identified to be related to this PR. |
|
Deploy Blocker #91670 was identified to be related to this PR. |
|
Deploy Blocker #91671 was identified to be related to this PR. |
|
Deploy Blocker #91673 was identified to be related to this PR. |
|
Deploy Blocker #91678 was identified to be related to this PR. |
|
Deploy Blocker #91680 was identified to be related to this PR. |
|
Deploy Blocker #91682 was identified to be related to this PR. |
|
Deploy Blocker #91686 was identified to be related to this PR. |
|
Deploy Blocker #91690 was identified to be related to this PR. |
|
Deploy Blocker #91693 was identified to be related to this PR. |
14 participants
Explanation of Change
Fixed Issues
$ #84877
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisite: have a workspace with report fields
Web
mWeb, Android, iOS
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4