[Exploratory] Expense - In expense rule, tax row don't show custom name but tag row shows.

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.4.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-40473/folder/13176707/88211668/1471640802
Email or phone of affected tester (no customers): dreamnitethedragon+dcguiu@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workspace settings
3. Tap more features - Enable tags
4. Tap tags - Add a tag
5. Tap settings & set a custom tag name
6. Tap more features - Enable taxes
7. Tap taxes - settings - set a custom tax name
8. Tap account - expense rule
9. Tap new rule
10. Note tag and tax row

Expected Result:

In expense rule, tag and tax row must show consistent behaviour in showing custom name.

Actual Result:

In expense rule, tax row don't show custom name but tag row shows.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7175656_1780986240279.Screenrecorder-2026-06-09-11-46-54-202.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7175656

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7496cd11b3c949c2c3e26faa931c8127b1ec6356ad8d07f22647693a51e1e86f

[trasnake87]

Proposal

What is the root cause

Both rule-page base components use translate('common.tax') as the row label (description) for the tax field, ignoring the custom tax field name the workspace admin may have set. The discrepancy is visible when comparing how tag rows and the tax row build their description:

Tag rows (src/pages/settings/Rules/RulePageBase.tsx:180–187 and MerchantRulePageBase.tsx:333–338):

description: name   // policyTags[i].name — the custom tag-list name, e.g. "Department"

Tax row (both files — RulePageBase.tsx:192, MerchantRulePageBase.tsx:346):

description: translate('common.tax')   // always "Tax", ignores custom name

Workspaces can rename the tax field (e.g. "VAT", "GST") via Settings → Workspace → Taxes; the custom name is stored in policy.taxRates.name (TaxRatesWithDefault.name, src/types/onyx/Policy.ts:260). This is exactly what src/pages/workspace/taxes/WorkspaceTaxesSettingsPage.tsx:34 and WorkspaceTaxesSettingsCustomTaxName.tsx read and write. The tag rows already follow this pattern — each tag list exposes its custom name through policyTags[i].name — but the tax row never reads its equivalent.

What changes should be made

src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx:346

policy is already subscribed via usePolicy(policyID) (line 98). No new Onyx subscription needed:

// Before
description: translate('common.tax'),

// After
description: policy?.taxRates?.name ?? translate('common.tax'),

src/pages/settings/Rules/RulePageBase.tsx:117–192

activePolicyID is already subscribed (line 117). Add one targeted selector to pull only the tax field name:

const [taxFieldName] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID}`, {
    selector: (policy) => policy?.taxRates?.name,
});

Then update the tax row (line 192):

// Before
description: translate('common.tax'),

// After
description: taxFieldName ?? translate('common.tax'),

The selector keeps the subscription minimal — only the single string is extracted rather than the entire policy object.

What alternatives were explored

• Modifying getAllTaxRatesNamesAndValues to also return the field-level name: this selector aggregates individual tax rates across all policies and would require a type change and caller updates; it conflates per-rate data with the field name, so it is the wrong layer.
• Treating it as a title (selected-value) bug: the title prop already displays the chosen rate's name and percentage (e.g. "Standard Rate (20%)"). The missing custom name is in the description (the row's persistent label), not the selected-value slot.

[ijmalik]

problem:

In the expense rule creation screen, when a workspace admin sets a custom name for the tax field (e.g. "VAT" or "GST"), the tax row still displays the generic "Tax" label. In contrast, tag rows correctly display their custom names. This inconsistency creates a confusing experience for users who have customized their workspace.

cause:

Both src/pages/settings/Rules/RulePageBase.tsx (line 192) and src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx (line 346) hardcode translate('common.tax') as the tax row description, completely ignoring policy.taxRates.name — the custom field name stored and managed by WorkspaceTaxesSettingsPage.tsx and WorkspaceTaxesSettingsCustomTaxName.tsx.

Tag rows already read their custom name directly from policyTags[i].name. The tax row simply never got the same treatment.

---

changes:

File 1 — src/pages/settings/Rules/RulePageBase.tsx

Add a dedicated selector right after the existing activePolicyID subscription to extract only the tax field name string, keeping the subscription minimal:

+ const [customTaxFieldName] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID}`, {
+     selector: (policy) => policy?.taxRates?.name,
+ });

Then update the tax row description:

- description: translate('common.tax'),
+ description: customTaxFieldName ?? translate('common.tax'),

File 2 — src/pages/workspace/rules/MerchantRules/MerchantRulePageBase.tsx

policy is already available via usePolicy(policyID) on line 98, so no new subscription is needed:

- description: translate('common.tax'),
+ description: policy?.taxRates?.name ?? translate('common.tax'),

These are the only two lines that need changing. No new utilities, no new Onyx keys, no API or action changes.

---

alternative:

• Adding a getTaxFieldName() utility in PolicyUtils.ts: Unnecessary abstraction for a two-file, one-liner fix. A utility makes sense only if multiple screens share this logic — currently they do not.
• Updating getAllTaxRatesNamesAndValues selector: This selector aggregates individual rate data across policies and is the wrong layer for a field-level label fix. It would require type changes and unrelated caller updates.
• Syncing tax.name with customName at the data layer: Risky — the backend may depend on the original name field. A read-only UI fallback is safer and sufficient.

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

12 days overdue. Walking. Toward. The. Light...