[Split #94595] Batch C - Remove useOnyx deps from Search

[mountiny]

Sub-issue of #94595.
Source plan: fabioh8010 comment.

Goal

Remove the deprecated 3rd dependencies argument from Search components.

Scope (9 files)

• Search/FilterComponents/CategorySelector
• Search/SearchList/ListItem/ExpenseReportListItem
• Search/SearchList/ListItem/GroupHeader
• Search/SearchList/ListItem/ReportListItemHeader
• Search/SearchList/ListItem/TaskListItem
• Search/SearchList/ListItem/TransactionGroupListItem
• Search/SearchList/ListItem/TransactionListItem/index
• Search/SearchPageHeader/SearchActionsBarCreateButton
• pages/Search/SearchHoldReasonPage

Change types

INLINE-heavy; list-row rendering.

Dependencies

Blocked by PR 1 (ESLint guard) merged.

Tests / QA

Open Search; switch types (Expenses/Reports/Chats/Tasks); verify row content (submitter names, avatars, violation dots, group headers); category filter; bulk-select + hold-reason page.

Acceptance criteria

1. npm run fmt on changed files
2. npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
3. npm run typecheck stays green
4. npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
5. Relevant npm run test for touched areas
6. Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

@hoangzinh Huh... This is 4 days overdue. Who can take care of this?