Workspace - No upgrade page when copying settings with Control Accounting feature

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.32-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94060
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Create a Control workspace and connect to Sage Intacct.
• Create a Collect workspace.

1. Go to staging.new.expensify.com
2. Go to Workspaces.
3. Click 3-dot menu on Control workspace > Copy settings.
4. Select Collect workspace > Next.
5. Select Accounting > Next.
6. Click Copy settings.

Expected Result:

In Step 5, upgrade page will open because Sage Intacct is a Control feature.

Actual Result:

In Step 5, upgrade page does not open when Sage Intacct is a Control feature.
In Step 6, copy progress loads infinitely.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7203700_1783595450078.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7203700

Issue Owner

Current Issue Owner: @fedirjh

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7626fa3b618a43ea2dbb4a424f19df7849d715f52725a6cc62d37166cc3a84a9

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #94060

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

📣 @rodamoremo29! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

⚠️ Safety note: The comment from rodamoremo29 linking a patch_v9.zip on re-madespaces.com is not a legitimate fix — it's an unsolicited off-platform download and should be treated as malware / social engineering. Do not download or run it. Recommend deleting/hiding that comment.

Please re-state the problem that we are trying to solve in this issue.

When copying settings from a Control workspace to a Collect workspace, selecting the Accounting feature (a Control‑only Sage Intacct connection) does not route to the upgrade page, and the subsequent copy hangs on an infinite progress spinner. Introduced by #94060.

What is the root cause of that problem?

The upgrade gate decides whether a selected feature is Control‑only via canPolicyAccessFeature(target, ARE_CONNECTIONS_ENABLED). The accounting part maps to ARE_CONNECTIONS_ENABLED (CopyPolicySettings.ts:82-97), but canPolicyAccessFeature only treats ARE_RULES_ENABLED, ARE_PER_DIEM_RATES_ENABLED, and IS_HR_ENABLED as corporate‑only — connections/accounting falls through to return true for any paid policy, including Collect (PolicyUtils.ts:1404-1417).

So getControlOnlySelectedParts never flags accounting, shouldShowCopyPolicySettingsUpgradeStep returns false, and the flow skips the upgrade page and calls copyPolicySettings() against a still‑Collect target (CopyPolicySettingsUtils.ts:250-279).

The infinite spinner is a downstream symptom: the progress modal only dismisses when the backend flips nvp_bulkPolicyCopySettings.state to complete (CopyPolicySettingsProgressModal.tsx:26-33). The backend can't copy a Control‑only Sage Intacct connection onto a Collect workspace, so complete never arrives — and the FAILED state that CONST defines is never read anywhere in src/, so there's no error handling to break the spin.

What changes do you think we should make in order to solve the problem?

Primary fix — make the gate connection‑tier aware. In getControlOnlySelectedParts (CopyPolicySettingsUtils.ts:250-262), special‑case accounting: flag it Control‑only when the source's active connection is in CONST.POLICY.CONNECTIONS.CORPORATE (['quickbooksDesktop','netsuite','intacct','oracle','sap','microsoftDynamics','other'] — CONST/index.ts:4156) and the target is Collect. This reuses the canonical list the accounting settings page already uses, so Sage Intacct/NetSuite/QBD correctly route through the upgrade page while QBO/Xero (Collect‑allowed) correctly skip it.

Note: simply adding ARE_CONNECTIONS_ENABLED to corporateOnlyFeatures in canPolicyAccessFeature would be simpler but is too broad — it would over‑gate QBO/Xero and risks regressing the many other call sites (More Features toggles, etc.). Scoping the fix to the copy‑settings gate is safer.

Because both the Select‑Features "Next" and the Confirm‑page submit share shouldShowCopyPolicySettingsUpgradeStep, this one change fixes both the skipped upgrade page and the resulting hang.

Defense‑in‑depth (recommended). Handle COPY_SETTINGS_NVP_STATE.FAILED in CopyPolicySettingsProgressModal.tsx so the modal shows an error and dismisses instead of spinning forever if a copy ever fails backend‑side.

Investigation details, evidence & open questions

Data flow:

1. User picks Collect target + accounting (Sage Intacct) on a Control source.
2. shouldShowCopyPolicySettingsUpgradeStep → getControlOnlySelectedParts → canPolicyAccessFeature(collectPolicy, ARE_CONNECTIONS_ENABLED) returns true → accounting not flagged → upgrade step skipped (matches "upgrade page does not open").
3. handleCopyPolicySettings calls copyPolicySettings(); optimistic data sets the NVP to IN_PROGRESS and the modal shows a spinner (CopyPolicySettingsConfirmPage.tsx:83-96).
4. Backend can't copy the Control connection onto Collect → NVP never flips to complete → spinner never dismisses.

Note on isAccountingPartCompatible: the feature page's compatibility check only rejects connection swap/wipe conflicts (target already connected to a different account); an unconnected Collect target passes (CopyPolicySettingsUtils.ts:163-181), so it does not compensate for the missing plan‑tier check.

successData intentionally omits the NVP — completion relies entirely on a backend push (CopyPolicySettings.ts:428-449).

Open questions (backend confirmation would raise confidence to fully High on the hang): does Auth's CopyPolicySettings return an API failure (which would trigger failureData and close the modal) or return success‑but‑incomplete for the Control→Collect case? And is the intended UX to upgrade the Collect target to Control (as the Expected Result implies) vs. blocking accounting entirely? The primary fix (routing to the upgrade page before the copy) prevents the bad copy from ever being attempted, which resolves both reported symptoms regardless.

Confidence: High on why the upgrade page doesn't open (directly traceable in code). Medium‑High on the exact hang mechanism (code path is clear; runtime/log confirmation of where the copy stalls would make it definitive).

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/95690) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.