Workspace - No back button on Upgrade success RHP when copying settings

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.32-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94060
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Create a Control workspace and enable Rules.
• Create a Collect workspace.

1. Go to staging.new.expensify.com
2. Go to Workspaces.
3. Click 3-dot menu on Control workspace > Copy settings.
4. Select Collect workspace > Next.
5. Select Rules > Next.
6. Click Copy settings.
7. Click Upgrade.

Expected Result:

Upgrade success RHP will have back button.

Actual Result:

Upgrade success RHP does not have back button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7203907_1783611553896.6.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7203907

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #94060

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/647a49458975379001fefbcb8b8191f449d921e5806f526b44d3b8453e626a23

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The Copy-settings Upgrade page intentionally hides the back button once the upgrade succeeds. In CopyPolicySettingsUpgradePage.tsx:119-123 the header is rendered with:

shouldShowBackButton={!showSuccess}

showSuccess becomes true after the bulk upgrade settles, so the back button disappears exactly on the success RHP. shouldShowBackButton defaults to true, so this expression is the only reason it's missing.

This is a regression introduced by Expensify/App#94060 (the new Upgrade page) and diverges from the established upgrade pattern: the standard WorkspaceUpgradePage.tsx:347-356 keeps the back button on its confirmation (isUpgraded) screen.

What changes do you think we should make in order to solve the problem?

Show the back button on the success view too, matching WorkspaceUpgradePage. In CopyPolicySettingsUpgradePage.tsx:119-123, remove the shouldShowBackButton={!showSuccess} prop so it falls back to its true default.

One decision to confirm during implementation: onBackButtonPress currently always routes to SELECT_FEATURES. That's reasonable for the intro state; for the success state you may prefer it to route forward to CONFIRM (the same place the "Continue" button goes), to avoid sending the user back to feature selection after the upgrade has already completed. The safe, minimal fix for the deploy blocker is just to restore the button; the destination can stay as-is.

Investigation details

• The new page gates the header on the success flag: shouldShowBackButton={!showSuccess}, where showSuccess = hasRequestedUpgrade && !isUpgradePending && policiesToUpgrade.length === 0 — true only on the post-upgrade success RHP, which is exactly the screen the tester reports has no back button.
• Comparison to the pre-existing standard flow (WorkspaceUpgradePage) shows the back button is always rendered, including when isUpgraded is true (it just changes what onBackButtonPress does). The new copy-settings page is the only upgrade surface that removes it.
• Repros on all listed native + web platforms because the header rendering is shared and platform-agnostic.

Confidence: High — single-line root cause, verified against the header component default and the established upgrade page's behavior.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/95723) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[shubham1206agra]

@yuwenmemon This is intentional. Please close this issue