[Submit] Couldn't load card feeds error message displayed in Company cards page for approver upgrade flow when approving a Submit report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: 9.4.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Issue observed when QAing Bottom Up Submit Plan
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal team
Slack conversation (hyperlinked to channel name):

Action Performed:

1. Create a workspace in Submit beta
2. Submit an expense for approval to user B
3. Approve the report as user B and upgrade the Workspace to Collect during approval
4. Navigate to upgraded workspace settings as User B
5. Click Company cards and observe

Expected Result:

Company cards page displayed without any error

Actual Result:

Couldn't load card feeds error message displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Recording.3260.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @carlosmiceli

[m-natarajan]

@garrettmknight @iwiznia Tagging you for the follow-up on this issue.

[hungvu193]

Looks like a BE issue to me. I'll take a look

[hungvu193]

@ijmalik Please don't post proposal at issue the don't have Help Wanted label. Thanks

[hungvu193]

On it 👀

[hungvu193]

BE issue. After upgrading, our policy still doesn't have policyAccountID, so this condition here is true since our policyAccountID fell back to default number:

App/src/components/Tables/WorkspaceCompanyCardsTable/index.tsx

Lines 121 to 126 in 49ce089

	const shouldShowWorkspaceFeedsLoadError = domainOrWorkspaceAccountID === CONST.DEFAULT_NUMBER_ID && isPolicyLoaded && !isOffline;
	const workspaceCardFeedsErrors = shouldShowWorkspaceFeedsLoadError
	? {
	[CONST.COMPANY_CARDS.WORKSPACE_FEEDS_LOAD_ERROR]: translate('workspace.companyCards.error.workspaceFeedsCouldNotBeLoadedMessage'),
	}
	: workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.errors;

[hungvu193]

cc @iwiznia, @carlosmiceli This is a backend issue. It will work if I disbale the company card and enable it again, so probably we forgot to initialize policyAccountID while upgrading the workspace from submit to collect?

[carlosmiceli]

I think that's related to https://github.com/Expensify/Expensify/issues/641057 - I can investigate.