Search - "Spend over time" row is hidden behind offline indicator and user can´t scroll down

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: 9.4.45-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96443
Email or phone of affected tester (no customers): ibellicotest+2766@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Search

Action Performed:

1. Open the Expensify app.
2. Turn off internet connection.
3. Tap on the search icon on the top right corner.
4. Type "Go To" and close keyboard.
5. Note that spend navigation suggestions are visible.
6. Reopen keyboard.
7. Note that "Spend over time" row is hidden behind offline indicator.
8. Try to scroll down.
9. Note that user can´t scroll down while keyboard is opened.

Expected Result:

Search results list should be scrollable when some results are not visible, despite keyboard being opened.

Actual Result:

"Go to spend over time" row is hidden behind offline indicator and user is unable to scroll down to it while keyboard is opened.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7219307_1785198839979.Over.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7219307

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a3a6d265ac17ba0106f99c976111fcdede2df91c9cacc5aab2db1ec05e281861

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #96443

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #96443 - "Add Spend navigation suggestions to Search Router" by @nabi-ebrahimi (High confidence)
Related Issues: #92752 (the feature request this PR implemented)

Recommendation: ROLL FORWARD

This is a self-contained new feature (Spend "Go to …" rows in the Search Router) that does not exist in production, and the fix is a small, targeted layout adjustment (bottom padding / offline-indicator clearance on the list) that is simpler and safer than reverting the entire feature PR.

Assigned: @nabi-ebrahimi (PR author), @marufsharifi (approving reviewer), @carlosmiceli (approving reviewer) from PR #96443
Labels: No label changes. Kept DeployBlockerCash (App deploy is blocked by this frontend bug). DeployBlocker was not present. No labels removed.

📋 Detailed Analysis

Evidence

• The bug is specifically about the Spend "Go to spend over time" navigation suggestion row in the Search Router — the exact rows that PR Add Spend navigation suggestions to Search Router #96443 introduced. Its title is literally "Add Spend navigation suggestions to Search Router."
• Before this PR, useNavigationSuggestions produced only 5 top-level rows (Home, Inbox, Expenses, Workspaces, Settings). This PR appends the full set of Spend destinations (Expenses, Reports, Company cards, Approvals, "Spend over time", etc.) via buildSpendNavigationItems, substantially lengthening the suggestion list.
• On a narrow Android screen with the keyboard open, the now-longer list overflows and the bottom rows are covered by the offline indicator, and the reporter cannot scroll to reach them.
• Reproducible on staging only; N/A in production because the feature is new — consistent with the PR shipping in the 9.4.45 staging deploy.
• PR Add Spend navigation suggestions to Search Router #96443 is listed in the current StagingDeployCash checklist Deploy Checklist: New Expensify 2026-07-27 #97134 (item 94), confirming it is part of this release.

Verification

• Affected files touched by the PR:
  • src/components/Search/SearchRouter/useNavigationSuggestions.tsx (adds buildSpendNavigationItems, appends Spend section to suggestions)
  • src/components/Search/SearchRouter/SearchRouter.tsx
  • src/components/Search/SearchList/ListItem/SearchQueryListItem.tsx (adds rightHandSideComponent={item.rightElement})
  • src/libs/SearchNavigationUtils.ts (new — navigateToCannedSpendSearch)
  • src/libs/SearchUIUtils.ts, src/pages/Search/SearchTypeMenuNarrow.tsx, SearchTypeMenuWide.tsx
• git log confirms these navigation-suggestion changes and the new SearchNavigationUtils.ts file first appeared in the commit that shipped 9.4.45, matching when the bug appeared.
• The suggestion list is rendered through SearchAutocompleteList → SelectionListWithSections with contentContainerStyle: styles.pb2 and addBottomSafeAreaPadding; this padding does not account for the offline indicator overlay when the keyboard shrinks the visible area.

Root Cause

PR #96443 appends the Spend destinations to the Search Router suggestion list without accounting for the reduced viewport when the keyboard is open on narrow (Android) layouts. The longer list now extends beneath the offline indicator, and the list's bottom padding (styles.pb2 on the SelectionListWithSections content container in SearchAutocompleteList.tsx) does not reserve space for the offline indicator overlay, so the final row ("Go to spend over time") sits under the indicator and is unreachable by scrolling. The underlying scroll/offline-overlap behavior was latent before, but this PR is what surfaced it by making the list long enough to overflow.

Suggested fix direction (roll forward)

Add bottom clearance to the Search Router suggestion list equal to the offline indicator height when offline (e.g. increase contentContainerStyle bottom padding / apply an offline-aware bottom inset in SearchAutocompleteList.tsx), so the last suggestion row can scroll clear of the offline indicator with the keyboard open. This keeps the shipped feature intact and avoids reintroducing the (larger) revert churn across SearchUIUtils and the SearchTypeMenu components.