[NO QA] Travel billing: Update bank account setup copy - #100106
Merged
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index a6581278..7b94c1db 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6211,8 +6211,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
finishSetup: 'Einrichtung abschließen',
chooseBankAccount: 'Bankkonto auswählen',
chooseExistingBank: 'Wählen Sie ein bestehendes Geschäftskonto aus, um den Saldo Ihrer Expensify Karte zu bezahlen, oder fügen Sie ein neues Bankkonto hinzu',
- chooseExistingBankForTravelBilling:
- 'Wählen Sie ein bestehendes Geschäftskonto aus, um Ihr Consolidated Travel Billing-Guthaben zu bezahlen, oder fügen Sie ein neues Bankkonto hinzu',
+ chooseExistingBankForTravelBilling: 'Wählen Sie ein vorhandenes Geschäftskonto, um Ihre konsolidierte Reiseabrechnung zu bezahlen, oder fügen Sie ein neues Bankkonto hinzu',
accountEndingIn: 'Konto mit Endziffern',
addNewBankAccount: 'Neues Bankkonto hinzufügen',
settlementAccount: 'Verrechnungskonto',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index fc8c1f0a..2cfc3dfd 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -6322,7 +6322,7 @@ _Για πιο αναλυτικές οδηγίες, [επισκεφθείτε τ
chooseBankAccount: 'Επιλέξτε τραπεζικό λογαριασμό',
chooseExistingBank: 'Επιλέξτε έναν υπάρχοντα επαγγελματικό τραπεζικό λογαριασμό για να πληρώσετε το υπόλοιπο της Κάρτας Expensify ή προσθέστε έναν νέο τραπεζικό λογαριασμό',
chooseExistingBankForTravelBilling:
- 'Επιλέξτε έναν υπάρχοντα επαγγελματικό τραπεζικό λογαριασμό για να πληρώσετε το υπόλοιπο του Consolidated Travel Billing ή προσθέστε έναν νέο τραπεζικό λογαριασμό',
+ 'Επιλέξτε έναν υπάρχοντα επαγγελματικό τραπεζικό λογαριασμό για να πληρώσετε το υπόλοιπο του Consolidated Travel Billing σας ή προσθέστε έναν νέο τραπεζικό λογαριασμό',
accountEndingIn: 'Λογαριασμός που λήγει σε',
addNewBankAccount: 'Προσθήκη νέου τραπεζικού λογαριασμού',
settlementAccount: 'Λογαριασμός διακανονισμού',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 3416444d..1178ed6f 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -6085,7 +6085,7 @@ ${amount} para ${merchant} - ${date}`,
finishSetup: 'Terminar configuración',
chooseBankAccount: 'Elegir cuenta bancaria',
chooseExistingBank: 'Elige una cuenta bancaria comercial existente para pagar el saldo de su Tarjeta Expensify o añade una nueva cuenta bancaria.',
- chooseExistingBankForTravelBilling: 'Elige una cuenta bancaria comercial existente para pagar el saldo de tu Consolidated Travel Billing o añade una nueva cuenta bancaria.',
+ chooseExistingBankForTravelBilling: 'Elige una cuenta bancaria empresarial existente para pagar tu saldo de Facturación de Viajes Consolidada o añade una nueva cuenta bancaria',
accountEndingIn: 'Cuenta terminada en',
addNewBankAccount: 'Añadir nueva cuenta bancaria',
settlementAccount: 'Cuenta de liquidación',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 363667a6..94db5bfe 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -6217,7 +6217,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
chooseBankAccount: 'Choisir un compte bancaire',
chooseExistingBank: 'Choisissez un compte bancaire professionnel existant pour régler le solde de votre Carte Expensify ou ajoutez un nouveau compte bancaire',
chooseExistingBankForTravelBilling:
- 'Choisissez un compte bancaire professionnel existant pour régler le solde de votre Consolidated Travel Billing ou ajoutez un nouveau compte bancaire',
+ 'Choisissez un compte bancaire professionnel existant pour payer votre solde de facturation de voyage consolidée, ou ajoutez un nouveau compte bancaire',
accountEndingIn: 'Compte se terminant par',
addNewBankAccount: 'Ajouter un nouveau compte bancaire',
settlementAccount: 'Compte de règlement',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index d811008c..8dadb5bc 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6169,7 +6169,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
chooseBankAccount: 'Scegli il conto bancario',
chooseExistingBank: 'Scegli un conto bancario aziendale esistente per pagare il saldo della tua Carta Expensify oppure aggiungi un nuovo conto bancario',
chooseExistingBankForTravelBilling:
- 'Scegli un conto bancario aziendale esistente per pagare il saldo della tua Consolidated Travel Billing oppure aggiungi un nuovo conto bancario',
+ 'Scegli un conto bancario aziendale esistente per pagare il saldo della fatturazione di viaggio consolidata oppure aggiungi un nuovo conto bancario',
accountEndingIn: 'Conto che termina con',
addNewBankAccount: 'Aggiungi un nuovo conto bancario',
settlementAccount: 'Conto di regolamento',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index e63103ff..a30aaf7c 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6095,7 +6095,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
finishSetup: 'セットアップを完了',
chooseBankAccount: '銀行口座を選択',
chooseExistingBank: '既存のビジネス銀行口座を選んで Expensify カードの残高を支払うか、新しい銀行口座を追加してください',
- chooseExistingBankForTravelBilling: '既存のビジネス銀行口座を選んで Consolidated Travel Billing の残高を支払うか、新しい銀行口座を追加してください',
+ chooseExistingBankForTravelBilling: '既存のビジネス銀行口座を選択して一括旅行請求の残高を支払うか、新しい銀行口座を追加してください',
accountEndingIn: '末尾が…の口座',
addNewBankAccount: '新しい銀行口座を追加',
settlementAccount: '決済口座',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index ead6187d..ae852923 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6161,7 +6161,7 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
finishSetup: 'Configuratie voltooien',
chooseBankAccount: 'Kies bankrekening',
chooseExistingBank: 'Kies een bestaande zakelijke bankrekening om je saldo van de Expensify Kaart te betalen, of voeg een nieuwe bankrekening toe',
- chooseExistingBankForTravelBilling: 'Kies een bestaande zakelijke bankrekening om je saldo van de Consolidated Travel Billing te betalen, of voeg een nieuwe bankrekening toe',
+ chooseExistingBankForTravelBilling: 'Kies een bestaande zakelijke bankrekening om je geconsolideerde reissaldi te betalen, of voeg een nieuwe bankrekening toe',
accountEndingIn: 'Rekening eindigend op',
addNewBankAccount: 'Nieuwe bankrekening toevoegen',
settlementAccount: 'Verrekeningsrekening',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index fdef7edc..fd5f415f 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6183,7 +6183,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
finishSetup: 'Zakończ konfigurację',
chooseBankAccount: 'Wybierz konto bankowe',
chooseExistingBank: 'Wybierz istniejące firmowe konto bankowe, żeby spłacić saldo Karty Expensify, albo dodaj nowe konto bankowe',
- chooseExistingBankForTravelBilling: 'Wybierz istniejące firmowe konto bankowe, żeby spłacić saldo Consolidated Travel Billing, albo dodaj nowe konto bankowe',
+ chooseExistingBankForTravelBilling: 'Wybierz istniejące firmowe konto bankowe, aby zapłacić saldo skonsolidowanego rozliczenia podróży, albo dodaj nowe konto bankowe',
accountEndingIn: 'Konto kończące się na',
addNewBankAccount: 'Dodaj nowe konto bankowe',
settlementAccount: 'Konto rozliczeniowe',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 8f42dedd..201208cf 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6161,7 +6161,7 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
finishSetup: 'Concluir configuração',
chooseBankAccount: 'Escolher conta bancária',
chooseExistingBank: 'Escolha uma conta bancária empresarial existente para pagar o saldo do seu Cartão Expensify ou adicione uma nova conta bancária',
- chooseExistingBankForTravelBilling: 'Escolha uma conta bancária empresarial existente para pagar o saldo do seu Consolidated Travel Billing ou adicione uma nova conta bancária',
+ chooseExistingBankForTravelBilling: 'Escolha uma conta bancária empresarial existente para pagar o saldo da sua Fatura Consolidada de Viagem ou adicione uma nova conta bancária',
accountEndingIn: 'Conta com final',
addNewBankAccount: 'Adicionar uma nova conta bancária',
settlementAccount: 'Conta de liquidação',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index f37cabac..f9e49942 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5954,7 +5954,7 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
finishSetup: '完成设置',
chooseBankAccount: '选择银行账户',
chooseExistingBank: '选择一个现有的企业银行账户来支付您的 Expensify 卡余额，或添加一个新的银行账户',
- chooseExistingBankForTravelBilling: '选择一个现有的企业银行账户来支付您的 Consolidated Travel Billing 余额，或添加一个新的银行账户',
+ chooseExistingBankForTravelBilling: '选择一个现有的企业银行账户来支付您的合并差旅账单余额，或添加新银行账户',
accountEndingIn: '账号末尾为',
addNewBankAccount: '添加新银行账户',
settlementAccount: '结算账户',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@TaduJR @flaviadefaria ignore the ping |
rlinoz
approved these changes
Sep 2, 2026
Contributor
|
will have to merge main I think |
…illing-bank-copy-main
…illing-bank-copy-main
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
35 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.69-0 🚀
|
Contributor
|
🤖 No help site changes are required — I did not create a docs PR. This PR is a copy-only change: it adds What I checked in
|
Contributor
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Use a dedicated localized string for the Consolidated Travel Billing settlement-account setup flow. Expensify Card setup continues to use the existing Expensify Card balance copy.
Fixed Issues
$ #100094
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari