Skip to content

Revert "Add intl deposit account collection" - #100208

Merged
arosiclair merged 1 commit into
mainfrom
revert-96196-dukenv/cda-international-bank-account-details
Sep 2, 2026
Merged

Revert "Add intl deposit account collection"#100208
arosiclair merged 1 commit into
mainfrom
revert-96196-dukenv/cda-international-bank-account-details

Conversation

@arosiclair

@arosiclair arosiclair commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Reverts #96196

Part of

Test/QA Steps

  1. Log into NewDot as an admin
  2. Add a US withdrawal account to the policy
  3. Add a member
  4. Log in as the member
  5. Settings > Wallet > Add personal bank account
  6. Select Canada
  7. Input initial bank details
  8. Verify there is no page that requests international bank details (IBAN number)

@arosiclair arosiclair self-assigned this Sep 2, 2026
@arosiclair
arosiclair marked this pull request as ready for review September 2, 2026 17:57
@arosiclair
arosiclair requested review from a team as code owners September 2, 2026 17:57
@melvin-bot
melvin-bot Bot requested review from NicolasBonet and flaviadefaria and removed request for a team September 2, 2026 17:57
@melvin-bot

melvin-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@francoisl

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@francoisl

Copy link
Copy Markdown
Contributor

Can you link what issues this in the OP please?

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 91.07% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/BankAccountUtils.ts 94.11% <ø> (+4.64%) ⬆️
src/libs/ExportOnyxState/common.ts 80.95% <ø> (ø)
src/libs/actions/BankAccounts.ts 24.23% <ø> (+0.32%) ⬆️
src/pages/AddPersonalBankAccountPage/index.tsx 72.50% <100.00%> (-0.34%) ⬇️
...sonalBankAccountPage/substeps/ConfirmationStep.tsx 8.33% <ø> (+1.01%) ⬆️
src/setup/index.ts 100.00% <ø> (ø)
src/types/form/PersonalBankAccountForm.ts 100.00% <ø> (ø)
... and 6 more
... and 11 files with indirect coverage changes

@arosiclair
arosiclair merged commit 420d386 into main Sep 2, 2026
49 of 50 checks passed
@arosiclair
arosiclair deleted the revert-96196-dukenv/cda-international-bank-account-details branch September 2, 2026 19:08
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Sep 2, 2026
…ernational-bank-account-details

Revert "Add intl deposit account collection"

(cherry picked from commit 420d386)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 2, 2026
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.66-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR. No draft PR was created.

This PR reverts #96196, which added an extra International bank account details step (IBAN + SWIFT/BIC) to the personal deposit account flow. That step was never documented on the help site, so removing it leaves every article in docs/articles accurate as written.

What I checked

The reverted feature was never in the docs. Grepping docs/articles/new-expensify for IBAN, SWIFT/BIC, international bank, and international deposit returns no match in any wallet or deposit-account article. The only new-Expensify hit for IBAN is unrelated (a bank name in a company card article).

The two articles that cover this flow still describe the post-revert behavior correctly:

Not affected: Global-Reimbursement-Canada.md mentions SWIFT codes, but it is scoped to Workspace Admins connecting a business bank account and explicitly excludes member deposit accounts. The Expensify Classic bank account articles are also untouched by this PR.

One separate, pre-existing docs issue

While verifying labels against the live UI, I confirmed the Wallet page shows the section heading Bank accounts and the button Add bank account (sentence case):

Wallet page showing the Bank accounts section and Add bank account button

Connect-a-Personal-Bank-Account.md writes these as Bank Accounts and Add Bank Account on lines 10, 23-24, 34, and 50, which breaks the "Match capitalization exactly" and "Use Sentence case" rules in docs/HELPSITE_NAMING_CONVENTIONS.md. This has nothing to do with your revert, so I did not fold it into a PR titled after this change. Reply with @MelvinBot fix the bank account label casing in the help site if you want it done as its own PR.

I could not verify the non-US steps end to end in the live UI: tapping Add bank account on the test account opened a Validate your account magic-code screen, which the tester can't clear. The docs conclusion above rests on the code diff and the article text, not on driving that flow.

There is no linked help site PR to mark Ready for review, since no article changes were needed. @arosiclair, please confirm this matches the current behavior — if you think an article does need updating, tell me which one and I'll open the draft PR.


view run

OSBotify pushed a commit that referenced this pull request Sep 2, 2026
…ernational-bank-account-details

Revert "Add intl deposit account collection"

(cherry picked from commit 420d386)

(cherry-picked to production by arosiclair)
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.67-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.68-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Production CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants