Docs updates for E/A#99217 Export step added to grouped export instructions - #100233
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#99217 Export step added to grouped export instructions#100233MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Docs follow-up to #99217, which changed how the Export entry behaves in the Search bulk-action dropdown.
Before that PR, whenever a selection offered only one export option, the Export row collapsed and that single option was shown directly at the top level of the dropdown. A group selection on the Spend page is exactly that case — it offers only Current view — so Export Expenses and Reports told members to select Current view straight from the selection dropdown.
After the PR, Export no longer collapses. When other bulk actions sit alongside it, the export options are nested one level deeper behind an Export row. When Export is the only available action, the options still open directly, now under a plain Export heading.
This PR updates the three places in that article that told members to select Current view without first selecting Export:
No other help article needed a change. How to Export Expenses, How to Export Reports, and the Export as CSV and Export your current filtered view sections of this same article already described selecting Export before choosing a template, so the PR only makes them more accurate.
Labels were checked against the live UI on a dev build of the branch: the selection button reads 1 selected, the dropdown row reads Export, and the option reads Current view.
Fixed Issues
$
PROPOSAL:
There is no GitHub issue for this docs update. It follows the behavior change in #99217.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review". Please describe what tests you performed that validate your changes worked.
Offline tests
N/A — this PR only changes Markdown in
docs/articles. There is no app behavior to test offline.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review". Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ZhenjaHorbach, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.