Skip to content

chore(ci): cache Jest transforms in the Reassure perf jobs - #100297

Draft
WojtekBoman wants to merge 5 commits into
Expensify:mainfrom
software-mansion-labs:cache-jest-transforms-in-perf-tests
Draft

chore(ci): cache Jest transforms in the Reassure perf jobs#100297
WojtekBoman wants to merge 5 commits into
Expensify:mainfrom
software-mansion-labs:cache-jest-transforms-in-perf-tests

Conversation

@WojtekBoman

@WojtekBoman WojtekBoman commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The Reassure perf jobs re-transformed ~7,000 files through Babel on every run, 45% of each measure job (217.0s cold vs 119.7s warm). They now restore a Jest transform cache written on main by a new seedJestPerfCache.yml, called from seedStickyDisks.yml. Restore-only and no restore-keys, so a fork PR can never write the shared entry. Also adds concurrency cancellation and a bun:test guard on the shared key.

Fixed Issues

$
PROPOSAL:

Tests

  1. Open this PR and let the Run performance tests workflow run.

  2. Open the baseline-perf-tests job log and expand Restore Jest transform cache. Verify the step reports a cache hit for a key of the form Linux-X64-jest-perf-<hash> (on the very first run after merge to main a miss is expected, since the entry has not been seeded yet).

  3. Expand Report Jest cache size in the same job. Verify the run annotation reads roughly Jest perf cache: ~120MB, ~7000 files, not absent and not double that size.

  4. Repeat steps 2-3 for the perf-tests (branch) job. Verify both measure jobs restore the exact same key.

  5. Verify that the perf comparison comment is still posted on the PR and that render counts are unchanged from before this PR (COUNT_DEVIATION: 0 must not start firing).

  6. Push a second commit to this PR while the first Run performance tests run is still in progress.

  7. Verify the in-flight run is cancelled by the new concurrency group and only the newest run continues, and that no other PR's perf run is cancelled.

  8. On a checkout of this branch, run npm run test:bun -- tests/tooling/jestPerfCacheKey.test.ts.

  9. Verify all tests pass.

  10. Edit any one of the four .jest-cache key: values in .github/workflows/reassurePerformanceTests.yml or .github/workflows/seedJestPerfCache.yml so it differs by a single character, re-run the test file, and verify keys every .jest-cache step identically fails. Revert the edit.

  11. Add a restore-keys: entry to any of those four steps, re-run, and verify never falls back to a prefix key fails. Revert the edit.

  12. Remove the seedJestPerfCache job from .github/workflows/seedStickyDisks.yml, re-run, and verify is reachable from a push to main fails. Revert the edit.

  • Verify that no errors appear in the JS console

Offline tests

N/A - this PR only changes GitHub Actions workflows and a tooling test. It touches no app code, no API calls, and no Onyx data.

QA Steps

N/A - CI-only change with no user-facing surface. Same as tests: verification happens in the GitHub Actions logs on main after merge, where Seed Jest perf cache should run as part of Seed sticky disks on each push, skip the ~220s populate when the entry is already present, and re-populate it after a toolchain change to the lockfile, patches/**, babel.config.js, config/babel/**, jest.config.js, or .nvmrc.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@WojtekBoman

Copy link
Copy Markdown
Contributor Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9632d94cc7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/tooling/jestPerfCacheKey.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant