Skip to content

[No QA] Fix live Onyx hook references - #100314

Merged
puneetlath merged 1 commit into
mainfrom
codex/fix-inline-edit-onyx-hook
Sep 3, 2026
Merged

[No QA] Fix live Onyx hook references#100314
puneetlath merged 1 commit into
mainfrom
codex/fix-inline-edit-onyx-hook

Conversation

@puneetlath

@puneetlath puneetlath commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Replace three references to the undefined originalUseOnyx identifier with the existing useOnyxWithoutSnapshots alias.

This fixes the TypeScript and ESLint failures introduced by #99279. The ESLint errors were secondary type-safety errors caused by the unresolved identifier.

[No QA] because this is a compile-time identifier correction with no intended behavior change.

Fixed Issues

$ #100310
$ #100311

Tests

  1. Run npm run lint-changed and verify it passes.
  2. Run npm run typecheck and verify it passes without TS2304 errors.
  3. Run npm run react-compiler-compliance-check check-changed and verify it passes.
  4. Run npm run spell-changed and verify it passes.

Offline tests

N/A — compile-time identifier correction only.

QA Steps

N/A

PR Author Checklist

  • I wrote clear testing steps that cover the changes made in this PR.
  • I followed proper code patterns and the review guidelines.
  • I verified that no new copy, assets, styles, or runtime behavior were introduced.
  • I ran the required lint, typecheck, React Compiler, and spelling checks.

Screenshots/Videos

N/A

@puneetlath
puneetlath requested review from a team as code owners September 3, 2026 15:26
@melvin-bot
melvin-bot Bot requested review from dylanexpensify and lakchote and removed request for a team September 3, 2026 15:26
@melvin-bot

melvin-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 3, 2026 15:26
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/hooks/useTransactionInlineEdit.ts 0.00% <0.00%> (ø)
... and 11 files with indirect coverage changes

@puneetlath
puneetlath merged commit 6282a7a into main Sep 3, 2026
45 of 46 checks passed
@puneetlath
puneetlath deleted the codex/fix-inline-edit-onyx-hook branch September 3, 2026 16:06
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.70-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a docs PR.

This PR swaps three references to the undefined originalUseOnyx identifier for the existing useOnyxWithoutSnapshots alias in src/hooks/useTransactionInlineEdit.ts. It is a compile-time identifier correction that fixes the TypeScript TS2304 and ESLint failures from #99279.

Why no docs update is needed
  • No user-facing change. The diff touches one internal hook file (3 additions, 3 deletions). There is no new feature, setting, tab, button, or copy string.
  • No behavior change. useOnyxWithoutSnapshots is the alias the file already imports; the old name never resolved, so nothing that worked before behaves differently.
  • Existing articles stay accurate. The inline-edit flow this hook powers is already documented in Edit Expenses, Managing Expenses in a Report, and Getting Started with the Spend Page. None of those describe the internals this PR corrects, so none need edits.
  • The PR is marked [No QA] with N/A QA steps, which matches this read.

@puneetlath, please confirm you agree that no help site update is needed. If you think a specific article should change, reply with @MelvinBot <the article and what to change> and I will create the draft docs PR.


view run

@OSBotify

OSBotify commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.72-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR.

This PR replaces three references to the undefined originalUseOnyx identifier with the existing useOnyxWithoutSnapshots alias in src/hooks/useTransactionInlineEdit.ts. It is a compile-time identifier correction that fixes the TypeScript and ESLint failures from #99279.

Nothing here changes what a customer sees or does:

  • No new or renamed features, tabs, settings, or buttons.
  • No copy, string, or language file changes.
  • No workflow, permission, or behavior changes — the PR is marked [No QA] and the author confirmed no runtime behavior was introduced.

Because App/docs/articles documents customer-facing behavior only, there is nothing to add or update, so I did not create a draft help site PR.

@puneetlath, no linked help site PR was created since no documentation changes are needed. If you believe this change does alter customer-facing behavior, reply with what changed and I'll draft the docs update.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants