[No QA] Docs updates for E/A#98672 document temporary bank issue receipt message - #100339
[No QA] Docs updates for E/A#98672 document temporary bank issue receipt message#100339MelvinBot wants to merge 1 commit into
Conversation
…pe code 531 Co-authored-by: Tim Golen <tgolen@users.noreply.github.com>
MelvinBot
added
the
HelpDot
tgolen
changed the title
|
@MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Done — this PR is now Ready for review. No app testing was run: this PR only changes help site markdown under |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - **“Can't auto-match receipt because your bank connection needs re-authentication.”** — Your bank needs you to log in again. Select **Reconnect** in the message, or follow the steps above to fix the card connection. | ||
|
|
||
| If a message asking you to try again later stays on an expense for more than a few days, contact Concierge with the cardholder email and the last four digits of the card. | ||
|
|
There was a problem hiding this comment.
UI label inconsistency: This new bullet says select Fix the card, but the rest of this article uses the exact UI label Fix card (see the steps section and both FAQ entries). Per HELPSITE_NAMING_CONVENTIONS.md ("Use the exact text shown in the product UI" / "Do not paraphrase labels"), use Fix card here for consistency with the actual button.
| Not every receipt matching message means your card connection is broken. The wording tells you whether you need to do something: | ||
|
|
||
| - **“Can't auto-match receipt due to a temporary bank issue. Please try again later.”** — Your bank returned a response Expensify couldn't use this time. Nothing is broken and no action is needed. Expensify retries automatically, and the message clears once the transaction imports. | ||
| - **“Can't auto-match receipt due to broken card connection.”** — The card connection needs attention. Follow the steps above to fix the card connection, or select **Fix the card** in the message to go straight to the **Card details** page. |
There was a problem hiding this comment.
UI label inconsistency: This bullet says select Fix the card, but the rest of this article uses the exact UI label Fix card (see the numbered steps and the "Why did the broken connection reminders disappear..." FAQ). Per HELPSITE_NAMING_CONVENTIONS.md ("Use the exact text shown in the product UI" / "Do not paraphrase labels"), change this to Fix card so it matches the actual button.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9df39f8d5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| While a card connection is unhealthy, Expensify holds receipt-scanned expenses back instead of merging them with a card transaction and shows a message on the expense. The wording tells you whether a Workspace Admin needs to reconnect the feed: | ||
|
|
||
| - **“Can't auto-match receipt due to a temporary bank issue. Please try again later.”** — The bank returned a response Expensify couldn't use this time. The feed isn't broken and no one needs to reconnect it. Expensify retries automatically, and the message clears once the transaction imports. | ||
| - **“Can't auto-match receipt due to broken bank connection.”** and **“Receipt pending due to broken bank connection”** — The connection needs attention. A Workspace Admin should reconnect the feed using the steps above. |
There was a problem hiding this comment.
When either quoted message is generated for BROKEN_CARD_CONNECTION_530, reconnecting is not the remedy: code 530 is included in BROKEN_CONNECTION_IGNORED_STATUSES (src/CONST/index.ts:115), and isCardConnectionBroken() consequently treats it as a non-broken connection (src/libs/CardUtils.ts:1419-1423). The 530 translation also returns before the actionable reconnect branches in src/languages/en.ts:10286-10316. Directing a Workspace Admin to reconnect sends them through an ineffective flow; this subtype should instead be documented as an Expensify-side condition that requires waiting.
Useful? React with 👍 / 👎.
| Not every receipt matching message means your card connection is broken. The wording tells you whether you need to do something: | ||
|
|
||
| - **“Can't auto-match receipt due to a temporary bank issue. Please try again later.”** — Your bank returned a response Expensify couldn't use this time. Nothing is broken and no action is needed. Expensify retries automatically, and the message clears once the transaction imports. | ||
| - **“Can't auto-match receipt due to broken card connection.”** — The card connection needs attention. Follow the steps above to fix the card connection, or select **Fix the card** in the message to go straight to the **Card details** page. |
There was a problem hiding this comment.
When an account has multiple personal cards with broken connections, Fix the card does not go straight to the affected card's Card details page. getBrokenConnectionUrlToFixPersonalCard() returns the details route only when exactly one card is broken and otherwise returns the general Wallet route (src/libs/CardUtils.ts:1939-1948). Qualify this instruction so users with multiple broken cards know they must select the relevant card from Wallet.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR is a targeted, well-scoped follow-up to #98672. It documents the new self-resolving RTER message ("Cannot auto-match receipt due to a temporary bank issue. Please try again later.") in the two articles that own the card-connection troubleshooting workflow. Each file gains a new task-based decision section, a new FAQ entry, and updated keywords/internalScope metadata. The changes are consistent across both files and close a real search-intent gap, since users searching the new wording previously landed on reconnect-the-feed guidance that does not apply. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
2 participants
Explanation of Change
Help site follow-up for #98672, which adds a new user-facing RTER violation message for company/personal card scrape code
531: “Can't auto-match receipt due to a temporary bank issue. Please try again later.”Until now the help site only described broken-connection messaging that requires the member or a Workspace Admin to go fix the card. The new
531copy is the opposite — it is temporary, self-resolving, and needs no action. Without a docs update, anyone who searches the new wording lands on articles that tell them to reconnect a feed that isn't actually broken.This PR updates the two articles that own that workflow:
docs/articles/new-expensify/connect-credit-cards/Fix-a-Broken-Company-Card-Feed-Connection.md## How to tell whether a receipt matching message needs actionsection that lists each receipt matching message a Workspace Admin can see and says whether it requires reconnecting the feed.keywordsandinternalScopeupdated to cover the new wording.docs/articles/new-expensify/connect-credit-cards/Manage-Personal-Cards.md## How to tell whether a receipt matching message needs actionsection covering the personal card variants of the same messages.keywordsupdated to cover the new wording.Every quoted message is copied verbatim from
src/languages/en.tson the linked PR's branch, so the help site matches what renders in the app. UI labels used in the new copy (Company cards, Card details, Wallet) were verified against the current app UI.Authored against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one#title plus# FAQ,##only below it, every new heading task-based and starting with an action verb or question word, and UI labels bolded in exact Sentence case.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/671466
PROPOSAL:
Tests
None
Offline tests
Not applicable — this PR only changes help site markdown under
docs/articles.QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@tgolen, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.