Skip to content

Docs updates for E/A#99842 Getting started checklist for Submit workspaces - #100340

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsSubmitGettingStartedChecklist
Draft

Docs updates for E/A#99842 Getting started checklist for Submit workspaces#100340
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsSubmitGettingStartedChecklist

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #99842, which extended the Getting started section on Home to the Submit expenses to my employer onboarding intent.

The Home article already documented the Getting started section, but its content was written before this intent existed, so two statements are now wrong:

  • The FAQ listed only the manage my team, track and budget my expenses, and Organize my personal spending intents, so a Submit user looking up "why don't I see Getting started" got an answer that told them the section shouldn't appear for them at all.
  • The same FAQ said the section appears "within 60 days of your free trial start date". Submit is a free plan and never starts a trial. In code the window is anchored on the Submit workspace's creation time instead (useGettingStartedItems.ts:116), so the documented 60-day rule did not apply to these users.

What changed in Expensify-Home-Overview.md:

  1. How the Getting started section works on Home now describes the two to-dos this intent shows — Customize your expense categories and Link personal card — including that the categories item only appears while Categories is enabled, that there is no Create a workspace item, and that the section hides once both are checked off. Cross-links to the existing Submit workspace article.
  2. Why don't I see the Getting started section? now lists Submit expenses to my employer as a qualifying intent, and splits the 60-day rule: free trial start date for the paid intents, Submit workspace creation date for this one. It also states the ownership gate — invited members of someone else's Submit workspace do not see the section.
  3. Added submit expenses to my employer, Submit workspace, and customize your expense categories to the article keywords.

Verification of labels and behavior:

  • Both to-do labels are quoted verbatim from en.ts (customizeExpenseCategories: 'Customize your expense categories', linkPersonalCard: 'Link personal card'), and the intent label from CONST.ONBOARDING_CHOICES.EMPLOYER: 'Submit expenses to my employer'.
  • Wallet and Categories were confirmed against the live UI on dev NewDot web — the Account settings menu item is exactly Wallet and the workspace settings item and page heading are both exactly Categories.
  • The destinations, gates, and hide-when-complete behavior were read from the merged hook rather than the PR description: routes ROUTES.WORKSPACE_CATEGORIES and ROUTES.SETTINGS_WALLET, the isPolicyOwner ownership gate, the areCategoriesEnabled condition, and buildResult hiding the section when every item is complete.

Scope is deliberately limited to the one article that documents this section. No other docs/articles file mentions the Getting started checklist.

Note: npm run spell-changed could not be run in this environment (the sandbox blocked the cspell invocation). The change adds no new product nouns beyond terms already used elsewhere in the help site.

Fixed Issues

$
PROPOSAL:

Documentation follow-up requested on #99842. There is no separate help site issue, so the $ line is intentionally left blank.

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — this PR only changes help site Markdown content.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
@MelvinBot MelvinBot self-assigned this Sep 3, 2026
@MelvinBot
MelvinBot requested a review from a team September 3, 2026 19:12
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant