Docs updates for E/A#99842 Getting started checklist for Submit workspaces - #100340
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#99842 Getting started checklist for Submit workspaces#100340MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #99842, which extended the
Getting startedsection on Home to the Submit expenses to my employer onboarding intent.The Home article already documented the
Getting startedsection, but its content was written before this intent existed, so two statements are now wrong:useGettingStartedItems.ts:116), so the documented 60-day rule did not apply to these users.What changed in
Expensify-Home-Overview.md:How the Getting started section works on Homenow describes the two to-dos this intent shows — Customize your expense categories and Link personal card — including that the categories item only appears while Categories is enabled, that there is no Create a workspace item, and that the section hides once both are checked off. Cross-links to the existing Submit workspace article.Why don't I see the Getting started section?now lists Submit expenses to my employer as a qualifying intent, and splits the 60-day rule: free trial start date for the paid intents, Submit workspace creation date for this one. It also states the ownership gate — invited members of someone else's Submit workspace do not see the section.submit expenses to my employer,Submit workspace, andcustomize your expense categoriesto the articlekeywords.Verification of labels and behavior:
en.ts(customizeExpenseCategories: 'Customize your expense categories',linkPersonalCard: 'Link personal card'), and the intent label fromCONST.ONBOARDING_CHOICES.EMPLOYER:'Submit expenses to my employer'.Walletand the workspace settings item and page heading are both exactlyCategories.ROUTES.WORKSPACE_CATEGORIESandROUTES.SETTINGS_WALLET, theisPolicyOwnerownership gate, theareCategoriesEnabledcondition, andbuildResulthiding the section when every item is complete.Scope is deliberately limited to the one article that documents this section. No other
docs/articlesfile mentions theGetting startedchecklist.Fixed Issues
$
PROPOSAL:
Documentation follow-up requested on #99842. There is no separate help site issue, so the
$line is intentionally left blank.Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR only changes help site Markdown content.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.