Docs updates for E/A#99867 Default vendor rows for QBO and Xero - #100344
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#99867 Default vendor rows for QBO and Xero#100344MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Follow-up to #99867, which renamed Xero's Default supplier row to Default vendor, made the QBO Vendor bill Default vendor row always visible, and decoupled Auto-create entities from the default vendor selection. Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #99867, which aligned the QuickBooks Online and Xero Default vendor rows with the Sage Intacct pattern. Three user-visible changes landed there that the help site didn't reflect:
autoCreateVendor; it's now a plain row on the Export company card expenses as page.Files changed
docs/articles/Unlisted/Manage-Vendor-Matching-for-Xero.md(new) — documents the Xero Default vendor setting, the None option that clears it, and the fact that Xero applies no stand-in supplier when nothing is set (noCredit Card Miscequivalent). Placed inUnlisted/withnoindex/sitemap: falsebecause Xero vendor matching is still behind thevendorMatchingbeta — the same treatmentManage-Vendor-Matching-for-Intacct.mdgets. It also explains why the expense field reads Supplier while the workspace setting reads Default vendor, which is the most likely confusion the rename creates.docs/articles/new-expensify/connections/quickbooks-online/Configure-Quickbooks-Online.md— attaches Default vendor to both Credit card and Debit card (it was nested under Debit card only, implying it didn't apply to credit card); bolds Default vendor on the Vendor bill line to match the UI label and notes there's noCredit Card Miscfallback for vendor bills; corrects the Advanced toggle label from "Automatically create entities" to the actual UI label Auto-create entities and states it doesn't change the Default vendor; drops a stray.mdfrom a relative article link.docs/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online.md— fixes a stray period in the fallback-vendor list. Left otherwise untouched: itsinternalScopeis Credit card / Debit card exports, so the Vendor bill guidance went into the configuration article instead of widening this one.Not changed:
Configure-Xero.md. The Default vendor row is beta-gated, so it stays out of the public configuration article until the beta ships.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/664722
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
This is a docs-only change — no application code is touched, so there is nothing to exercise in the app. What needs verifying is that the copy matches the UI:
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".
Docs-only change to
docs/articles— nothing ships to the app. QA is a read-through of the rendered help site pages against the live UI labels.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
AI Tests
createDocsRoutesonly walksdocs/articles/{new-expensify,expensify-classic,travel}, so a new file underdocs/articles/Unlisted/produces no_routes.ymlchange — same as the existingManage-Vendor-Matching-for-Intacct.md, which has no route entry.lint,typecheck,jest, storybook): not applicable. No files outsidedocs/articleschanged.src/languages/en.tsand the page components rather than a running app.@Beamanator, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.