Skip to content

Docs updates for E/A#99867 Default vendor rows for QBO and Xero - #100344

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-99867-defaultVendor
Draft

Docs updates for E/A#99867 Default vendor rows for QBO and Xero#100344
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-99867-defaultVendor

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #99867, which aligned the QuickBooks Online and Xero Default vendor rows with the Sage Intacct pattern. Three user-visible changes landed there that the help site didn't reflect:

  1. Xero's row was renamed from "Default supplier" to "Default vendor" (and the picker header changed). No help article documented Xero's default-vendor setting under either name, so an admin searching the help site for it found nothing.
  2. The QuickBooks Online Vendor bill default vendor is now selected directly. It used to sit behind a toggle that also wrote autoCreateVendor; it's now a plain row on the Export company card expenses as page.
  3. Auto-create entities no longer rewrites the Default vendor. Toggling it on the QuickBooks Online Advanced page previously reset or auto-filled the default vendor. It no longer touches that setting.

Files changed

  • docs/articles/Unlisted/Manage-Vendor-Matching-for-Xero.md (new) — documents the Xero Default vendor setting, the None option that clears it, and the fact that Xero applies no stand-in supplier when nothing is set (no Credit Card Misc equivalent). Placed in Unlisted/ with noindex/sitemap: false because Xero vendor matching is still behind the vendorMatching beta — the same treatment Manage-Vendor-Matching-for-Intacct.md gets. It also explains why the expense field reads Supplier while the workspace setting reads Default vendor, which is the most likely confusion the rename creates.
  • docs/articles/new-expensify/connections/quickbooks-online/Configure-Quickbooks-Online.md — attaches Default vendor to both Credit card and Debit card (it was nested under Debit card only, implying it didn't apply to credit card); bolds Default vendor on the Vendor bill line to match the UI label and notes there's no Credit Card Misc fallback for vendor bills; corrects the Advanced toggle label from "Automatically create entities" to the actual UI label Auto-create entities and states it doesn't change the Default vendor; drops a stray .md from a relative article link.
  • docs/articles/new-expensify/connections/quickbooks-online/Manage-Vendor-Matching-for-QuickBooks-Online.md — fixes a stray period in the fallback-vendor list. Left otherwise untouched: its internalScope is Credit card / Debit card exports, so the Vendor bill guidance went into the configuration article instead of widening this one.

Not changed: Configure-Xero.md. The Default vendor row is beta-gated, so it stays out of the public configuration article until the beta ships.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/664722
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".

This is a docs-only change — no application code is touched, so there is nothing to exercise in the app. What needs verifying is that the copy matches the UI:

  1. On a workspace connected to Xero with vendor matching enabled, open Workspaces > [workspace name] > Accounting > Xero > Export and confirm the row reads Default vendor and sits under Xero bank account.
  2. Open that row and confirm the list includes None, and that selecting it clears the setting.
  3. On a workspace connected to QuickBooks Online, open Export, choose Vendor bill, and confirm Default vendor is selectable directly.
  4. On the QuickBooks Online Advanced page, confirm the toggle reads Auto-create entities and that toggling it leaves the Default vendor selection alone.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".

Docs-only change to docs/articles — nothing ships to the app. QA is a read-through of the rendered help site pages against the live UI labels.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

AI Tests

  • Docs routes: not required. createDocsRoutes only walks docs/articles/{new-expensify,expensify-classic,travel}, so a new file under docs/articles/Unlisted/ produces no _routes.yml change — same as the existing Manage-Vendor-Matching-for-Intacct.md, which has no route entry.
  • cspell: could not run in this environment. No new or unusual terms were introduced; every term used already appears in the sibling QuickBooks Online and Sage Intacct vendor-matching articles.
  • App test suites (lint, typecheck, jest, storybook): not applicable. No files outside docs/articles changed.
  • Live UI check: the workspace Accounting navigation labels were confirmed against dev NewDot on web. The QuickBooks Online and Xero Export configuration pages sit behind a real OAuth connection that the test account can't establish, so those labels were verified against src/languages/en.ts and the page components rather than a running app.

@Beamanator, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Follow-up to #99867, which renamed Xero's Default supplier row to Default vendor, made the QBO Vendor bill Default vendor row always visible, and decoupled Auto-create entities from the default vendor selection.

Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 3, 2026 19:14
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants