[HOLD Web-E #55633] Reconcile persisted Concierge drafts by action ID - #100420
Open
inimaga wants to merge 1 commit into
Open
[HOLD Web-E #55633] Reconcile persisted Concierge drafts by action ID#100420inimaga wants to merge 1 commit into
inimaga wants to merge 1 commit into
Conversation
melvin-bot
Bot
requested review from
rlinoz and
trjExpensify
and removed request for
a team
September 4, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Held on:
Deployment order: Auth #23974, Auth #24257, Web-Expensify #55633, then this PR. Keep this PR on hold until the server-side direct-delivery path is deployed.
Explanation of Change
This PR makes Concierge draft completion durable when the terminal Pusher event is missed. If the final report action arrives through normal Onyx report-action updates, the client now reconciles the pending draft by its reserved report-action ID even when the final HTML is byte-identical to the last streamed draft.
Reconciliation searches the complete cached action set instead of only the currently visible pagination chain, so deep-linked and unread-anchored views do not strand a completed draft. A same-ID action with
pendingAction: ADDis still an optimistic placeholder and is intentionally ignored until the server confirms it.Visible-list rendering and ordering are unchanged.
Fixed Issues
Related to https://github.com/Expensify/Expensify/issues/674683
Tests
npm test -- --runInBand --watchman=false tests/ui/ReportActionsListTest.tsx tests/unit/pages/inbox/ConciergeDraftContext.test.tsx— 41 passed.npm run lint-changed— passed under Node 26.5.0.npm run spell-changed— passed.npm run typecheck— passed.npm run react-compiler-compliance-check check-changed— passed with Babel and OXC.git diff --check origin/main...HEAD— passed.QA