Grey out report preview and IOU report's header when paying request offline by dukenv0307 · Pull Request #35456 · Expensify/App

dukenv0307 · 2024-01-31T08:00:06Z

Details

Grey out report preview and IOU report's header when paying request offline

Fixed Issues

$ #34819
PROPOSAL: #34819 (comment)

Tests

Precondition: As an employee of a workspace, create a request money in the workspace chat

Login as admin of the workspace
Go offline
Go to workspace chat above
Pay the request and verify that the report preview is grey out
Click on the report preview to open expense report
Verify that the header of report is also grey out

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Precondition: As an employee of a workspace, create a request money in the workspace chat

Login as admin of the workspace
Go offline
Go to workspace chat above
Pay the request and verify that the report preview is grey out
Click on the report preview to open expense report
Verify that the header of report is also grey out

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-31.at.14.58.22.mov

Android: mWeb Chrome

Screen.Recording.2024-01-31.at.14.52.22.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-01-31.at.14.42.26.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-31.at.14.38.41.mov

MacOS: Desktop

Screen.Recording.2024-01-31.at.15.03.57.mov

…ffline

melvin-bot · 2024-01-31T08:04:36Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jakub-trzebiatowski · 2024-01-31T10:46:02Z


 /**
- * Return the pendingAction and the errors we have when creating a chat or a workspace room offline
+ * Return the pendingAction and the errors we have when creating a chat or a workspace room offline or pay the request


/** * Return the pendingAction and the errors resulting from either... * * - creating a workspace room * - starting a chat * - paying the money request * * ...while being offline **/

I updated this comment.

jakub-trzebiatowski · 2024-01-31T10:46:04Z

 */
 function getReportOfflinePendingActionAndErrors(report: OnyxEntry<Report>): ReportOfflinePendingActionAndErrors {
-    // We are either adding a workspace room, or we're creating a chat, it isn't possible for both of these to be pending, or to have errors for the same report at the same time, so
+    // We are either adding a workspace room, or we're creating a chat, or we're paying request money, it isn't possible for both of these to be pending, or to have errors for the same report at the same time, so


// It shouldn't be possible for all of these actions to be pending (or to have errors) for the same report at the same time, so just take the first that exists

I just suggest to improve the language here. An important part is that you kept the word "both", while we add a third case. I suggest to drop the "both" and shorten the comment, making it more generic.

Another thing is whether this statement is actually true (especially, after our changes). To be honest, it isn't completely clear to me why these actions cannot be pending at the same time.

Same as above.

jakub-trzebiatowski · 2024-01-31T10:47:26Z

+    const addWorkspaceRoomOrChatPendingAction = report?.pendingFields?.addWorkspaceRoom ?? report?.pendingFields?.createChat ?? report?.pendingFields?.reimbursed;
+
    const addWorkspaceRoomOrChatErrors = getAddWorkspaceRoomOrChatReportErrors(report);
    return {addWorkspaceRoomOrChatPendingAction, addWorkspaceRoomOrChatErrors};


At least some of these names got outdated. Please figure this out.

Updated the name of the variable.

jakub-trzebiatowski · 2024-02-07T14:19:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

gray-out-iou-android-compressed.mp4

Android: mWeb Chrome

gray-out-iou-android-web-compressed.mp4

iOS: Native

gray-out-iou-ios-compressed.mp4

iOS: mWeb Safari

gray-out-iou-ios-web-compressed.mp4

MacOS: Chrome / Safari

gray-out-iou-web-converted.mp4

MacOS: Desktop

OSBotify · 2024-02-08T15:48:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-08T18:43:55Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.39-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-12T14:01:34Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

dukenv0307 · 2026-01-06T09:20:54Z

-    const addWorkspaceRoomOrChatErrors = getAddWorkspaceRoomOrChatReportErrors(report);
-    return {addWorkspaceRoomOrChatPendingAction, addWorkspaceRoomOrChatErrors};
+    // It shouldn't be possible for all of these actions to be pending (or to have errors) for the same report at the same time, so just take the first that exists
+    const reportPendingAction = report?.pendingFields?.addWorkspaceRoom ?? report?.pendingFields?.createChat ?? report?.pendingFields?.reimbursed;


Coming from #76323, we shouldn't grey out the entire report when reimbursed is pending update

grey out report preview and IOU report's header when paying request o…

c832f2c

…ffline

dukenv0307 marked this pull request as ready for review January 31, 2024 08:04

dukenv0307 requested a review from a team as a code owner January 31, 2024 08:04

melvin-bot Bot removed the request for review from a team January 31, 2024 08:04

melvin-bot Bot requested a review from jakub-trzebiatowski January 31, 2024 08:04

jakub-trzebiatowski suggested changes Jan 31, 2024

View reviewed changes

dukenv0307 added 2 commits February 6, 2024 21:19

Merge branch 'main' into fix/34819

bf9110e

rename variable and edit the comment

236b89d

jakub-trzebiatowski approved these changes Feb 7, 2024

View reviewed changes

melvin-bot Bot requested a review from iwiznia February 7, 2024 14:19

iwiznia approved these changes Feb 8, 2024

View reviewed changes

iwiznia merged commit ad3d78c into Expensify:main Feb 8, 2024

github-actions Bot mentioned this pull request Feb 8, 2024

Deploy Checklist: New Expensify 2024-02-08 #36168

Closed

77 tasks

melvin-bot Bot mentioned this pull request Feb 12, 2024

[HOLD for payment 2024-02-19] [$500] IOU - IOU Preview and header are not grayed out when pay IOU in offline mode #34819

Closed

6 tasks

nkdengineer mentioned this pull request Dec 1, 2025

[$250] Reports - Entire expense report is grayed out after paying expense offline on "Reports" #76323

Closed

8 tasks

dukenv0307 commented Jan 6, 2026

View reviewed changes

Conversation

dukenv0307 commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 31, 2024

Uh oh!

jakub-trzebiatowski Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski commented Feb 7, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Feb 8, 2024

Uh oh!

OSBotify commented Feb 8, 2024

Uh oh!

OSBotify commented Feb 12, 2024

Uh oh!

dukenv0307 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dukenv0307 commented Jan 31, 2024 •

edited

Loading

dukenv0307 Feb 6, 2024 •

edited

Loading