Fixed LHN Ordering by shubham1206agra · Pull Request #35907 · Expensify/App

shubham1206agra · 2024-02-06T14:45:41Z

Details

Fixed Issues

$ #33029
PROPOSAL: #33029 (comment)

Tests

Open app
Open report
Write a message
See if LHN ordering is correct (chat with the draft is ordered correctly)
Change the language and repeat the steps
Verify that the ordering matches too (use pinned, drafts, archived, RBR / GBR)

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-28.at.1.52.56.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-28.at.12.24.46.PM.mov

iOS: Native

Screen.Recording.2024-02-28.at.1.37.35.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-28.at.12.09.16.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-28.at.11.38.22.AM.mp4

MacOS: Desktop

Screen.Recording.2024-02-28.at.12.49.06.PM.mov

shubham1206agra · 2024-02-06T15:50:59Z

We may need to create a perf test to know the actual performance hit.

luacmartins

@shubham1206agra it seems like we're not sorting the reports here and also not taking into account the performance suggestions we raised during discussion. Are you still working on this POC?

shubham1206agra · 2024-02-08T14:18:36Z

@luacmartins We are sorting the reports already. I need to write a test here to measure performance. I will write the suggestion in a commit later.

luacmartins · 2024-02-09T14:24:00Z

@fedirjh were you able to take a look at this PR?

fedirjh · 2024-02-09T21:48:55Z

@shubham1206agra It seems that this PR is still in progress? Could you please include the performance improvements discussed in the linked issue? Specifically this one #33029 (comment)

youssef-lr · 2024-02-09T22:30:07Z

We are sorting the reports already.

Yes but not alphanumerically, channels room names can include # for example and that messes up the order. You mentioned in your proposal this which I think should be included in the PR:

For this we need to use the replace replace(/[^0-9a-z]/gi, '') to remove non-alphanumeric characters.

Let's also include this optimisation in SidebarLinksData. I'm not sure if we need to write a test for this though, shouldn't reassure fail if this is affects performance badly?

shubham1206agra · 2024-02-19T10:01:47Z

@fedirjh Can you test this PR on HT account and see if anything is out of order?
cc @youssef-lr

This reverts commit 6b19fd2.

shubham1206agra · 2024-02-19T16:37:44Z

@fedirjh I think we are checking error on too many reports. Let me redo this in another way, and see if there are still performance regressions.

fedirjh · 2024-02-19T16:39:56Z

I think we are checking error on too many reports.

What do you mean ?

Let me redo this in another way, and see if there are still performance regressions.

@shubham1206agra Do we have any performance regression?

shubham1206agra · 2024-02-19T16:41:37Z

[ReportScreen] should press of the report item [render]: 133.3 ms → 205.1 ms (+71.8 ms, +53.9%) 🔴🔴 | 4 → 4
[ReportScreen] should render ReportScreen with composer interactions [render]: 148.7 ms → 219.5 ms (+70.8 ms, +47.6%) 🔴🔴 | 6 → 6

fedirjh · 2024-02-19T16:44:03Z

@shubham1206agra Could you please also update the test ? I don't think we are getting the correct results for this test :

[SidebarUtils] getOrderedReportIDs on 1k reports

youssef-lr · 2024-02-19T20:18:22Z

            preferredLocale: preferredLocale ?? CONST.LOCALES.DEFAULT,
            policy,
            parentReportAction,
+            reportErrors,


This is not added to the dependencies of useMemo

reportErrors seems to be an object, if we add it as dependency we should memoize it also on the parent component

parent:

const reportErrors = useMemo(() => reportIDsWithErrors[reportID] ?? {}, [reportID]);

and not sure about reportIDsWithErrors
cc: @youssef-lr

youssef-lr · 2024-02-28T05:21:56Z

+            (errorsMap, reportKey) => {
+                const report = chatReports[reportKey];
+                const allReportsActions = allReportActions[reportKey.replace(ONYXKEYS.COLLECTION.REPORT, ONYXKEYS.COLLECTION.REPORT_ACTIONS)];
+                const errors = OptionsListUtils.getAllReportErrors(report, allReportsActions) || {};


I think we should pass the violations to getAllReportErrors and add them to the dependencies of the memo. If we don't, this function will not be re-triggered if a violation changes in Onyx.

It should re-render as transactionViolations changes, which is a dependency of memo.

But it is not a dependency of reportIDsWithErrors here, which means we won't re-run getAllReportErrors

@youssef-lr I think this is not needed. We are already subscribing to the violation collection, and it should re-render whenever any of the violations are updated.

While yes the page will re-render, the reportIDsWithErrors will remain unchanged, as it only listens to changes in report actions and chat reports.

@shubham1206agra bump, can we pass the transactions to getAllReportErrors?

Apologies for the confusion, @fedirjh I disagree. Prior to the PR we weren’t pinning RBR reports, now that we’re memoized them, they are not subscribing to changes in the transaction.

@shubham1206agra @fedirjh what's the latest here?

We are awaiting @shubham1206agra to implement the changes.

@fedirjh Can you retest this now?

youssef-lr

Let's add ~~violations~~ transactions to getAllReportErrors as param and memoize them.

shubham1206agra · 2024-02-28T05:44:20Z

Screen.Recording.2024-02-28.at.11.13.31.AM.mov

@youssef-lr Please check this video.

melvin-bot · 2024-02-28T06:16:37Z

@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2024-02-28T06:57:40Z

    const isInDefaultMode = !isInGSDMode;
    const allReportsDictValues = Object.values(allReports);

+    const reportIDsWithViolations = new Set<string>();


Couldn't this be moved to SidebarLinksData.js similar to reportIDsWithErrors ? I think this will give some perf boost?

Nope. It didn't give any.

fedirjh

Looks good to me.

danieldoglas · 2024-02-28T11:08:52Z

Removing myself since I'm not part of the original issue. Not sure why pullerbear added me.

youssef-lr · 2024-02-28T19:14:38Z

Removing myself since I'm not part of the original issue. Not sure why pullerbear added me.

It seems like it always add an extra reviewer once PR is no longer a draft.

luacmartins

Looking good. Just this open request from @youssef-lr

youssef-lr

LGTM!

Changes requested have been applied and Carlos already approved.

OSBotify · 2024-03-04T13:53:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:02:44Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:51:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra added 2 commits February 6, 2024 20:14

Test LHN fix

9b040c5

revert unintentional change

6333dcd

shubham1206agra mentioned this pull request Feb 6, 2024

test lhn sidebar #35817

Closed

50 tasks

luacmartins requested review from fedirjh and luacmartins February 6, 2024 15:35

luacmartins previously requested changes Feb 8, 2024

View reviewed changes

shubham1206agra and others added 5 commits February 17, 2024 09:14

Merge branch 'main' into test-lhn-fix

87826ab

Optimization attempt 1

06f5775

Fixed perf test

f556253

Fixed display name filter

f8ab7cc

Added violation for RBR in sorting

90343b9

shubham1206agra added 2 commits February 19, 2024 18:03

Optimization attempt 2

6b19fd2

Revert "Optimization attempt 2"

c61adb1

This reverts commit 6b19fd2.

shubham1206agra mentioned this pull request Feb 19, 2024

[Audit][Implementation] getOrderedReportIDs - cache removal #36565

Merged

48 tasks

Merge branch 'Expensify:main' into test-lhn-fix

cf3147f

fedirjh reviewed Feb 19, 2024

View reviewed changes

Comment thread src/pages/home/sidebar/SidebarLinksData.js Outdated

Comment thread src/pages/home/sidebar/SidebarLinksData.js Outdated

Comment thread tests/perf-test/SidebarUtils.perf-test.ts

Comment thread src/libs/SidebarUtils.ts

Minor fixes

6649bb9

youssef-lr reviewed Feb 19, 2024

View reviewed changes

Comment thread src/components/LHNOptionsList/LHNOptionsList.tsx Outdated

youssef-lr reviewed Feb 19, 2024

View reviewed changes

Comment thread src/components/LHNOptionsList/LHNOptionsList.tsx Outdated

youssef-lr reviewed Feb 28, 2024

View reviewed changes

youssef-lr requested changes Feb 28, 2024

View reviewed changes

Fixed violation to be used properly for all permissions users

29216c2

shubham1206agra marked this pull request as ready for review February 28, 2024 06:16

shubham1206agra requested a review from a team as a code owner February 28, 2024 06:16

melvin-bot bot requested review from danieldoglas and removed request for a team February 28, 2024 06:16

fedirjh reviewed Feb 28, 2024

View reviewed changes

fedirjh approved these changes Feb 28, 2024

View reviewed changes

shubham1206agra requested a review from youssef-lr February 28, 2024 08:12

danieldoglas removed their request for review February 28, 2024 11:08

luacmartins reviewed Feb 28, 2024

View reviewed changes

shubham1206agra and others added 2 commits March 4, 2024 07:52

Merge branch 'Expensify:main' into test-lhn-fix

888195b

Added transaction as dependency

f14090e

youssef-lr approved these changes Mar 4, 2024

View reviewed changes

youssef-lr merged commit a662e5c into Expensify:main Mar 4, 2024

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

melvin-bot bot mentioned this pull request Mar 6, 2024

HIGH: [Polish] [$500] Finalize order of LHN in #focus mode #33029

Closed

shubham1206agra mentioned this pull request Mar 12, 2024

[NoQA] Revert lhn order #38081

Merged

50 tasks

luacmartins mentioned this pull request Mar 13, 2024

Expense - Transaction thread with violation does not appear in LHN #37405

Closed

6 tasks

shubham1206agra mentioned this pull request Mar 21, 2024

fix: An extra space is created at the top of the chat list when pin and unpin #38656

Merged

50 tasks

shubham1206agra deleted the test-lhn-fix branch February 3, 2025 17:47

Conversation

shubham1206agra commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

shubham1206agra commented Feb 6, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Feb 8, 2024

Uh oh!

luacmartins commented Feb 9, 2024

Uh oh!

fedirjh commented Feb 9, 2024

Uh oh!

youssef-lr commented Feb 9, 2024

Uh oh!

shubham1206agra commented Feb 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shubham1206agra commented Feb 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fedirjh commented Feb 19, 2024

Uh oh!

shubham1206agra commented Feb 19, 2024

Uh oh!

fedirjh commented Feb 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youssef-lr Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youssef-lr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Feb 28, 2024

Uh oh!

melvin-bot bot commented Feb 28, 2024

Uh oh!

fedirjh Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Feb 6, 2024 •

edited

Loading

shubham1206agra commented Feb 19, 2024 •

edited

Loading

shubham1206agra commented Feb 19, 2024 •

edited

Loading

youssef-lr Feb 28, 2024 •

edited

Loading

youssef-lr left a comment •

edited

Loading

fedirjh Feb 28, 2024 •

edited

Loading