Enable copy action for travel details by gijoe0295 · Pull Request #58246 · Expensify/App

gijoe0295 · 2025-03-11T18:45:59Z

Explanation of Change

Enable copy feature for travel details:

Confirmation number in car details
Flight code & Confirmation number in flight details
Address & Confirmation number in hotel details
Train code & Confirmation number in train details

Update context menu popover's min-width to prevent it from resizing when content changes

Fixed Issues

$ #57800
PROPOSAL: #57800 (comment)

Tests

Open a trip room
Open hotel trip details
Long press/Right click (Mobile/Desktop) the address field
Verify context menu with Copy to clipboard item shows
Press Copy to clipboard
Verify the address value is copied to clipboard

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Open a trip room
Open hotel trip details
Long press/Right click (Mobile/Desktop) the address field
Verify context menu with Copy to clipboard item shows
Press Copy to clipboard
Verify the address value is copied to clipboard

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-03-12.at.02.11.01.mov

iOS: Native

Screen.Recording.2025-03-12.at.02.06.55.mov

iOS: mWeb Safari

Screen.Recording.2025-03-12.at.02.08.29.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-13.at.00.02.16.mov

MacOS: Desktop

Screen.Recording.2025-03-13.at.00.07.12.mov

melvin-bot · 2025-03-11T19:11:34Z

@dannymcclain @ntdiary One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2025-03-11T19:35:17Z

I think the videos are looking pretty good, but I'm having a hard time seeing the whole flow because the videos are pretty tightly cropped (time-wise). Would you mind uploading videos that show the entire flow more easily?

Some of these desktop options are looking pretty narrow - @Expensify/design do we have a minimum width we usually set for these? Lastly, we definitely don't want the menu item to change width once it changes from "Copy to clipboard" to "Copied".

gijoe0295 · 2025-03-12T00:34:44Z

Video for full flow:

Screen.Recording.2025-03-12.at.07.22.03-recording.mov

gijoe0295 · 2025-03-12T00:36:50Z

Lastly, we definitely don't want the menu item to change width once it changes from "Copy to clipboard" to "Copied".

@ntdiary Do you have any hint about retaining popover width even when the inner content changes? For report action context menu, because there're other menu items with larger width, when Copy to clipboard changes to Copied, popover width does not change. But in this case, we only have Copy to clipboard item.

dubielzyk-expensify · 2025-03-12T04:14:37Z

Some of these desktop options are looking pretty narrow - @Expensify/design do we have a minimum width we usually set for these? Lastly, we definitely don't want the menu item to change width once it changes from "Copy to clipboard" to "Copied".

Totally agree that we should have a min-width. When I made the component, the smallest one I found was 335px so maybe that? @shawnborton has a better idea maybe?

shawnborton · 2025-03-12T08:39:41Z

I don't know that we've established one - so I say let's make a new rule! What if we do something like 340px since it's divisible by 4? :)

But I definitely agree that having a min-width here would be nice to avoid the size jumping.

ntdiary · 2025-03-12T09:21:43Z

I don't know that we've established one - so I say let's make a new rule! What if we do something like 340px since it's divisible by 4? :)

But I definitely agree that having a min-width here would be nice to avoid the size jumping.

take some screenshots. BTW, we have a max-width 375 here :D

main branch (309.24px)	320px	340px

shawnborton · 2025-03-12T10:13:06Z

320px feels nice to me there, curious what Danny and Jon think too!

dannymcclain · 2025-03-12T13:35:48Z

320 as the min-width feels good to me too 👍

gijoe0295 · 2025-03-12T17:03:58Z

Updated the min-width to maintain popover size:

Screen.Recording.2025-03-13.at.00.02.16.mov

cc @Expensify/design

shawnborton · 2025-03-12T17:05:02Z

Love it!

dannymcclain · 2025-03-12T17:16:01Z

Lovely—looking good! Thank you!

dubielzyk-expensify · 2025-03-13T02:01:37Z

Looks good to me!

ntdiary · 2025-03-14T07:23:22Z

Hi, @gijoe0295, have you pushed the min-width commit? :)

gijoe0295 · 2025-03-14T07:39:04Z

@ntdiary Oops completely missed that 🙏 I just pushed it.

ntdiary · 2025-03-14T14:56:10Z

                    </Text>
                }
                interactive={false}
-                helperText={reservation.start.location}


@gijoe0295, is this intentionally removed?

Thanks for pointing this out. This was a mistake.

ntdiary · 2025-03-17T02:30:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

58246-android-native.mov

Android: mWeb Chrome

58246-android-web.mov

iOS: Native

58246-ios-native.mov

iOS: mWeb Safari

58246-ios-safari.mov

MacOS: Chrome / Safari

58246-mac-chrome.mov

MacOS: Desktop

58246-mac-desktop.mov

ntdiary

Explanation of Change

Enable copy feature for travel details:

Confirmation number in car details

Flight code & Confirmation number in flight details

Address & Confirmation number in hotel details

Train code & Confirmation number in train details

The rows with copy feature enabled are already listed in the OP, and so far, works well. :)

ntdiary · 2025-03-17T05:22:53Z

+            return;
+        }
+        showContextMenu(CONST.CONTEXT_MENU_TYPES.TEXT, event, copyValue, popoverAnchor.current);
+        onSecondaryInteraction?.(event);


Not a blocker, just a simple thought, maybe enabling the copy function would mean no other secondary interaction would happen. :)

Hmm I think there might be cases where we still need it but I'm not sure.

gijoe0295 · 2025-03-20T20:02:29Z

Also I'm not sure why bot didn't assign an internal engineer to review.

ntdiary · 2025-03-21T05:28:48Z

Also I'm not sure why bot didn't assign an internal engineer to review.

Eh, cc @blimpich for review. 😂

blimpich

LGTM

OSBotify · 2025-03-21T20:27:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-21T22:44:19Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-24T21:14:48Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.17-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

gijoe0295 added 6 commits March 12, 2025 01:35

enable copy action for travel details

333043f

enable copy action for car trip details

71fafa4

enable copy action for car trip details

2059203

enable copy action for flight trip details

0359cc1

enable copy action for train trip details

c612dab

remove redundant change

6c4ddf0

gijoe0295 marked this pull request as ready for review March 11, 2025 19:11

gijoe0295 requested a review from a team as a code owner March 11, 2025 19:11

melvin-bot Bot requested review from dannymcclain and ntdiary and removed request for a team March 11, 2025 19:11

dannymcclain mentioned this pull request Mar 12, 2025

Show reportID in report details panel #57942

Merged

50 tasks

update report action context menu popover min-width

65f7958

gijoe0295 requested a review from a team as a code owner March 14, 2025 07:38

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/57800

124f63a

ntdiary reviewed Mar 14, 2025

View reviewed changes

revert mistaken changes

9e3a3b9

ntdiary approved these changes Mar 17, 2025

View reviewed changes

gijoe0295 added 2 commits March 21, 2025 02:57

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/57800

0437478

update new function signature

0edbaa1

blimpich self-requested a review March 21, 2025 17:12

blimpich assigned gijoe0295 Mar 21, 2025

blimpich approved these changes Mar 21, 2025

View reviewed changes

blimpich merged commit 9963c3f into Expensify:main Mar 21, 2025

github-actions Bot mentioned this pull request Mar 21, 2025

Deploy Checklist: New Expensify 2025-03-21 #58928

Closed

65 tasks

daledah mentioned this pull request Mar 22, 2025

Web - LHN - LHN context menu has too much extra space #58937

Closed

8 tasks

melvin-bot Bot mentioned this pull request Mar 24, 2025

[Due for payment 2025-03-31] [$250] Enable copy action on mobile for select travel details (minimally address and confirmation number) #57800

Closed

Conversation

gijoe0295 commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 11, 2025

Uh oh!

dannymcclain commented Mar 11, 2025

Uh oh!

gijoe0295 commented Mar 12, 2025

Uh oh!

gijoe0295 commented Mar 12, 2025

Uh oh!

dubielzyk-expensify commented Mar 12, 2025

Uh oh!

shawnborton commented Mar 12, 2025

Uh oh!

ntdiary commented Mar 12, 2025

Uh oh!

shawnborton commented Mar 12, 2025

Uh oh!

dannymcclain commented Mar 12, 2025

Uh oh!

gijoe0295 commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Mar 12, 2025

Uh oh!

dannymcclain commented Mar 12, 2025

Uh oh!

dubielzyk-expensify commented Mar 13, 2025

Uh oh!

ntdiary commented Mar 14, 2025

Uh oh!

gijoe0295 commented Mar 14, 2025

Uh oh!

ntdiary Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Mar 15, 2025

Choose a reason for hiding this comment

Uh oh!

ntdiary commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ntdiary left a comment

Choose a reason for hiding this comment

Explanation of Change

Uh oh!

ntdiary Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

gijoe0295 commented Mar 20, 2025

Uh oh!

ntdiary commented Mar 21, 2025

Uh oh!

blimpich left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 21, 2025

Uh oh!

github-actions Bot commented Mar 21, 2025

Uh oh!

github-actions Bot commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

gijoe0295 commented Mar 11, 2025 •

edited

Loading

gijoe0295 commented Mar 12, 2025 •

edited

Loading

ntdiary commented Mar 17, 2025 •

edited

Loading