Show reportID in report details panel by mkzie2 · Pull Request #57942 · Expensify/App

mkzie2 · 2025-03-06T16:47:25Z

Explanation of Change

Fixed Issues

$ #57722
PROPOSAL: #57722 (comment)

Tests

Open any report (except for DM, Concierge reports)
Press report header
Verify report ID & long ID information displays at the bottom of the report details page
Right click/long press the report ID
Verify the report ID value is copied to clipboard
Right click/long press the long ID
Verify the long ID value is copied to clipboard

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Open any report (except for DM, Concierge reports)
Press report header
Verify report ID & long ID information displays at the bottom of the report details page
Right click/long press the report ID
Verify the report ID value is copied to clipboard
Right click/long press the long ID
Verify the long ID value is copied to clipboard

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-26.at.14.29.42.mov

Android: mWeb Chrome

Screen.Recording.2025-03-31.at.18.36.04.mov

iOS: Native

Screen.Recording.2025-03-31.at.18.33.46.mov

iOS: mWeb Safari

Screen.Recording.2025-03-31.at.18.34.21.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-31.at.18.32.56.mov

MacOS: Desktop

Screen.Recording.2025-03-31.at.18.32.31.mov

…e/57722

melvin-bot · 2025-03-10T11:44:53Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

QichenZhu · 2025-03-10T12:32:12Z

        filterLogs: 'Registros de filtrado',
        network: 'La red',
        reportID: 'ID del informe',
+        longID: 'ID largo',


Is the translation confirmed? Do you need me to post a message in the Slack channel?

That would be great as I haven't had access to Slack yet. Thank you.

QichenZhu · 2025-03-11T00:43:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
Not added, as this only implements visual elements and straightforward logic.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mov

…e/57722

mkzie2 · 2025-03-11T17:46:53Z

I personally think it's useful to support long press, but if it's not easy to fix, could we get rid of it, as the design team mentioned #57722 (comment)?

Just updated.

~~> Bug: Touch to Search popup appears in Android Chrome.~~

~~I don't think it's a bug. It's a native feature in Android that shows whenever a value is copied to clipboard.~~

mkzie2 · 2025-03-11T17:55:56Z

Bug: Touch to Search popup appears in Android Chrome.

Fixed this by disabling text selection on mobile chrome.

QichenZhu · 2025-03-12T04:05:37Z

Thanks for the updates.

QichenZhu · 2025-03-12T04:06:30Z

I’m seeing different feedback after a tap/click across platforms:

1. On android, a popup appears with the copied text.

2. In the iOS app, the text changes to a gray background.

3. In the iOS browser and on desktop, there’s no feedback.

We’re not intentionally introducing these behaviors, and I’m not sure if it’s technically possible to make them consistent across platforms.

I’d like to check with @Expensify/design to see if any of these feedback types look problematic.

dubielzyk-expensify · 2025-03-12T04:25:37Z

We’re not intentionally introducing these behaviors, and I’m not sure if it’s technically possible to make them consistent across platforms.

I’d like to check with @Expensify/design to see if any of these feedback types look problematic.

I believe these are platforms specific behaviors and we shouldn't mess with them. As long as the text is copied, I think that's fine.

Can we confirm that on iOS browser and on desktop that the text is indeed copied?

mkzie2 · 2025-03-12T04:40:27Z

I believe these are platforms specific behaviors and we shouldn't mess with them

Yeah I also agree with this point. I think there's not so much we can do about it.

QichenZhu · 2025-03-12T04:44:35Z

I believe these are platforms specific behaviors and we shouldn't mess with them. As long as the text is copied, I think that's fine.

Thanks for your insight!

Can we confirm that on iOS browser and on desktop that the text is indeed copied?

Yes, it is. Verified by pasting elsewhere.

dubielzyk-expensify · 2025-03-12T05:20:30Z

Thanks for confirming.

cc @Expensify/design for visibility. Otherwise I say we move on 👍

QichenZhu · 2025-03-12T06:19:57Z

+import type {TextProps} from './Text';
+
+type TextWithCopyProps = TextProps & {
+    copyText: string;


Just a few suggestions to meet the coding standards:

Add a /** block comment */ above the copyText prop.

Add a comment to describe what TextWithCopy does, given that we already have CopyTextToClipboard and PressableWithDelayToggle.

Add a comment to explain why we disable selection in Android Chrome.

Remove textRef if it’s not used. We can add it back if needed in the future.

Don't write getBase62ReportID(Number(report.reportID)) and [styles.flexRow, styles.alignItemsCenter] more than once.

Let me know if you disagree. Thanks for your effort on this, @mkzie2!

shawnborton · 2025-03-12T09:52:02Z

I believe these are platforms specific behaviors and we shouldn't mess with them. As long as the text is copied, I think that's fine.

Agree with that!

dannymcclain · 2025-03-12T13:42:28Z

I agree as well! Let's keep movin'

dannymcclain · 2025-03-12T13:45:26Z

@Expensify/design 🫣 don't murder me here, but since there is absolutely zero indication of any interaction here... Do you all think it would be better to open a popover with a Copy to clipboard item when you tap on one of these report IDs? Kinda similar to what we're doing with the travel rows? Or do you think this is such a small/technical use case that it's fine as is?

QichenZhu · 2025-03-27T02:41:00Z

Alright, we can handle that separately then...

Thank you! Reported in Slack: Context menu slides in from edge of window

…e/57722

mkzie2 · 2025-03-27T16:03:34Z

Updated to not show the pointer cursor:

Screen.Recording.2025-03-27.at.23.02.37.mov

shawnborton · 2025-03-27T16:08:20Z

Looks good to me 👍

dannymcclain · 2025-03-27T16:39:35Z

Same 👍

dubielzyk-expensify · 2025-03-28T01:17:57Z

Me three 👍

QichenZhu · 2025-03-28T13:09:41Z

+    const popoverAnchor = useRef<View>(null);
+    const styles = useThemeStyles();
+
+    const toggleCopyContextMenu = (event: GestureResponderEvent | MouseEvent) => {


The word "toggle" is misleading. Please rename the function to reflect its actual behavior.

Excerpt from PR Author Checklist:

I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).

I think toggle here is fine. But I updated it to open anyway.

QichenZhu · 2025-03-28T13:16:11Z

@mkzie2 Could you please change "press" to "right click or long press" in the test steps and re-upload the broken videos/screenshots? Thanks!

…e/57722

mkzie2 · 2025-03-31T11:36:45Z

@mkzie2 Could you please change "press" to "right click or long press" in the test steps and re-upload the broken videos/screenshots? Thanks!

Updated

QichenZhu · 2025-03-31T11:46:15Z

@mkzie2 Could you please change "press" to "right click or long press" in the test steps and re-upload the broken videos/screenshots? Thanks!

Updated

Thanks for the update, but the QA steps are still not quite right.

Press the long ID

Right click/long press the long ID value is copied to clipboard

mkzie2 · 2025-03-31T11:47:33Z

Oops I'm sorry 🙇 Updated

QichenZhu

LGTM!

QichenZhu · 2025-03-31T12:40:37Z

@rafecolton Could you or someone from the team verify the Spanish translation? Thanks!

rafecolton

LGTM. Asked here (internal only) for confirmation on the translation, will merge once received

rafecolton · 2025-04-03T17:11:56Z

Translation confirmed

OSBotify · 2025-04-03T17:20:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:07:49Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:13:05Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:31:26Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

rayane-d · 2025-05-21T19:19:15Z

Coming from issue #60668 where the expense report identification footer is displayed in the details pane of a group chat, we decided that these numbers should only be shown on expense and invoice reports.

mkzie2 added 5 commits March 5, 2025 21:36

add reportID infor in the report detail page

5ed3510

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

8e99f9c

…e/57722

fix lint

329d3d3

make pressing report id title copiable

77670ce

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

6336cd0

…e/57722

mkzie2 marked this pull request as ready for review March 10, 2025 11:44

mkzie2 requested a review from a team as a code owner March 10, 2025 11:44

melvin-bot Bot requested review from QichenZhu and removed request for a team March 10, 2025 11:44

fix skew content in report details page

dcb7205

QichenZhu reviewed Mar 10, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

mkzie2 added 2 commits March 12, 2025 00:42

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

92edc97

…e/57722

disable long press to copy

5390816

disable text selection on mobile chrome

bf3553c

QichenZhu reviewed Mar 12, 2025

View reviewed changes

mkzie2 added 2 commits March 27, 2025 23:00

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

00ceaea

…e/57722

not show pointer cursor

1388269

QichenZhu mentioned this pull request Mar 27, 2025

[$250] Context menu slides in from edge of window #59216

Closed

8 tasks

QichenZhu reviewed Mar 28, 2025

View reviewed changes

mkzie2 added 2 commits March 31, 2025 18:28

Merge branch 'main' of https://github.com/mkzie2/App into mkzie2-issu…

c0cffd5

…e/57722

modify function name

90757e7

QichenZhu approved these changes Mar 31, 2025

View reviewed changes

melvin-bot Bot requested a review from rafecolton March 31, 2025 12:38

rafecolton assigned mkzie2 Apr 2, 2025

rafecolton approved these changes Apr 2, 2025

View reviewed changes

rafecolton merged commit 3876ad7 into Expensify:main Apr 3, 2025
19 of 20 checks passed

github-actions Bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot Bot mentioned this pull request Apr 9, 2025

[Due for payment 2025-04-16] [$250] Show reportID in report details panel #57722

Closed

8 tasks

rayane-d mentioned this pull request May 21, 2025

[Due for payment 2025-05-22] [$250] Expense Report Identification Footer Displaying Incorrectly in Group Chat Details Panel #60668

Closed

18 tasks

Conversation

mkzie2 commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 10, 2025

Uh oh!

QichenZhu Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

mkzie2 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

mkzie2 commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Mar 11, 2025

Uh oh!

QichenZhu commented Mar 12, 2025

Uh oh!

QichenZhu commented Mar 12, 2025

Uh oh!

dubielzyk-expensify commented Mar 12, 2025

Uh oh!

mkzie2 commented Mar 12, 2025

Uh oh!

QichenZhu commented Mar 12, 2025

Uh oh!

dubielzyk-expensify commented Mar 12, 2025

Uh oh!

QichenZhu Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Mar 12, 2025

Uh oh!

dannymcclain commented Mar 12, 2025

Uh oh!

dannymcclain commented Mar 12, 2025

Uh oh!

QichenZhu commented Mar 27, 2025

Uh oh!

mkzie2 commented Mar 27, 2025

Uh oh!

shawnborton commented Mar 27, 2025

Uh oh!

dannymcclain commented Mar 27, 2025

Uh oh!

dubielzyk-expensify commented Mar 28, 2025

Uh oh!

QichenZhu Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkzie2 Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Mar 31, 2025

Uh oh!

QichenZhu commented Mar 31, 2025

Uh oh!

mkzie2 commented Mar 31, 2025

Uh oh!

QichenZhu left a comment

mkzie2 commented Mar 6, 2025 •

edited

Loading

QichenZhu commented Mar 11, 2025 •

edited

Loading

mkzie2 commented Mar 11, 2025 •

edited

Loading

QichenZhu Mar 28, 2025 •

edited

Loading

mkzie2 Mar 31, 2025 •

edited

Loading

QichenZhu commented Mar 28, 2025 •

edited

Loading