Fix - [Better Expense Report View] Use aspect-ratio for receipt thumbnail area of expense previews

[FitseTLT]

Details

Fixed Issues

$ #59555
PROPOSAL: #59555 (comment)

Tests

Precondition: TableReportView beta should be enabled

1. Create a receipt expense
2. Check that the receipt preview appear with the same aspect ratio (width to height ratio) in all screen sizes and it doesn't appear to be taller/skinnier in small screens compared to large screen devices.

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@shawnborton @ntdiary One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

[ntdiary]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

59944-android-native.mov

Android: mWeb Chrome

59944-android-web.mov

iOS: Native

59944-ios-native.mov

iOS: mWeb Safari

59944-ios-safari.mov

MacOS: Chrome / Safari

59944-mac-chrome.mov

MacOS: Desktop

59944-mac-desktop.mov

[dubielzyk-expensify]

The corner radius don't match up here. I believe it's 16 on the outer and 12px on the receipt image. Can we confirm that's the case?

[dubielzyk-expensify]

I can't use the test build as I'm getting some weird SMS magic code stuff?

[ntdiary]

The corner radius don't match up here. I believe it's 16 on the outer and 12px on the receipt image. Can we confirm that's the case?

@dubielzyk-expensify, interesting. This only happens in the empty state expense. Its previous height was 180, and the borderRadius was 16. However, since its height was greater than its ancestor element’s height (160), the effective borderRadius was actually 12 from the ancestor element. But in this PR, since we used 100% height, it unexpectedly made the borderRadius 16 take effect. 😂

cc @FitseTLT

[dubielzyk-expensify]

Thanks for the explainer. I only understood some of it, but is it safe to assume it's fixed? 😄

[shawnborton]

Having a tough time logging into the adhoc build on web. Mobile iOS seems pretty good to me though

[mountiny]

Seems like we gotta fix it for the empty state @FitseTLT

[FitseTLT]

Yep fixed here is how it looks now

[shawnborton]

Should we pull main and see if we can get successful adhoc builds for web? That would be great for the design team!

[FitseTLT]

I have already pulled main 👍

[github-actions]

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59944-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59944-hybrid/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59944/NewExpensify.dmg	https://59944.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Dang, still can't get this to load for me on web. We're discussing internally here.

[mountiny]

@shawnborton you should be able to sign in now

[shawnborton]

Weird, this is causing a thin line at the bottom of the receipt wrapper for me:

[dannymcclain]

I'm seeing that too—but only for eReceipts and only in the preview component.

[ntdiary]

But I don't see it when the expense report preview has multiple expenses... hmmm any ideas?

Weird, this isn’t a simple border css property, will also investigate it further tomorrow. 🤔

[ntdiary]

We’re likely running into a rendering bug in Chrome — it looks much better in Firefox and Safari. 😅

Chrome	Firefox	Safari

The eReceipt styles are quite complex, that thin line is actually the background color of eReceipt.
While it seems to be related to the container height, we’re not yet sure which underlying properties are truly affecting the rendering. It’ll take more time to investigate.

For two expenses, the thin line appears when the container height is less than 165 (you can even see that the thin line on the right expense disappears once the left expense’s height is set to 165, even though the right one is still 164.81):

two-expenses.mov

For single expense, it shows up when the height includes a decimal.

single-expense.mov

[shawnborton]

Good sleuthing!

This is a bit of a hack, but if we use a value like 16 / 8.956 for the aspect ratio, we actually get a pretty clean 164px height on the preview containers on desktop... thoughts?

[mountiny]

I guess that works if we leave a clear comment in the code

[FitseTLT]

@ntdiary How can I debug? Is there any way a contributor can have access for EReceipts? cc @mountiny

[ntdiary]

@ntdiary How can I debug? Is there any way a contributor can have access for EReceipts? cc @mountiny

@FitseTLT, you can select a transaction, and then use mock data (replace the transaction ID). BTW, I'm looking into how the preview width is being set dynamically — if it can be arbitrary, then the height might still end up with decimals.

Onyx.merge('transactions_1354754709431046803', { cardID: 21184324, bank: 'Expensify Card', cardName: 'Expensify Card - 0687', cardNumber: '455594XXXXXX0687', hasEReceipt: true, managedCard: true, mccGroup: 'Services', comment: { liabilityType: 'personal'}})

unbelievable, I just noticed the Chats page, and the thin line is completely gone there, even though the height is still 164.812. 😅

If possible, I plan to look into this issue more deeply over the weekend. :D

[ntdiary]

Update

I asked ChatGPT and got a solution to use transform: translateZ(0);. It does work, but it's a bit late now and I haven't had time to check if there are any downsides. 😴

code:

result:

GPT:

[ntdiary]

OK, I suggest using translateZ(0) to fix this thin line issue — it doesn’t affect any existing styles, allows us to keep the 16:9 aspect ratio, and works well even when the width/height changes dynamically. Additionally, we need to create platform-specific files though, since translateZ isn’t supported on native platforms.

dynamic-height.mov

Here’s the code I tested (EReceiptWithSizeCalculation.tsx):

             <View
                 onLayout={onLayout}
-                style={[styles.w100, styles.h100, {transform: `scale(${scaleFactor})`, transformOrigin: 'top left'}]}
+                style={[styles.w100, styles.h100, {transform: `scale(${scaleFactor}) ${ignoreLine}`, transformOrigin: 'top left'}]}
             >
                 <EReceipt
                     // eslint-disable-next-line react/jsx-props-no-spreading

the style can be applied in either EReceiptWithSizeCalculation.tsx or in EReceipt.tsx (the one I shared a screenshot of earlier). We can also add a comment for this change if needed.

[shawnborton]

OK, I suggest using translateZ(0) to fix this thin line issue

Oh, this is a great idea - big fan of doing this as the workaround here!

[mountiny]

@FitseTLT can you please apply that?

[mountiny]

@ntdiary can you do a final retest please? thanks!

[FitseTLT]

I haven't yet applied it @mountiny @ntdiary Give me a min 👍

[FitseTLT]

Applied it and it fixes the problem

[shawnborton]

Awesome, will run a test build to double check as well 👍

[github-actions]

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59944-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59944-hybrid/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59944/NewExpensify.dmg	https://59944.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[ntdiary]

Looks good. :)

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[shawnborton]

Looks good on my end too!

[mountiny]

Thanks for your patience and thorough testing @ntdiary

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅