[Desktop Navigation] Add a responsive LHB by WojtekBoman · Pull Request #60024 · Expensify/App

WojtekBoman · 2025-04-10T12:08:49Z

Explanation of Change

This PR adds support for LHB display on wide layout. This feature is hidden behind the leftHandBar beta.

Fixed Issues

$ #59372
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Verify if the navigation tab bar is displayed correctly on the left side of the screen on a wide layout

Offline tests

Verify if the navigation tab bar is displayed correctly on the left side of the screen on a wide layout

QA Steps

Verify that no errors appear in the JS console

Verify if the navigation tab bar is displayed correctly on the left side of the screen on a wide layout

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-14.at.17.07.20.mov

Android: mWeb Chrome

Screen.Recording.2025-04-14.at.17.09.30.mov

iOS: Native

Screen.Recording.2025-04-15.at.10.03.52.mov

iOS: mWeb Safari

Screen.Recording.2025-04-15.at.10.08.37.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-15.at.14.58.00.mov

MacOS: Desktop

Screen.Recording.2025-04-15.at.14.56.33.mov

WojtekBoman · 2025-04-11T13:54:17Z

@Expensify/design @flaviadefaria @mountiny

Feel free to run builds and test the new LHB :) I still need to improve some features, but it should be ready to check out the new functionality

github-actions · 2025-04-11T13:57:07Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

shawnborton · 2025-04-11T14:39:55Z

This is so awesome.

Minor comment but I think we want to reduce the LHN size to 350px based on Figma mocks, right @Expensify/design ? It's still quite wide in the build:

(Also, totally down to use something other than 350 if we want it to be built on a unit of 4. Mostly just thinking that the LHB adds horizontal space so we should gain it back in the LHN if we can.

dannymcclain · 2025-04-11T20:05:34Z

Siiiiiiiick. It's coming along!

Minor comment but I think we want to reduce the LHN size to 350px based on Figma mocks, right @Expensify/design ? It's still quite wide in the build:
(Also, totally down to use something other than 350 if we want it to be built on a unit of 4. Mostly just thinking that the LHB adds horizontal space so we should gain it back in the LHN if we can.

Yeah in Figma I made it 350 basically exactly for the reason of reclaiming some of the space that the LHB is taking up. Also happy to do a base-4 number like 360, 352, 340, etc. No real strong feelings from me. But we should probably avoid making it TOO narrow since we don't want too too too much truncation in the the Inbox LHN. Any thoughts @dubielzyk-expensify?

dubielzyk-expensify · 2025-04-14T05:03:00Z

Agree with not making it too low, but it's probably important to take the Reports view into consideration given there the LHN doesn't need much but the table does, right? Part of me actually wants to go for 340 (or 344 as it's divisible by 8). Second choice is 352px. I agree with Danny's consern, but I think we need to claw back a bit of main area space.

shawnborton · 2025-04-14T05:50:30Z

I say we try them out and see how they feel! Down to try the smaller sizes (340 or 344) and widen it from there if needed.

WojtekBoman · 2025-04-14T07:31:58Z

@Expensify/design

Let me know when the figma designs are updated, then I'll change the sidebar width in code :)

shawnborton · 2025-04-14T07:38:50Z

Can you try doing 340px and we'll run a quick test build from there?

shawnborton · 2025-04-14T07:39:13Z

Or actually maybe 344px as Jon indicated above :)

WojtekBoman · 2025-04-14T07:57:34Z

Sure, but I have to ask one more thing :)

Currently the sidebar width is also used as RHP width, should this value be reduced as well?

shawnborton · 2025-04-14T07:59:08Z

I would say no, we should leave the RHP width as-is. So seems like we need a new, separate var here.

dukenv0307 · 2025-04-14T10:12:23Z

    );

+    // Temporary solution to display LHB
+    const shouldWrapBottomContentWithView = shouldUseNarrowLayout;


Can you explain why we need it? What happens without this change?

dukenv0307 · 2025-04-14T10:21:37Z

I see the same behavior when I click Expensify Icon or Inbox Icon. Is this correct?

WojtekBoman · 2025-04-14T10:24:54Z

@dukenv0307 It's still in progress, it requires some improvements before it's ready for review

dukenv0307 · 2025-04-14T10:26:29Z

@WojtekBoman Thank you, please let me know when it's ready for review. Thanks

WojtekBoman · 2025-04-14T10:48:03Z

@Expensify/design

I changed the sidebar width to 344px, feel free to run new builds :)

WojtekBoman · 2025-04-14T11:17:21Z

@Expensify/design

As you start testing the new version, please check out the educational tooltips to see if they look good on the new layout 🙏

shawnborton · 2025-04-15T13:38:01Z

Love it, can't wait for this one!

dukenv0307 · 2025-04-15T15:27:28Z

reviewing

dukenv0307 · 2025-04-15T15:40:52Z

@WojtekBoman @shawnborton What do you think about this point?

dannymcclain · 2025-04-15T15:42:08Z

I see the same behavior when I click Expensify Icon or Inbox Icon. Is this correct?

Yes this is the intended behavior!

shawnborton · 2025-04-15T15:47:46Z

Yup, agree!

dukenv0307 · 2025-04-15T15:51:36Z

Code looks good now

dukenv0307 · 2025-04-15T16:04:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-15.at.23.00.13.mov

Android: mWeb Chrome

Screen.Recording.2025-04-15.at.22.58.13.mov

iOS: Native

Screen.Recording.2025-04-15.at.23.00.03.mov

iOS: mWeb Safari

Screen.Recording.2025-04-15.at.22.57.51.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-15.at.22.57.16.mov

MacOS: Desktop

Screen.Recording.2025-04-15.at.23.02.12.mov

mountiny

Thanks, changes look good to me

OSBotify · 2025-04-16T10:04:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-16T21:39:53Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dangrous · 2025-04-18T16:43:38Z

Hi friends! I think this caused #60502 - do you know if there is a design in place for what the debug pop up should look like? not sure how to fix at the moment because I don't know what we're going for. cc @Expensify/design

dannymcclain · 2025-04-18T17:08:51Z

Hmm, I'm honestly not familiar with that pop up and don't know what it's supposed to look like! Is it something separate from the command + d modal and the debug RHP?

dangrous · 2025-04-18T18:37:14Z

ha, it is also new to me to be frank. In the current production build it shows up at the bottom of the LHN, above the menu. I'm guessing it's stuck to that top corner which is why it goes weird when we moved it?

dangrous · 2025-04-18T18:38:43Z

DebugTabView apparently

dannymcclain · 2025-04-18T18:55:36Z

Haha - I bet you're right! I think it should probably just stick to the bottom of the LHN. So basically, same position as it used to be, there just won't be a tab bar below it on desktop.

github-actions · 2025-04-18T20:31:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

shawnborton · 2025-04-21T07:42:45Z

Oh wow, good catch! I agree with Danny's comment above - let's just slap it to the bottom of the LHN, similar to where it used to be.

dangrous · 2025-04-22T20:56:52Z

Great! @WojtekBoman and team, should I assign you to #60502 to knock out that change? Or should we treat it as a new issue?

mountiny · 2025-04-22T21:57:33Z

Assigned Wojtek there

mountiny assigned WojtekBoman Apr 11, 2025

WojtekBoman force-pushed the improve-desktop-nav/lhb branch from 8f6e37c to 074d76e Compare April 11, 2025 11:03

mountiny requested a review from dukenv0307 April 11, 2025 13:58

This comment has been minimized.

Sign in to view

WojtekBoman added 7 commits April 14, 2025 09:13

Display small FAB on wide layout when user has access to lhb

4382bd8

Rename BottomTabBar to NavigationTabBar

0a929fd

Display LHB on a wide layout

713cfd7

Fix lhb margin left on SearchMoneyRequestReportPage

43a1ed3

Fix fab plus icon size in lhb

d285856

Fix displaying TopLevelNavigationTabBar on a wide layout

ab304af

Fix fab tooltip position when lhb is displayed

69fb036

WojtekBoman force-pushed the improve-desktop-nav/lhb branch from 355e0d6 to 69fb036 Compare April 14, 2025 07:27

dukenv0307 reviewed Apr 14, 2025

View reviewed changes

Resize sidebar to 344px when lhb is displayed

8b8cde2

adamgrzybowski approved these changes Apr 15, 2025

View reviewed changes

Rename bottomContent screen wrapper prop names to extraContent

6e94a10

dukenv0307 approved these changes Apr 15, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny April 15, 2025 16:04

mountiny approved these changes Apr 16, 2025

View reviewed changes

mountiny merged commit 7658c9b into Expensify:main Apr 16, 2025
17 checks passed

github-actions Bot mentioned this pull request Apr 16, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

lakchote mentioned this pull request Apr 17, 2025

Expensify logo has same redirection as "Inbox" #60428

Closed

18 tasks

WojtekBoman mentioned this pull request Apr 18, 2025

[Desktop Navigation] Fix UI issues related to LHB #60493

Merged

50 tasks

dangrous mentioned this pull request Apr 18, 2025

[Due for payment 2025-05-08] [Desktop Navigation] Web - LHN - Debug modal is not displayed correctly in LHN #60502

Closed

8 tasks

melvin-bot Bot mentioned this pull request Apr 18, 2025

[Due for payment 2025-05-14] [Due for payment 2025-04-25] [Desktop Navigation] Add a responsive LHB #59372

Closed

allgandalf mentioned this pull request Apr 18, 2025

Onboarding - User is forced back to previous to onboarding page after merge #60477

Closed

8 tasks

Conversation

WojtekBoman commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

WojtekBoman commented Apr 11, 2025

Uh oh!

github-actions Bot commented Apr 11, 2025

Uh oh!

This comment has been minimized.

shawnborton commented Apr 11, 2025

Uh oh!

dannymcclain commented Apr 11, 2025

Uh oh!

dubielzyk-expensify commented Apr 14, 2025

Uh oh!

shawnborton commented Apr 14, 2025

Uh oh!

WojtekBoman commented Apr 14, 2025

Uh oh!

shawnborton commented Apr 14, 2025

Uh oh!

shawnborton commented Apr 14, 2025

Uh oh!

WojtekBoman commented Apr 14, 2025

Uh oh!

shawnborton commented Apr 14, 2025

Uh oh!

dukenv0307 Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Apr 14, 2025

Uh oh!

WojtekBoman commented Apr 14, 2025

Uh oh!

dukenv0307 commented Apr 14, 2025

Uh oh!

WojtekBoman commented Apr 14, 2025

Uh oh!

WojtekBoman commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Apr 15, 2025

Uh oh!

dukenv0307 commented Apr 15, 2025

Uh oh!

dukenv0307 commented Apr 15, 2025

Uh oh!

dannymcclain commented Apr 15, 2025

Uh oh!

shawnborton commented Apr 15, 2025

Uh oh!

dukenv0307 commented Apr 15, 2025

Uh oh!

dukenv0307 commented Apr 15, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Apr 16, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

dangrous commented Apr 18, 2025

Uh oh!

dannymcclain commented Apr 18, 2025

Uh oh!

dangrous commented Apr 18, 2025

Uh oh!

dangrous commented Apr 18, 2025

Uh oh!

WojtekBoman commented Apr 10, 2025 •

edited

Loading

WojtekBoman commented Apr 14, 2025 •

edited

Loading