Fix: On tapping device back button to close troubleshoot box from LHN, navigated out of site by nyomanjyotisa · Pull Request #62345 · Expensify/App

nyomanjyotisa · 2025-05-20T07:45:49Z

Explanation of Change

Fixed Issues

$ #58383
PROPOSAL: #58383 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open the test tool modal with Command + D or a four-finger gesture on mobile.
Tap the browser back button or the device's back button.
Verify that the test tool modal is closed.
Open the search modal with Command + K or tap the search icon at the top.
Tap the browser back button or the device's back button.
Verify that the search modal is closed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

…, navigated out of site

melvin-bot · 2025-05-30T08:33:53Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2025-05-30T16:52:42Z

will review this weekend

hungvu193 · 2025-06-02T02:30:44Z

on Android, when I change options for categories and open test tool modal, it's navigated back to Category main page.

Screen.Recording.2025-06-02.at.09.28.21.mov

nyomanjyotisa · 2025-06-03T00:51:25Z

on Android, when I change options for categories and open test tool modal, it's navigated back to Category main page.

Will check on this today

nyomanjyotisa · 2025-06-03T07:21:00Z

PR updated @hungvu193

hungvu193 · 2025-06-03T08:40:13Z

PR updated @hungvu193

Thanks @nyomanjyotisa I'll do more testing today.
just curious about the previous deploy blocker related to chat switcher. Can you explain the RCA it here so I'll have a better context when reviewing the codes?

nyomanjyotisa · 2025-06-04T08:13:44Z

Can you explain the RCA it here so I'll have a better context when reviewing the codes?

Ah yeah, in the previous PR, we called window.history.back() in the SearchRouterContext to close the search modal, instead of simply setting isSearchModalOpen to false. This caused the modal to take users back to their previous page, instead of letting them proceed to their selected item. In this PR, we’ve fixed that by using window.history.replaceState({ isSearchModalOpen: false }) to close the search modal properly

hungvu193 · 2025-06-05T09:50:13Z

Still under review. The progress is a bit slower since I've been slammed by some other deploy blockers.

hungvu193 · 2025-06-06T02:53:53Z

All the cases I was concerned about were passed 🎉 I'll handle the checklist

nyomanjyotisa · 2025-06-06T03:18:15Z

Should we build the ad-hoc and then ask the QA team to test this PR before you approve it? I think it would be better if the QA team could help. What do you think about this, @hungvu193?

hungvu193 · 2025-06-06T03:19:23Z

yeah I would love if we could do it. What do you think? @blimpich ?

hungvu193 · 2025-06-06T02:55:51Z

+        if (!canListenPopState) {
+            return;
+        }
+
+        const handlePopState = (event: PopStateEvent) => {


it should be helpful if you can leave a comment here to explain how it works.

hungvu193 · 2025-06-06T03:21:54Z

+        TestToolsNavigatorOuterView: (shouldUseNarrowLayout: boolean) => ({
+            flex: 1,
+            justifyContent: shouldUseNarrowLayout ? 'flex-end' : 'center',
+            alignItems: 'center',
+        }),
+
+        TestToolsNavigatorInnerView: (shouldUseNarrowLayout: boolean, isAuthenticated: boolean) => {


These two style name are different with our current convention (camel case), let's change their name to match the current convention then?
I think it can be: getTestToolNavigatorOuterView or so.

Sure thing, PR updated!

blimpich · 2025-06-06T23:37:54Z

Hmm, strange, not sure why the android build failed... 🙁

hungvu193 · 2025-06-07T02:40:45Z

Hmm yeah, that was pretty weird. Could you try again?

github-actions · 2025-06-09T08:52:26Z

🚧 @dylanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

gijoe0295 · 2025-06-09T10:03:05Z

Hi I just came across multiple workflow failures from this PR. They stem from my PR #62058. I knew the root cause and am creating a fix now. If testing Android is not urgent, can you please hold on several hours before @roryabraham gets online and review the fix? Thanks!

hungvu193 · 2025-06-09T10:12:03Z

Yeah. Sure

gijoe0295 · 2025-06-09T10:32:19Z

@hungvu193 @nyomanjyotisa Can you try to merge main and rerun the workflow? There are major changes with the workflow, not just from my PR, and this PR is not up to date with them.

nyomanjyotisa · 2025-06-10T00:13:00Z

I've merged with the latest main

github-actions · 2025-06-10T17:19:20Z

🚧 @dylanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

blimpich · 2025-06-10T17:19:59Z

Re-running ad-hoc build here: https://github.com/Expensify/App/actions/runs/15530663255

github-actions · 2025-06-10T17:51:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #62345.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62345/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62345/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62345/NewExpensify.dmg	https://62345.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

blimpich · 2025-06-10T19:25:31Z

Asked for QA to test this here

isagoico · 2025-06-11T16:02:06Z

Issue was not reproducible on the Ad-Hoc builds 🎉 Videos below

Evidence

az_recorder_20250611_222756.mp4

1000127113.mp4

62345.mp4

hungvu193 · 2025-06-12T02:24:59Z

Nice 🚀. Thanks for checking. I'll handle checklist today!

hungvu193 · 2025-06-12T07:13:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-12.at.15.55.20.mov

Android: mWeb Chrome

Screen.Recording.2025-06-12.at.15.43.13.mov

mAndroid.mov

iOS: HybridApp

fade.mov

push.from.bottom.mov

Screen.Recording.2025-05-08.at.16.26.52.mov

iOS: mWeb Safari

Safari.mov

Screen.Recording.2025-06-12.at.15.00.19.mov

MacOS: Chrome / Safari

Chrome.mov

Screen.Recording.2025-06-12.at.14.52.23.mov

MacOS: Desktop

Desktop.mov

OSBotify · 2025-06-12T20:36:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-12T22:36:35Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.66-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-16T10:57:55Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T15:53:39Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-16T16:14:20Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

nyomanjyotisa added 7 commits May 20, 2025 15:41

Fix: On tapping device back button to close troubleshoot box from LHN…

0bec0f8

…, navigated out of site

lint fix

2dc2146

lint fix

d64c236

Merge branch 'main' into issue-58383-fix

08a4590

minor fix

788e459

prettier

b28da32

Merge branch 'main' into issue-58383-fix

189128b

hungvu193 mentioned this pull request May 28, 2025

[Awaiting checklist] [Due for payment 2025-06-23] [$250][Back nav] LHN - On tapping device back button to close troubleshoot box from LHN, navigated out of site #58383

Closed

8 tasks

minor fix

44a247b

nyomanjyotisa marked this pull request as ready for review May 30, 2025 08:33

nyomanjyotisa requested review from a team as code owners May 30, 2025 08:33

melvin-bot Bot requested review from hungvu193 and removed request for a team May 30, 2025 08:33

Merge branch 'main' into issue-58383-fix

1ad1917

minor fix

7bc83c9

hungvu193 suggested changes Jun 6, 2025

View reviewed changes

minor fix

bf122ab

blimpich added the Ready To Build label Jun 6, 2025

Merge branch 'main' into issue-58383-fix

eaabb7b

Merge branch 'main' into issue-58383-fix

b5695ae

hungvu193 approved these changes Jun 12, 2025

View reviewed changes

melvin-bot Bot requested a review from blimpich June 12, 2025 08:56

blimpich approved these changes Jun 12, 2025

View reviewed changes

blimpich merged commit 38b53fc into Expensify:main Jun 12, 2025
18 checks passed

github-actions Bot mentioned this pull request Jun 12, 2025

Deploy Checklist: New Expensify 2025-06-12 #64109

Closed

44 tasks

srikarparsi mentioned this pull request Jun 13, 2025

[Due for payment 2025-06-24] [Due for payment 2025-06-23] mWeb/Safari-Troubleshoot-Unable to go offline when opening Troubleshoot with a four-finger tap #64141

Closed

8 tasks

lanitochka17 mentioned this pull request Jun 13, 2025

iOS - Unable to close troubleshoot box because there is no back button on IOS device #64177

Closed

16 tasks

bernhardoj mentioned this pull request Jun 20, 2025

[Due for payment 2025-07-22] [$250] Android- Troubleshoot- Unable to scroll troubleshoot panel #64550

Closed

8 tasks

truph01 mentioned this pull request Jun 25, 2025

[HOLD on pull/64717] On mobile if you try to open the debug console it opens behind the pop up so you can’t read or interact with it #64431

Closed

16 tasks

Conversation

nyomanjyotisa commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 30, 2025

Uh oh!

hungvu193 commented May 30, 2025

Uh oh!

hungvu193 commented Jun 2, 2025

Uh oh!

nyomanjyotisa commented Jun 3, 2025

Uh oh!

nyomanjyotisa commented Jun 3, 2025

Uh oh!

hungvu193 commented Jun 3, 2025

Uh oh!

nyomanjyotisa commented Jun 4, 2025

Uh oh!

hungvu193 commented Jun 5, 2025

Uh oh!

hungvu193 commented Jun 6, 2025

Uh oh!

nyomanjyotisa commented Jun 6, 2025

Uh oh!

hungvu193 commented Jun 6, 2025

Uh oh!

hungvu193 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

nyomanjyotisa Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

blimpich commented Jun 6, 2025

Uh oh!

hungvu193 commented Jun 7, 2025

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

gijoe0295 commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Jun 9, 2025

Uh oh!

gijoe0295 commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nyomanjyotisa commented Jun 10, 2025

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

blimpich commented Jun 10, 2025

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

blimpich commented Jun 10, 2025

Uh oh!

isagoico commented Jun 11, 2025

Uh oh!

hungvu193 commented Jun 12, 2025

Uh oh!

hungvu193 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

nyomanjyotisa commented May 20, 2025 •

edited

Loading

gijoe0295 commented Jun 9, 2025 •

edited

Loading

gijoe0295 commented Jun 9, 2025 •

edited

Loading

hungvu193 commented Jun 12, 2025 •

edited

Loading