Fix: mWeb/Safari - Unable to toggle test tool modal #64181
Conversation
|
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
need c+ review here? |
I think we don't need C+ here. I'm the C+ of the offending PR, but the contributor is not available at the moment, so I created this one to address review comment. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Fix: mWeb/Safari - Unable to toggle test tool modal (cherry picked from commit 9212643) (cherry-picked to staging by Julesssss)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.66-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.66-5 🚀
|
Explanation of Change
Fixed Issues
$ #64141
PROPOSAL: N/A
Tests
Force offlineswitch.Offline tests
Same as Tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2025-06-13.at.23.59.57.mov
MacOS: Chrome / Safari
Screen.Recording.2025-06-14.at.00.02.33.mov
MacOS: Desktop
Screen.Recording.2025-06-14.at.00.06.27.mov