Perf/reduce useonyx calls in list item level by martasudol · Pull Request #67065 · Expensify/App

martasudol · 2025-07-24T13:45:04Z

Explanation of Change

Fixed Issues

$ #67165
PROPOSAL: Reduce useOnyx calls on list-item level in TransactionItemRowRBRWithOnyx.

Background:
The transaction list displays many items per report, each rendering with related data like violations. These components rely on hooks to fetch the data required for each item.

Problem:
When each transaction item makes multiple data subscriptions via useTransactionViolations hook, it causes excessive re-renders and slowness in large transaction lists.

Solution:
Move violation data fetching to the parent transaction list component using useReportWithTransactionsAndViolations, which performs a single shared subscription. Pass the resulting violation data down as props to child components like TransactionItemRowRBRWithOnyx and MoneyRequestHeader. This pattern reduces subscriptions from N×4 per report to 1, significantly improving rendering performance while preserving all existing functionality.

=== 📁 Trace File Analysis ===

📄 File: before-open-expense.json
  • Commit count: 93
  • Total render duration: 3142.283 ms
  • p50 / p95 / p99 (ms):
    • p50: 6.694 ms
    • p95: 145.736 ms
    • p99: 307.048 ms

📄 File: profiling-data.24.07.2025.15-28-41.json
  • Commit count: 72
  • Total render duration: 2426.244 ms
  • p50 / p95 / p99 (ms):
    • p50: 6.400 ms
    • p95: 136.388 ms
    • p99: 233.319 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.24.07.2025.15-28-41.json
  🟢 Duration Diff: -716.039 ms
  🟢 Commit Count Diff: -21

Tests

Navigate to Reports tab and verify if list is rendered correctly
Navigate to a single expense report and verify if it renders correctly.
Verify if transaction with violation(s) renders correctly (in the transactions list and in a single item screen).
Verify if violation messages display correctly in header.
As an example flow:

Create a new expense with missing receipt
Verify: "Missing receipt" violation appears
Add the receipt
Verify: Violation disappears
Hold an expense
Verify: Hold status shows correctly
Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Nagranie.z.ekranu.2025-07-25.o.09.33.15.mov

Android: mWeb Chrome

Nagranie.z.ekranu.2025-07-25.o.09.34.50.mov

iOS: Native

Nagranie.z.ekranu.2025-07-25.o.09.25.57.mov

iOS: mWeb Safari

Nagranie.z.ekranu.2025-07-25.o.09.31.25.mov

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-07-25.o.09.32.22.mov

MacOS: Desktop

Nagranie.z.ekranu.2025-07-25.o.09.35.32.mov

adhorodyski · 2025-07-24T13:55:49Z

 };

-function MoneyRequestHeader({report, parentReportAction, policy, onBackButtonPress}: MoneyRequestHeaderProps) {
+function MoneyRequestHeader({report, parentReportAction, policy, onBackButtonPress, transactionViolations = []}: MoneyRequestHeaderProps) {


Let's not default to a new, empty array. Maybe we shouldn't default at all and guard later?

The utility functions already handle undefined gracefully and defaulting to [] is a common React pattern. Without it, we'd need to add ?? [] everywhere we use it. The empty array is reused so no perf impact IMO. Why you think we should not default to an empty array?

Oh it's just this is a new array every time, not a reused reference to an existing one.

melvin-bot · 2025-08-06T07:24:24Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

martasudol · 2025-08-06T07:42:34Z

@roryabraham I think the problem with failing unused styles checker is caused by #63192. Could you please confirm?

amyevans · 2025-08-06T19:20:55Z

@martasudol The unused styles check got fixed in #67987, if you merge main it should clear it up

dukenv0307 · 2025-08-07T14:15:16Z

@martasudol Left some comments. The rest looks good

roryabraham

While it's clear this results in a performance improvement, I'm concerned that it's propagating an (already well-established) bad pattern in our codebase, and that we should focus our efforts on addressing the root cause.

Not going to block on it, because I do want the product to be faster for our customers in the meantime. But overall, I don't feel great about this change.

dukenv0307 · 2025-08-11T14:02:45Z

@martasudol Is it ready for review?

martasudol · 2025-08-12T05:58:22Z

I'm concerned that it's propagating an (already well-established) bad pattern in our codebase

@roryabraham sorry, the link doesn't work for me (is it from a private channel)? Could you elaborate more what bad pattern we're talking about? Thanks in advance!

martasudol · 2025-08-12T06:02:59Z

@martasudol Is it ready for review?

yes, just waiting for Rory's insight about this.

mountiny · 2025-08-12T10:03:49Z

@dukenv0307 you can go ahead with the review, discussed in slack

dukenv0307 · 2025-08-12T10:46:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-12.at.17.38.18.mov

Android: mWeb Chrome

Screen.Recording.2025-08-12.at.17.32.26.mov

iOS: HybridApp

Screen.Recording.2025-08-12.at.17.45.55.mov

iOS: mWeb Safari

Screen.Recording.2025-08-12.at.17.31.50.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-12.at.17.30.12.mov

MacOS: Desktop

amyevans

Looks good!

github-actions · 2025-08-13T21:59:02Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.94-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…-useonyx-calls-in-list-item-level" This reverts commit 7738142, reversing changes made to d6d4030.

github-actions · 2025-08-15T03:41:19Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.94-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-15T03:59:09Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.95-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-18T15:29:32Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.95-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

martasudol added 3 commits July 24, 2025 15:02

perf: reduce useOnyx calls in transaction list-item level

12963de

perf: reduce useOnyx calls in transaction list-item level

5effb9e

perf: reduce useOnyx calls in transaction list-item level

75514e0

TMisiukiewicz reviewed Jul 24, 2025

View reviewed changes

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx Outdated

adhorodyski reviewed Jul 24, 2025

View reviewed changes

martasudol added 8 commits July 25, 2025 09:06

Merge branch 'main' into perf/reduce-useonyx-calls-in-list-item-level

4cfd0a2

perf: avoid spreading in render

b3ee7ac

prettier

891792d

prettier

f41c961

Merge branch 'main' into perf/reduce-useonyx-calls-in-list-item-level

e4dc1dd

eslint

4c068be

Merge branch 'main' into perf/reduce-useonyx-calls-in-list-item-level

ad876ec

prettier

1d95b2e

martasudol marked this pull request as ready for review August 6, 2025 07:23

martasudol requested a review from a team as a code owner August 6, 2025 07:23

melvin-bot Bot requested review from amyevans and removed request for a team August 6, 2025 07:24

martasudol mentioned this pull request Aug 6, 2025

[Due for payment 2025-09-19] [Due for payment 2025-09-17] Reduce useOnyx calls on list-item level in TransactionItemRowRBRWithOnyx. #67165

Closed

mountiny assigned martasudol Aug 6, 2025

Merge branch 'main' into perf/reduce-useonyx-calls-in-list-item-level

5d5339e

mountiny requested a review from dukenv0307 August 7, 2025 10:49

dukenv0307 reviewed Aug 7, 2025

View reviewed changes

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportView.tsx Outdated

dukenv0307 reviewed Aug 7, 2025

View reviewed changes

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportView.tsx Outdated

dukenv0307 reviewed Aug 7, 2025

View reviewed changes

Comment thread src/pages/home/ReportScreen.tsx Outdated

roryabraham reviewed Aug 7, 2025

View reviewed changes

PR comments addressed: util & typing

561fa96

martasudol added 5 commits August 11, 2025 12:09

Merge branch 'main' into perf/reduce-useonyx-calls-in-list-item-level

f26e510

PR comments addressed: util & typing

c1da91b

PR comments addressed: util & typing

d1bc5d5

PR comments addressed: util & typing

1c034dd

revert/ PR comments addressed

aa5747f

PR comments addressed

c023a23

dukenv0307 reviewed Aug 12, 2025

View reviewed changes

Comment thread src/pages/home/ReportScreen.tsx Outdated

use getTransactionIDFromReportAction

a2606e2

dukenv0307 approved these changes Aug 12, 2025

View reviewed changes

amyevans approved these changes Aug 12, 2025

View reviewed changes

roryabraham merged commit 7738142 into Expensify:main Aug 12, 2025
21 checks passed

github-actions Bot mentioned this pull request Aug 12, 2025

[Due for payment 2025-08-22] Investigate workflow job failing on main: lint / ESLint check #68398

Closed

francoisl mentioned this pull request Aug 12, 2025

[NoQA] Add missing prop to fix typecheck in test #68406

Merged

51 tasks

OSBotify mentioned this pull request Aug 13, 2025

Deploy Checklist: New Expensify 2025-08-13 #68475

Closed

64 tasks

BlameGPT mentioned this pull request Aug 14, 2025

[Due for payment 2025-08-22] Expense - Expense row does not show any violation in Inbox #68490

Closed

8 tasks

amyevans added a commit that referenced this pull request Aug 14, 2025

Revert "Merge pull request #67065 from callstack-internal/perf/reduce…

a083eb6

…-useonyx-calls-in-list-item-level" This reverts commit 7738142, reversing changes made to d6d4030.

amyevans mentioned this pull request Aug 14, 2025

[CP Staging] Revert: Perf/reduce useonyx calls in list item level #68557

Merged

51 tasks

Conversation

martasudol commented Jul 24, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

adhorodyski Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

martasudol Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

adhorodyski Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 6, 2025

Uh oh!

martasudol commented Aug 6, 2025

Uh oh!

amyevans commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dukenv0307 commented Aug 7, 2025

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 11, 2025

Uh oh!

martasudol commented Aug 12, 2025

Uh oh!

martasudol commented Aug 12, 2025

Uh oh!

mountiny commented Aug 12, 2025

Uh oh!

Uh oh!

dukenv0307 commented Aug 12, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 13, 2025

Uh oh!

github-actions Bot commented Aug 15, 2025

Uh oh!

OSBotify commented Aug 15, 2025

Uh oh!

OSBotify commented Aug 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

martasudol commented Jul 24, 2025 •

edited by mountiny

Loading